All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Mazon <pascal.mazon@6wind.com>
To: keith.wiles@intel.com
Cc: dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>
Subject: [PATCH v3 6/6] net/tap: add flow control management
Date: Tue,  7 Mar 2017 17:31:38 +0100	[thread overview]
Message-ID: <1488904298-31395-7-git-send-email-pascal.mazon@6wind.com> (raw)
In-Reply-To: <cover.1488817125.git.pascal.mazon@6wind.com>

A tap netdevice does not support flow control; ensure nothing but
RTE_FC_NONE mode can be set.

Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
---
 doc/guides/nics/features/tap.ini |  1 +
 drivers/net/tap/rte_eth_tap.c    | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
index 7f3f4d661dd7..a51712dce066 100644
--- a/doc/guides/nics/features/tap.ini
+++ b/doc/guides/nics/features/tap.ini
@@ -14,6 +14,7 @@ Multicast MAC filter = Y
 Speed capabilities   = Y
 Unicast MAC filter   = Y
 Packet type parsing  = Y
+Flow control         = Y
 Other kdrv           = Y
 ARMv7                = Y
 ARMv8                = Y
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index edb5d2a82f12..cbfb3b9641c8 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -783,6 +783,23 @@ tap_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)
 	return ptypes;
 }
 
+static int
+tap_flow_ctrl_get(struct rte_eth_dev *dev __rte_unused,
+		  struct rte_eth_fc_conf *fc_conf)
+{
+	fc_conf->mode = RTE_FC_NONE;
+	return 0;
+}
+
+static int
+tap_flow_ctrl_set(struct rte_eth_dev *dev __rte_unused,
+		  struct rte_eth_fc_conf *fc_conf)
+{
+	if (fc_conf->mode != RTE_FC_NONE)
+		return -ENOTSUP;
+	return 0;
+}
+
 static const struct eth_dev_ops ops = {
 	.dev_start              = tap_dev_start,
 	.dev_stop               = tap_dev_stop,
@@ -793,6 +810,8 @@ static const struct eth_dev_ops ops = {
 	.tx_queue_setup         = tap_tx_queue_setup,
 	.rx_queue_release       = tap_rx_queue_release,
 	.tx_queue_release       = tap_tx_queue_release,
+	.flow_ctrl_get          = tap_flow_ctrl_get,
+	.flow_ctrl_set          = tap_flow_ctrl_set,
 	.link_update            = tap_link_update,
 	.dev_set_link_up        = tap_link_set_up,
 	.dev_set_link_down      = tap_link_set_down,
-- 
2.8.0.rc0

      parent reply	other threads:[~2017-03-07 16:32 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  9:46 [PATCH 0/6] net/tap: add additional management ops Pascal Mazon
2017-03-03  9:46 ` [PATCH 1/6] net/tap: add MAC address " Pascal Mazon
2017-03-03  9:46 ` [PATCH 2/6] net/tap: add speed capabilities Pascal Mazon
2017-03-03 15:27   ` Wiles, Keith
2017-03-06 13:58     ` Pascal Mazon
2017-03-06 14:38       ` Wiles, Keith
2017-03-03  9:46 ` [PATCH 3/6] net/tap: add multicast addresses management Pascal Mazon
2017-03-03  9:46 ` [PATCH 4/6] net/tap: add MTU management Pascal Mazon
2017-03-03 15:23   ` Wiles, Keith
2017-03-06 13:59     ` Pascal Mazon
2017-03-03  9:46 ` [PATCH 5/6] net/tap: add packet type management Pascal Mazon
2017-03-03 15:31   ` Wiles, Keith
2017-03-06 14:10     ` Pascal Mazon
2017-03-06 14:46       ` Wiles, Keith
2017-03-03  9:46 ` [PATCH 6/6] net/tap: add flow control management Pascal Mazon
2017-03-06 16:31 ` [PATCH v2 0/6] net/tap: add additional management ops Pascal Mazon
2017-03-06 16:31   ` [PATCH v2 1/6] net/tap: add MAC address " Pascal Mazon
2017-03-06 16:31   ` [PATCH v2 2/6] net/tap: add speed capabilities Pascal Mazon
2017-03-06 16:31   ` [PATCH v2 3/6] net/tap: add multicast addresses management Pascal Mazon
2017-03-06 16:31   ` [PATCH v2 4/6] net/tap: add MTU management Pascal Mazon
2017-03-06 16:31   ` [PATCH v2 5/6] net/tap: add packet type management Pascal Mazon
2017-03-06 16:31   ` [PATCH v2 6/6] net/tap: add flow control management Pascal Mazon
2017-03-07 16:31   ` [PATCH v3 0/6] net/tap: add additional management ops Pascal Mazon
2017-03-14  8:22     ` [PATCH v4 0/8] " Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 1/8] net/tap: remove wrong IFF_NOARP flags Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 2/8] net/tap: refactor ioctl calls Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 3/8] net/tap: add MAC address management Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 4/8] net/tap: add MTU management Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 5/8] net/tap: add speed capabilities Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 6/8] net/tap: add multicast addresses management Pascal Mazon
2017-03-14  8:22       ` [PATCH v4 7/8] net/tap: add packet type management Pascal Mazon
2017-03-15 13:35         ` Ferruh Yigit
2017-03-15 13:44           ` Pascal Mazon
2017-03-15 14:31             ` Ferruh Yigit
2017-03-15 13:42         ` Ferruh Yigit
2017-03-14  8:22       ` [PATCH v4 8/8] net/tap: add flow control management Pascal Mazon
2017-03-15 13:43       ` [PATCH v4 0/8] net/tap: add additional management ops Ferruh Yigit
2017-03-15 14:48     ` [PATCH v5 " Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 1/8] net/tap: remove wrong IFF_NOARP flags Pascal Mazon
2017-03-15 21:37         ` Wiles, Keith
2017-03-15 14:48       ` [PATCH v5 2/8] net/tap: refactor ioctl calls Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 3/8] net/tap: add MAC address management Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 4/8] net/tap: add MTU management Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 5/8] net/tap: add speed capabilities Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 6/8] net/tap: add multicast addresses management Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 7/8] net/tap: add packet type management Pascal Mazon
2017-03-15 14:48       ` [PATCH v5 8/8] net/tap: add flow control management Pascal Mazon
2017-03-15 16:46       ` [PATCH v5 0/8] net/tap: add additional management ops Ferruh Yigit
2017-03-15 21:44         ` Wiles, Keith
2017-03-07 16:31   ` [PATCH v3 1/6] net/tap: add MAC address " Pascal Mazon
2017-03-09 14:05     ` Ferruh Yigit
2017-03-10  9:01       ` Pascal Mazon
2017-03-07 16:31   ` [PATCH v3 2/6] net/tap: add speed capabilities Pascal Mazon
2017-03-09 14:18     ` Ferruh Yigit
2017-03-09 14:36       ` Wiles, Keith
2017-03-09 16:05         ` Ferruh Yigit
2017-03-10  9:03           ` Pascal Mazon
2017-03-10  9:11             ` Pascal Mazon
2017-03-07 16:31   ` [PATCH v3 3/6] net/tap: add multicast addresses management Pascal Mazon
2017-03-07 16:31   ` [PATCH v3 4/6] net/tap: add MTU management Pascal Mazon
2017-03-07 16:31   ` [PATCH v3 5/6] net/tap: add packet type management Pascal Mazon
2017-03-09 14:26     ` Ferruh Yigit
2017-03-10 12:34       ` Pascal Mazon
2017-03-07 16:31   ` Pascal Mazon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488904298-31395-7-git-send-email-pascal.mazon@6wind.com \
    --to=pascal.mazon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.