From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v3] drm/i915: Store a permanent error in obj->mm.pages Date: Tue, 07 Mar 2017 19:47:29 +0200 Message-ID: <1488908849.5130.9.camel@linux.intel.com> References: <20170307120338.7277-1-chris@chris-wilson.co.uk> <20170307132031.32461-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 256056E161 for ; Tue, 7 Mar 2017 17:47:30 +0000 (UTC) In-Reply-To: <20170307132031.32461-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: "# v4 . 10+" List-Id: intel-gfx@lists.freedesktop.org T24gdGksIDIwMTctMDMtMDcgYXQgMTM6MjAgKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBP bmNlIHRoZSBvYmplY3QgaGFzIGJlZW4gdHJ1bmNhdGVkLCBpdCBpcyB1bnJlY292ZXJhYmxlLiBU byBmYWNpbGl0YXRlCj4gZGV0ZWN0aW9uIG9mIHRoaXMgc3RhdGUgc3RvcmUgdGhlIGVycm9yIGlu IG9iai0+bW0ucGFnZXMuCj4gCj4gVGhpcyBpcyByZXF1aXJlZCBmb3IgdGhlIG5leHQgcGF0Y2gg d2hpY2ggc2hvdWxkIGJlIGFwcGxpZWQgdG8gdjQuMTAKPiAodmlhIHN0YWJsZSksIHNvIHdlIGFs c28gbmVlZCB0byBtYXJrIHRoaXMgcGF0Y2ggZm9yIGJhY2twb3J0aW5nLiBJbgo+IHRoYXQgcmVn YXJkLCBsZXQncyBjb25zaWRlciB0aGlzIHRvIGJlIGEgZml4L2ltcHJvdmVtZW50IHRvby4KPiAK PiB2MjogQXZvaWQgZGVyZWZlcmVuY2luZyB0aGUgRVJSX1BUUiB3aGVuIGZyZWVpbmcgdGhlIG9i amVjdC4KPiAKPiBGaXhlczogMTIzM2UyZGIxOTlkICgiZHJtL2k5MTU6IE1vdmUgb2JqZWN0IGJh Y2tpbmcgc3RvcmFnZSBtYW5pcHVsYXRpb24gdG8gaXRzIG93biBsb2NraW5nIikKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogSm9v bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiA8c3Rh YmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMCsKCkknZCBpbWFnaW5lIHdlIG1heSB3YW50IGEg Y291cGxlIG1vcmUgR0VNX0JVR19PTiBjaGVja3MgZ29pbmcgZm9yd2FyZC4KUmVnYXJkbGVzczsK ClJldmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+CgpSZWdhcmRzLCBKb29uYXMKLS3CoApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9yYXRpb24KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:16411 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755560AbdCGSCq (ORCPT ); Tue, 7 Mar 2017 13:02:46 -0500 Message-ID: <1488908849.5130.9.camel@linux.intel.com> Subject: Re: [PATCH v3] drm/i915: Store a permanent error in obj->mm.pages From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: "# v4 . 10+" Date: Tue, 07 Mar 2017 19:47:29 +0200 In-Reply-To: <20170307132031.32461-1-chris@chris-wilson.co.uk> References: <20170307120338.7277-1-chris@chris-wilson.co.uk> <20170307132031.32461-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On ti, 2017-03-07 at 13:20 +0000, Chris Wilson wrote: > Once the object has been truncated, it is unrecoverable. To facilitate > detection of this state store the error in obj->mm.pages. > > This is required for the next patch which should be applied to v4.10 > (via stable), so we also need to mark this patch for backporting. In > that regard, let's consider this to be a fix/improvement too. > > v2: Avoid dereferencing the ERR_PTR when freeing the object. > > Fixes: 1233e2db199d ("drm/i915: Move object backing storage manipulation to its own locking") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: # v4.10+ I'd imagine we may want a couple more GEM_BUG_ON checks going forward. Regardless; Reviewed-by: Joonas Lahtinen Regards, Joonas --  Joonas Lahtinen Open Source Technology Center Intel Corporation