diff for duplicates of <1488996103.3098.4.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index e14d410..9e75b11 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,8 +6,8 @@ On Wed, 2017-03-08 at 11:29 -0500, Jeff Layton wrote: > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > --- ->  mm/truncate.c | 6 +++++- ->  1 file changed, 5 insertions(+), 1 deletion(-) +> mm/truncate.c | 6 +++++- +> 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index 6263affdef88..29ae420a5bf9 100644 @@ -15,24 +15,24 @@ On Wed, 2017-03-08 at 11:29 -0500, Jeff Layton wrote: > +++ b/mm/truncate.c > @@ -594,11 +594,15 @@ invalidate_complete_page2(struct address_space > *mapping, struct page *page) ->  ->  static int do_launder_page(struct address_space *mapping, struct +> +> static int do_launder_page(struct address_space *mapping, struct > page *page) ->  { +> { > + int ret; > + ->  if (!PageDirty(page)) ->  return 0; ->  if (page->mapping != mapping || mapping->a_ops->launder_page +> if (!PageDirty(page)) +> return 0; +> if (page->mapping != mapping || mapping->a_ops->launder_page > == NULL) ->  return 0; +> return 0; > - return mapping->a_ops->launder_page(page); > + ret = mapping->a_ops->launder_page(page); > + mapping_set_error(mapping, ret); > + return ret; ->  } ->  ->  /** +> } +> +> /** No. At that layer, you don't know that this is a page error. In the NFS case, it could, for instance, just as well be a fatal signal. @@ -41,4 +41,3 @@ case, it could, for instance, just as well be a fatal signal. Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com -N‹§²æìr¸›zǧu©ž²Æ {\b†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ diff --git a/a/content_digest b/N1/content_digest index 90b05c3..42338cd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -27,8 +27,8 @@ "> \n" "> Signed-off-by: Jeff Layton <jlayton@redhat.com>\n" "> ---\n" - "> \303\202\302\240mm/truncate.c | 6 +++++-\n" - "> \303\202\302\2401 file changed, 5 insertions(+), 1 deletion(-)\n" + "> \302\240mm/truncate.c | 6 +++++-\n" + "> \302\2401 file changed, 5 insertions(+), 1 deletion(-)\n" "> \n" "> diff --git a/mm/truncate.c b/mm/truncate.c\n" "> index 6263affdef88..29ae420a5bf9 100644\n" @@ -36,24 +36,24 @@ "> +++ b/mm/truncate.c\n" "> @@ -594,11 +594,15 @@ invalidate_complete_page2(struct address_space\n" "> *mapping, struct page *page)\n" - "> \303\202\302\240\n" - "> \303\202\302\240static int do_launder_page(struct address_space *mapping, struct\n" + "> \302\240\n" + "> \302\240static int do_launder_page(struct address_space *mapping, struct\n" "> page *page)\n" - "> \303\202\302\240{\n" + "> \302\240{\n" "> +\tint ret;\n" "> +\n" - "> \303\202\302\240\tif (!PageDirty(page))\n" - "> \303\202\302\240\t\treturn 0;\n" - "> \303\202\302\240\tif (page->mapping != mapping || mapping->a_ops->launder_page \n" + "> \302\240\tif (!PageDirty(page))\n" + "> \302\240\t\treturn 0;\n" + "> \302\240\tif (page->mapping != mapping || mapping->a_ops->launder_page \n" "> == NULL)\n" - "> \303\202\302\240\t\treturn 0;\n" + "> \302\240\t\treturn 0;\n" "> -\treturn mapping->a_ops->launder_page(page);\n" "> +\tret = mapping->a_ops->launder_page(page);\n" "> +\tmapping_set_error(mapping, ret);\n" "> +\treturn ret;\n" - "> \303\202\302\240}\n" - "> \303\202\302\240\n" - "> \303\202\302\240/**\n" + "> \302\240}\n" + "> \302\240\n" + "> \302\240/**\n" "\n" "No. At that layer, you don't know that this is a page error. In the NFS\n" "case, it could, for instance, just as well be a fatal signal.\n" @@ -61,7 +61,6 @@ "-- \n" "Trond Myklebust\n" "Linux NFS client maintainer, PrimaryData\n" - "trond.myklebust@primarydata.com\n" - "N\302\213\302\247\302\262\303\246\303\254r\302\270\302\233z\303\207\302\247u\302\251\302\236\302\262\303\206\302\240{\b\302\255\302\206\303\251\303\254\302\271\302\273\034\302\256&\303\236\302\226)\303\256\303\206i\302\242\302\236\303\230^n\302\207r\302\266\302\211\302\232\302\216\302\212\303\235\302\242j$\302\275\302\247$\302\242\302\270\005\302\242\302\271\302\250\302\255\303\250\302\247~\302\212'.)\303\256\303\204\303\203,y\303\250m\302\266\302\237\303\277\303\203\f%\302\212{\302\261\302\232j+\302\203\303\260\303\250\302\236\303\227\302\246j)Z\302\206\302\267\302\237" + trond.myklebust@primarydata.com -76078fcd02917dc06869454cc285af52250cadd4bf98187d6c2a1d0a1597ce33 +2b476f62560fce26a574834df0b9dfd3e4c15e8f8d0e0bacf3bd8864bf04e91c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.