From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: liu.ming50@gmail.com
Cc: Ming Liu <peter.x.liu@external.atlascopco.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Do not append to BBCLASSEXTEND
Date: Wed, 08 Mar 2017 16:02:32 -0600 [thread overview]
Message-ID: <1489010552.3261.35.camel@linux.intel.com> (raw)
In-Reply-To: <1488982634-24222-1-git-send-email-liu.ming50@gmail.com>
Hi
you need to send a v2 revision, following the shortlog format
* Patch Do not append to BBCLASSEXTEND
Issue Shortlog does not follow expected format [test_shortlog_format]
Suggested fix Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"
On Wed, 2017-03-08 at 15:17 +0100, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> Replace some "+=/=+" with "=" when setting BBCLASSEXTEND, they are
> redundant and inconsistent with the same setting in other recipes.
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
> meta/recipes-devtools/build-compare/build-compare_git.bb | 2 +-
> meta/recipes-extended/libsolv/libsolv_0.6.24.bb | 2 +-
> meta/recipes-extended/lzip/lzip_1.18.bb | 2 +-
> meta/recipes-extended/wget/wget.inc | 2 +-
> meta/recipes-support/ca-certificates/ca-certificates_20161130.bb | 2 +-
> meta/recipes-support/lz4/lz4.bb | 2 +-
> meta/recipes-support/lzop/lzop_1.03.bb | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb b/meta/recipes-devtools/build-compare/build-compare_git.bb
> index e432143..eb12e40 100644
> --- a/meta/recipes-devtools/build-compare/build-compare_git.bb
> +++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
> @@ -22,7 +22,7 @@ PV = "git+${SRCPV}"
>
> S = "${WORKDIR}/git"
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
>
> do_install() {
> install -d ${D}/${bindir}
> diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.24.bb b/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
> index 6de38b5..73db5ed 100644
> --- a/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
> +++ b/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
> @@ -27,4 +27,4 @@ FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
> FILES_${PN}-tools = "${bindir}/*"
> FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
>
> -BBCLASSEXTEND =+ "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-extended/lzip/lzip_1.18.bb b/meta/recipes-extended/lzip/lzip_1.18.bb
> index 30c7dd5..c1dc8ce 100644
> --- a/meta/recipes-extended/lzip/lzip_1.18.bb
> +++ b/meta/recipes-extended/lzip/lzip_1.18.bb
> @@ -38,4 +38,4 @@ do_install () {
> fi
> }
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
> index 9eb051f..1299edb 100644
> --- a/meta/recipes-extended/wget/wget.inc
> +++ b/meta/recipes-extended/wget/wget.inc
> @@ -16,7 +16,7 @@ ALTERNATIVE_PRIORITY = "100"
>
> RRECOMMENDS_${PN} += "ca-certificates"
>
> -BBCLASSEXTEND += "nativesdk"
> +BBCLASSEXTEND = "nativesdk"
>
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
> PACKAGECONFIG[libuuid] = "--with-libuuid, --without-libuuid,util-linux"
> diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb b/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
> index e47bad1..42088b9 100644
> --- a/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
> +++ b/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
> @@ -80,4 +80,4 @@ do_install_append_class-native () {
>
> RDEPENDS_${PN} += "openssl"
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-support/lz4/lz4.bb b/meta/recipes-support/lz4/lz4.bb
> index 18e56d0..03c5a7a 100644
> --- a/meta/recipes-support/lz4/lz4.bb
> +++ b/meta/recipes-support/lz4/lz4.bb
> @@ -18,4 +18,4 @@ do_install() {
> oe_runmake install
> }
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-support/lzop/lzop_1.03.bb b/meta/recipes-support/lzop/lzop_1.03.bb
> index 649e724..6f09002 100644
> --- a/meta/recipes-support/lzop/lzop_1.03.bb
> +++ b/meta/recipes-support/lzop/lzop_1.03.bb
> @@ -26,4 +26,4 @@ do_configure_prepend () {
> install -Dm 0644 ${WORKDIR}/acinclude.m4 ${S}/acinclude.m4
> }
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-03-08 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 14:17 [PATCH] Do not append to BBCLASSEXTEND liu.ming50
2017-03-08 22:02 ` Leonardo Sandoval [this message]
2017-03-08 23:08 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489010552.3261.35.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=liu.ming50@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.x.liu@external.atlascopco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.