From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: credit2: remove undefined static function __dump_execstate(). Date: Thu, 9 Mar 2017 10:36:41 +0000 Message-ID: <1489055801.4611.4.camel@citrix.com> References: <148905323991.17295.253127309429140682.stgit@Palanthas> <58C137F7020000780014191D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2994936080729295733==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clvRJ-0003FO-Um for xen-devel@lists.xenproject.org; Thu, 09 Mar 2017 10:36:58 +0000 In-Reply-To: <58C137F7020000780014191D@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel@lists.xenproject.org, George Dunlap List-Id: xen-devel@lists.xenproject.org --===============2994936080729295733== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-kFcw/UfLe/NR3+UxcxXT" --=-kFcw/UfLe/NR3+UxcxXT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-03-09 at 03:09 -0700, Jan Beulich wrote: > > > > On 09.03.17 at 10:54, wrote: > >=20 > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -2437,8 +2437,6 @@ csched2_runtime(const struct scheduler *ops, > > int cpu, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return time; > > =C2=A0} > > =C2=A0 > > -void __dump_execstate(void *unused); >=20 > All fine, except the function wasn't static (or else the compiler > would > have warned about there not being a definition), so perhaps the > subject wants to say "undefined function declaration" or some such. >=20 Right, of course it's not... sorry. What I was aiming was to somehow reinforce the fact that it's only present in this file, but that's not really necessary, and 'static' was very wrong a word for that. I'd be fine with a subject line like: "xen: credit: remove undefined declaration of __dump_execstate()" Let me know if you or George prefer that I resend, or to adjust this upon commit. Or just ignore this mail, and if I don't hear anything for a while, I will just resend. :-) Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-kFcw/UfLe/NR3+UxcxXT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYwTA6AAoJEBZCeImluHPuY/UP/2NyJ1/7nrOXp7sQbgjR2lwc M+/mj/6WxQ6zXlqN6EGf9sB/Fw2ZRBiJ6k8vkS93OTtMF3K9fynIBKknoDPVA8np rVcSd8YBO5ZEPiESiR0w7lVS3rnTXLUu7W1Gy2wiShgfDQTwVSYwj54xZbmt/5pu PoRy+jCS6BMwROOot+TPwVVsVT0LxJLjJaGH8PgApH35MuGxUEw/TBXC8kcRqZKL IM2mlaiEHpmMQw/gTCSqRTcRQhWz4xmtFuLXwojR1YWxQqBUr7Jfb73l8Ygzy91u g1JdSls36yrM/LIzfWgfhdPjMBbce3Mc+ouzcaMU7sQ0ciG1C/lzRq4bVgmlKrrS B6lQLLJVM1VIEd5AZtCB2/5Yz2gMtCfbMFA1KKovCt29+oo1UWjKr4crNa2zLidl OoFQZ08SjWkScmjgogi44gvV0/bRaG22V0RlE50vof/zCUY1pY9q2PT2HbTT4jBT UKKIKhldsWJQnOfd0+3stJukrhILHer7wCIa+1lq+XtLhMci7YiJWGz4NhuK+xCX FX2KDS9GYqtzhb8HMCKgdAqmjKF4rc3fxD7vlSCw5p0bWCPS1/fCX9SPDAE/jqF3 I59Qe8KjY8z2FK5TfwvbJt9cwzg5h++/IL8N52w9wdEYukzIbneG4b7OsFhxgOC7 mclpMZ4b7FwmHPt74+IL =sSap -----END PGP SIGNATURE----- --=-kFcw/UfLe/NR3+UxcxXT-- --===============2994936080729295733== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2994936080729295733==--