diff for duplicates of <1489076712.2597.1.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 7639bc9..d885a15 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Thu, 2017-03-09 at 15:16 +0200, Sagi Grimberg wrote: +On Thu, 2017-03-09@15:16 +0200, Sagi Grimberg wrote: > +int blk_mq_poll_batch(struct request_queue *q, unsigned int batch) > +{ > + struct blk_mq_hw_ctx *hctx; @@ -6,28 +6,23 @@ On Thu, 2017-03-09 at 15:16 +0200, Sagi Grimberg wrote: > + if (!q->mq_ops || !q->mq_ops->poll_batch) > + return 0; > + -> + hctx =3D blk_mq_map_queue(q, smp_processor_id()); +> + hctx = blk_mq_map_queue(q, smp_processor_id()); > + return q->mq_ops->poll_batch(hctx, batch); > +} > +EXPORT_SYMBOL_GPL(blk_mq_poll_batch); A new exported function without any documentation? Wow. Please add a header -above this function that documents at least which other completion processi= -ng -code can execute concurrently with this function and from which contexts th= -e +above this function that documents at least which other completion processing +code can execute concurrently with this function and from which contexts the other completion processing code can be called (e.g. blk_mq_poll() and .complete()). -Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be = -a -WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch= -() +Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be a +WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch() against a queue that does not define .poll_batch(). -Additionally, I think making the hardware context an argument of this funct= -ion +Additionally, I think making the hardware context an argument of this function instead of using blk_mq_map_queue(q, smp_processor_id()) would make this function much more versatile. -Bart.= +Bart. diff --git a/a/content_digest b/N1/content_digest index e94ac81..8b16458 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,11 @@ "ref\01489065402-14757-1-git-send-email-sagi@grimberg.me\0" "ref\01489065402-14757-5-git-send-email-sagi@grimberg.me\0" - "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" - "Subject\0Re: [PATCH rfc 04/10] block: Add a non-selective polling interface\0" + "From\0Bart.VanAssche@sandisk.com (Bart Van Assche)\0" + "Subject\0[PATCH rfc 04/10] block: Add a non-selective polling interface\0" "Date\0Thu, 9 Mar 2017 16:25:26 +0000\0" - "To\0linux-rdma@vger.kernel.org <linux-rdma@vger.kernel.org>" - linux-block@vger.kernel.org <linux-block@vger.kernel.org> - linux-nvme@lists.infradead.org <linux-nvme@lists.infradead.org> - target-devel@vger.kernel.org <target-devel@vger.kernel.org> - " sagi@grimberg.me <sagi@grimberg.me>\0" "\00:1\0" "b\0" - "On Thu, 2017-03-09 at 15:16 +0200, Sagi Grimberg wrote:\n" + "On Thu, 2017-03-09@15:16 +0200, Sagi Grimberg wrote:\n" "> +int blk_mq_poll_batch(struct request_queue *q, unsigned int batch)\n" "> +{\n" "> +\tstruct blk_mq_hw_ctx *hctx;\n" @@ -18,30 +13,25 @@ "> +\tif (!q->mq_ops || !q->mq_ops->poll_batch)\n" "> +\t\treturn 0;\n" "> +\n" - "> +\thctx =3D blk_mq_map_queue(q, smp_processor_id());\n" + "> +\thctx = blk_mq_map_queue(q, smp_processor_id());\n" "> +\treturn q->mq_ops->poll_batch(hctx, batch);\n" "> +}\n" "> +EXPORT_SYMBOL_GPL(blk_mq_poll_batch);\n" "\n" "A new exported function without any documentation? Wow. Please add a header\n" - "above this function that documents at least which other completion processi=\n" - "ng\n" - "code can execute concurrently with this function and from which contexts th=\n" - "e\n" + "above this function that documents at least which other completion processing\n" + "code can execute concurrently with this function and from which contexts the\n" "other completion processing code can be called (e.g. blk_mq_poll() and\n" ".complete()).\n" "\n" - "Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be =\n" - "a\n" - "WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch=\n" - "()\n" + "Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be a\n" + "WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch()\n" "against a queue that does not define .poll_batch().\n" "\n" - "Additionally, I think making the hardware context an argument of this funct=\n" - "ion\n" + "Additionally, I think making the hardware context an argument of this function\n" "instead of using blk_mq_map_queue(q, smp_processor_id()) would make this\n" "function much more versatile.\n" "\n" - Bart.= + Bart. -fa61b3fa95a3ab8cea39756c33ac8c24bca56a46b2fd15b6313a1c2e0ec30ce9 +d71fc3a217d5175d4599fa1e45f0fd667511f6ab804064612c344458d29f7f25
diff --git a/a/1.txt b/N2/1.txt index 7639bc9..155253d 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,28 +6,26 @@ On Thu, 2017-03-09 at 15:16 +0200, Sagi Grimberg wrote: > + if (!q->mq_ops || !q->mq_ops->poll_batch) > + return 0; > + -> + hctx =3D blk_mq_map_queue(q, smp_processor_id()); +> + hctx = blk_mq_map_queue(q, smp_processor_id()); > + return q->mq_ops->poll_batch(hctx, batch); > +} > +EXPORT_SYMBOL_GPL(blk_mq_poll_batch); A new exported function without any documentation? Wow. Please add a header -above this function that documents at least which other completion processi= -ng -code can execute concurrently with this function and from which contexts th= -e +above this function that documents at least which other completion processing +code can execute concurrently with this function and from which contexts the other completion processing code can be called (e.g. blk_mq_poll() and .complete()). -Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be = -a -WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch= -() +Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be a +WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch() against a queue that does not define .poll_batch(). -Additionally, I think making the hardware context an argument of this funct= -ion +Additionally, I think making the hardware context an argument of this function instead of using blk_mq_map_queue(q, smp_processor_id()) would make this function much more versatile. -Bart.= +Bart.-- +To unsubscribe from this list: send the line "unsubscribe linux-rdma" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index e94ac81..99b55a3 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,13 +1,14 @@ "ref\01489065402-14757-1-git-send-email-sagi@grimberg.me\0" "ref\01489065402-14757-5-git-send-email-sagi@grimberg.me\0" - "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" + "ref\01489065402-14757-5-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org\0" + "From\0Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>\0" "Subject\0Re: [PATCH rfc 04/10] block: Add a non-selective polling interface\0" "Date\0Thu, 9 Mar 2017 16:25:26 +0000\0" - "To\0linux-rdma@vger.kernel.org <linux-rdma@vger.kernel.org>" - linux-block@vger.kernel.org <linux-block@vger.kernel.org> - linux-nvme@lists.infradead.org <linux-nvme@lists.infradead.org> - target-devel@vger.kernel.org <target-devel@vger.kernel.org> - " sagi@grimberg.me <sagi@grimberg.me>\0" + "To\0linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" + linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> + target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + " sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>\0" "\00:1\0" "b\0" "On Thu, 2017-03-09 at 15:16 +0200, Sagi Grimberg wrote:\n" @@ -18,30 +19,28 @@ "> +\tif (!q->mq_ops || !q->mq_ops->poll_batch)\n" "> +\t\treturn 0;\n" "> +\n" - "> +\thctx =3D blk_mq_map_queue(q, smp_processor_id());\n" + "> +\thctx = blk_mq_map_queue(q, smp_processor_id());\n" "> +\treturn q->mq_ops->poll_batch(hctx, batch);\n" "> +}\n" "> +EXPORT_SYMBOL_GPL(blk_mq_poll_batch);\n" "\n" "A new exported function without any documentation? Wow. Please add a header\n" - "above this function that documents at least which other completion processi=\n" - "ng\n" - "code can execute concurrently with this function and from which contexts th=\n" - "e\n" + "above this function that documents at least which other completion processing\n" + "code can execute concurrently with this function and from which contexts the\n" "other completion processing code can be called (e.g. blk_mq_poll() and\n" ".complete()).\n" "\n" - "Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be =\n" - "a\n" - "WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch=\n" - "()\n" + "Why to return if (!q->mq_ops || !q->mq_ops->poll_batch)? Shouldn't that be a\n" + "WARN_ON_ONCE() instead? I think it is an error to calling blk_mq_poll_batch()\n" "against a queue that does not define .poll_batch().\n" "\n" - "Additionally, I think making the hardware context an argument of this funct=\n" - "ion\n" + "Additionally, I think making the hardware context an argument of this function\n" "instead of using blk_mq_map_queue(q, smp_processor_id()) would make this\n" "function much more versatile.\n" "\n" - Bart.= + "Bart.--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-rdma\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -fa61b3fa95a3ab8cea39756c33ac8c24bca56a46b2fd15b6313a1c2e0ec30ce9 +a93122de8acf4b90577ae1db81a2989b4fbfb6327d575324aa1c0420184ae0d5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.