All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
	Mark Asselstine <mark.asselstine@windriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFT] brcmfmac: add support to move wiphy instance into network namespace
Date: Tue, 14 Mar 2017 23:19:27 +0100	[thread overview]
Message-ID: <1489529967.10872.16.camel@sipsolutions.net> (raw)
In-Reply-To: <1489528312-28304-1-git-send-email-arend.vanspriel@broadcom.com> (sfid-20170314_225203_353339_3E88A6E0)

On Tue, 2017-03-14 at 21:51 +0000, Arend van Spriel wrote:
> To support network namespace the driver must assure all created
> network interfaces are in the same namespace as the wiphy instance.

FWIW, looks fine to me.

>  	memcpy(ndev->dev_addr, ifp->mac_addr, ETH_ALEN);
> +	wiphy = cfg_to_wiphy(drvr->config);
> +	dev_net_set(ndev, wiphy_net(wiphy));

You (almost?) don't need the wiphy variable :)

johannes

  reply	other threads:[~2017-03-14 22:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 21:51 [RFT] brcmfmac: add support to move wiphy instance into network namespace Arend van Spriel
2017-03-14 22:19 ` Johannes Berg [this message]
2017-03-15  8:54   ` Arend Van Spriel
2017-03-16 21:51 ` Mark Asselstine
2017-03-17  8:21   ` Arend Van Spriel
2017-03-17  9:06   ` Arend Van Spriel
2017-03-17  9:24     ` Johannes Berg
2017-03-17  9:33       ` Arend Van Spriel
2017-03-17  9:36       ` Arend Van Spriel
2017-03-17  9:30     ` Arend Van Spriel
2017-03-17 12:43       ` Mark Asselstine
2017-03-17 12:58         ` Johannes Berg
2017-03-17 13:05           ` Mark Asselstine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489529967.10872.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mark.asselstine@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.