All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: ed.bartosh@linux.intel.com
Cc: Gary Thomas <gary@mlbassoc.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: Create more than one image with WIC
Date: Wed, 15 Mar 2017 16:04:39 +0100	[thread overview]
Message-ID: <1489590279.6396.110.camel@intel.com> (raw)
In-Reply-To: <20170315140143.GA17397@linux.intel.com>

On Wed, 2017-03-15 at 16:01 +0200, Ed Bartosh wrote:
> On Wed, Mar 15, 2017 at 02:41:34PM +0100, Patrick Ohly wrote:
> > On Wed, 2017-03-15 at 14:39 +0100, Patrick Ohly wrote:
> > > On Wed, 2017-03-15 at 14:58 +0200, Ed Bartosh wrote:
> > > > Regarding do_rm_work. It should not touch rootfs directories, I believe.
> > > 
> 
> > It does, and it should by default because a rootfs can be quite large.
> > If it's not going to be reused in another recipe, then it is worthwhile
> > to remove it.
> This is true unless we're going to use wic as a stand-alone tool, which some
> people still do.
> 
> > I should add that RM_WORK_EXCLUDE_ITEMS += "rootfs" can be used in image
> > recipes which know that their rootfs is going to be needed elsewhere -
> > it's just not the default.
> 
> Isn't rootfs going to be rebuilt if one rootfs recipe depends on another one?

No, that's now how it works. Suppose there's a
image-a:do_image_wic->image-b:do_rootfs task dependency. That dependency
ensures that image-b:do_rootfs runs before image-a:do_image_wic. But it
does not delay image-b:do_rm_work until image-a:do_image_wic is done.

That could be fixed by also adding a
image-b:do_rm_work->image-a:do_image_wic dependency. As I said,
something that works out of the box for this use case would be nice...
we can't expect developers to figure all of this out themselves.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





      parent reply	other threads:[~2017-03-15 15:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  9:44 Create more than one image with WIC Daniel Schultz
2017-03-08 10:57 ` Ed Bartosh
2017-03-08 13:41   ` Gary Thomas
2017-03-08 13:43     ` Ed Bartosh
2017-03-13 16:16       ` Daniel Schultz
2017-03-14 17:11         ` Ed Bartosh
2017-03-14 17:49           ` Patrick Ohly
2017-03-14 18:06             ` Ed Bartosh
2017-03-15  7:24               ` Patrick Ohly
2017-03-15 12:58                 ` Ed Bartosh
2017-03-15 13:39                   ` Patrick Ohly
2017-03-15 13:41                     ` Patrick Ohly
2017-03-15 14:01                       ` Ed Bartosh
2017-03-15 14:47                         ` Ed Bartosh
2017-03-15 15:09                           ` Patrick Ohly
2017-03-15 15:04                         ` Patrick Ohly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489590279.6396.110.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=ed.bartosh@linux.intel.com \
    --cc=gary@mlbassoc.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.