From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: iwona260909@gmail.com, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.
Date: Thu, 16 Mar 2017 15:12:20 +0100 [thread overview]
Message-ID: <1489673540.15659.93.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA8ZBAAqYNbh_3J69W5SMXRsbW4S367Xe8ceF1C0M-RNnA@mail.gmail.com>
Hi,
> > -#define DEPTH 8
> > -#include "cirrus_vga_rop2.h"
> > -
> > -#define DEPTH 16
> > -#include "cirrus_vga_rop2.h"
> > -
> > -#define DEPTH 24
> > -#include "cirrus_vga_rop2.h"
> > -
> > #define DEPTH 32
> > #include "cirrus_vga_rop2.h"
No. It isn't *that* simple. The cirrus blitter operates on the guest
framebuffer, which can have any format the guest wishes it to have.
This is *not* about rendering into a 32bpp DisplaySurface.
cheers,
Gerd
next prev parent reply other threads:[~2017-03-16 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 12:01 [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH iwona260909
2017-03-16 12:01 ` iwona260909
2017-03-16 12:07 ` Peter Maydell
2017-03-16 14:12 ` Gerd Hoffmann [this message]
2017-03-16 14:26 ` Paolo Bonzini
2017-03-24 13:36 ` Stefan Hajnoczi
2017-03-24 13:40 ` Peter Maydell
2017-03-27 6:23 ` Gerd Hoffmann
2017-03-29 14:56 ` Iwona Kotlarska
2017-03-27 6:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489673540.15659.93.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=iwona260909@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.