From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coW8h-0000Dp-Hw for qemu-devel@nongnu.org; Thu, 16 Mar 2017 10:12:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coW8d-00069x-Io for qemu-devel@nongnu.org; Thu, 16 Mar 2017 10:12:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51704) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1coW8d-000695-Dj for qemu-devel@nongnu.org; Thu, 16 Mar 2017 10:12:23 -0400 Message-ID: <1489673540.15659.93.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 16 Mar 2017 15:12:20 +0100 In-Reply-To: References: <20170316120110.11677-1-iwona260909@gmail.com> <20170316120110.11677-2-iwona260909@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: iwona260909@gmail.com, QEMU Developers Hi, > > -#define DEPTH 8 > > -#include "cirrus_vga_rop2.h" > > - > > -#define DEPTH 16 > > -#include "cirrus_vga_rop2.h" > > - > > -#define DEPTH 24 > > -#include "cirrus_vga_rop2.h" > > - > > #define DEPTH 32 > > #include "cirrus_vga_rop2.h" No. It isn't *that* simple. The cirrus blitter operates on the guest framebuffer, which can have any format the guest wishes it to have. This is *not* about rendering into a 32bpp DisplaySurface. cheers, Gerd