From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Sebastian Reichel <sre@kernel.org>,
Chen-Yu Tsai <wens@csie.org>
Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/4] power: supply: axp288_fuel_gauge: Unregister duplicate ACPI battery supply
Date: Thu, 16 Mar 2017 18:33:10 +0200 [thread overview]
Message-ID: <1489681990.19767.23.camel@linux.intel.com> (raw)
In-Reply-To: <20170316161601.32267-4-hdegoede@redhat.com>
On Thu, 2017-03-16 at 17:16 +0100, Hans de Goede wrote:
> On some systems with axp288 PMIC the dsdt also exports an ACPI battery
> device (PNP0C0A device). This leads to there being 2 battery
> power_supply-s registed like this:
>
> ~$ acpi
> Battery 0: Charging, 84%, 00:49:39 until charged
> Battery 1: Unknown, 0%, rate information unavailable
>
> Note that the ACPI battery device does not work properly this is due
> to Linux missing support for the vendor specific BMOP ACPI opregion.
> But even if the ACPI battery where to function fine we still do not
> want to export the same battery to userspace twice.
>
> Therefor this commit calls acpi_battery_unregister() after
> successfully
> registering the axp288-fuel-gauge power_supply to remove the duplicate
> (and often broken) ACPI battery power_supply.
> + # if ACPI_BATTERY=m, this can't be 'y'
Driver dependencies? Deferred probe?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-03-16 16:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 16:15 [PATCH 0/4] Avoid duplicate registering of ACPI and native power-supplies Hans de Goede
2017-03-16 16:15 ` [PATCH 1/4] acpi: battery: Add acpi_battery_unregister() function Hans de Goede
2017-03-16 16:29 ` Andy Shevchenko
2017-03-20 13:03 ` Hans de Goede
2017-03-20 13:10 ` Andy Shevchenko
2017-03-20 13:11 ` Hans de Goede
2017-03-27 1:16 ` Zheng, Lv
2017-03-31 8:53 ` Hans de Goede
2017-03-31 9:00 ` Hans de Goede
2017-03-16 16:15 ` [PATCH 2/4] acpi: ac: Add acpi_ac_unregister() function Hans de Goede
2017-03-16 16:31 ` Andy Shevchenko
2017-03-16 16:16 ` [PATCH 3/4] power: supply: axp288_fuel_gauge: Unregister duplicate ACPI battery supply Hans de Goede
2017-03-16 16:33 ` Andy Shevchenko [this message]
2017-03-20 13:07 ` Hans de Goede
2017-03-29 20:31 ` Rafael J. Wysocki
2017-03-31 9:01 ` Hans de Goede
2017-03-31 9:05 ` Rafael J. Wysocki
2017-03-31 9:08 ` Hans de Goede
2017-03-31 9:11 ` Rafael J. Wysocki
2017-03-31 9:57 ` Hans de Goede
2017-03-31 22:30 ` Rafael J. Wysocki
2017-04-01 13:22 ` Hans de Goede
2017-04-07 7:18 ` Hans de Goede
2017-04-10 7:31 ` Hans de Goede
2017-04-10 18:13 ` Hans de Goede
2017-04-10 20:01 ` Rafael J. Wysocki
2017-04-11 9:18 ` Hans de Goede
2017-04-11 13:51 ` Rafael J. Wysocki
2017-03-16 16:16 ` [PATCH 4/4] power: supply: axp288_charger: Unregister duplicate ACPI ac supply Hans de Goede
2017-03-16 16:34 ` Andy Shevchenko
2017-03-20 1:33 ` [PATCH 0/4] Avoid duplicate registering of ACPI and native power-supplies Sebastian Reichel
2017-03-20 13:11 ` Hans de Goede
2017-03-20 13:18 ` Andy Shevchenko
2017-03-20 13:19 ` Hans de Goede
2017-03-20 21:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489681990.19767.23.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.