From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id A1AF66B0038 for ; Thu, 16 Mar 2017 16:32:30 -0400 (EDT) Received: by mail-qk0-f197.google.com with SMTP id 9so53291464qkk.6 for ; Thu, 16 Mar 2017 13:32:30 -0700 (PDT) Received: from smtprelay.hostedemail.com (smtprelay0253.hostedemail.com. [216.40.44.253]) by mx.google.com with ESMTPS id j63si101983ita.124.2017.03.16.13.32.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 13:32:29 -0700 (PDT) Message-ID: <1489696343.13953.11.camel@perches.com> Subject: Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks From: Joe Perches Date: Thu, 16 Mar 2017 13:32:23 -0700 In-Reply-To: <20170316105627.GB30508@dhcp22.suse.cz> References: <880b3172b67d806082284d80945e4a231a5574bb.1489628459.git.joe@perches.com> <20170316105627.GB30508@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Thu, 2017-03-16 at 11:56 +0100, Michal Hocko wrote: > On Wed 15-03-17 18:43:13, Joe Perches wrote: > > Function calls with large argument counts cause x86-64 register > > spilling. Reducing the number of arguments in a multi-line printk > > by converting to multiple printks which saves some object code size. > > > > $ size mm/page_alloc.o* (defconfig) > > text data bss dec hex filename > > 35914 1699 628 38241 9561 mm/page_alloc.o.new > > 36018 1699 628 38345 95c9 mm/page_alloc.o.old > > > > Miscellanea: > > > > o Remove line leading spaces from the formerly multi-line printks > > commit a25700a53f71 ("mm: show bounce pages in oom killer output") > > back in 2007 started the leading space when a single long line > > was split into multiple lines but the leading space was likely > > mistakenly kept and subsequent commits followed suit. > > o Align arguments in a few more printks > > This is really hard to review. Could you just drop all the whitespace > changes please? It's a single, simple change. It's IMO trivial to review. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279AbdCPUdG (ORCPT ); Thu, 16 Mar 2017 16:33:06 -0400 Received: from smtprelay0038.hostedemail.com ([216.40.44.38]:50492 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752122AbdCPUdF (ORCPT ); Thu, 16 Mar 2017 16:33:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2195:2199:2393:2553:2559:2562:2828:2911:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:4250:4321:4425:5007:6119:7653:7901:7903:8603:10004:10400:10848:11232:11658:11914:12555:12700:12737:12740:12760:12895:12986:13069:13311:13357:13439:13972:14096:14097:14181:14659:14721:21080:21433:21434:30012:30034:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:7,LUA_SUMMARY:none X-HE-Tag: stem00_32948cfa46619 X-Filterd-Recvd-Size: 2058 Message-ID: <1489696343.13953.11.camel@perches.com> Subject: Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks From: Joe Perches To: Michal Hocko Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Thu, 16 Mar 2017 13:32:23 -0700 In-Reply-To: <20170316105627.GB30508@dhcp22.suse.cz> References: <880b3172b67d806082284d80945e4a231a5574bb.1489628459.git.joe@perches.com> <20170316105627.GB30508@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-16 at 11:56 +0100, Michal Hocko wrote: > On Wed 15-03-17 18:43:13, Joe Perches wrote: > > Function calls with large argument counts cause x86-64 register > > spilling. Reducing the number of arguments in a multi-line printk > > by converting to multiple printks which saves some object code size. > > > > $ size mm/page_alloc.o* (defconfig) > > text data bss dec hex filename > > 35914 1699 628 38241 9561 mm/page_alloc.o.new > > 36018 1699 628 38345 95c9 mm/page_alloc.o.old > > > > Miscellanea: > > > > o Remove line leading spaces from the formerly multi-line printks > > commit a25700a53f71 ("mm: show bounce pages in oom killer output") > > back in 2007 started the leading space when a single long line > > was split into multiple lines but the leading space was likely > > mistakenly kept and subsequent commits followed suit. > > o Align arguments in a few more printks > > This is really hard to review. Could you just drop all the whitespace > changes please? It's a single, simple change. It's IMO trivial to review.