diff for duplicates of <1489696763.2944.42.camel@buserror.net> diff --git a/a/1.txt b/N1/1.txt index 852695b..ff0e6c1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,21 +1,21 @@ -On Fri, 2017-03-03 at 16:52 +0200, Horia Geantă wrote: +On Fri, 2017-03-03 at 16:52 +0200, Horia Geant? wrote: > Add helper functions, macros, #defines for accessing / enabling > qman functionality from caam/qi driver, such that this driver > is not aware of the need for data conversion to big endian. -Why? I complained about that (probably internally) when this driver was +Why? ?I complained about that (probably internally) when this driver was originally submitted. Having a bunch of accessors in a header file that just do an assignment with -an endian conversion just obfuscates things. The driver still needs to know +an endian conversion just obfuscates things. ?The driver still needs to know that the conversion needs to happen, or else it wouldn't know that the fields can't be accessed directly... and it gets particularly ridiculous when a single field has a growing pile of accessors depending on exactly what flags -you want to set (e.g. qm_sg_entry_set_*). Just open-code it unless an +you want to set (e.g. qm_sg_entry_set_*). ?Just open-code it unless an accessor is justified by the call sites getting unwieldy or numerous. It looks like GCC 6 has added an attribute (scalar_storage_order) that could -be used on structs to avoid having to manually swap such things. I look +be used on structs to avoid having to manually swap such things. ?I look forward to the day when GCC 6 is old enough for the kernel to depend on this. -Scott diff --git a/a/content_digest b/N1/content_digest index 96311cb..3ca24c0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,40 +1,31 @@ "ref\01488552733-20806-1-git-send-email-horia.geanta@nxp.com\0" "ref\01488552733-20806-5-git-send-email-horia.geanta@nxp.com\0" - "From\0Scott Wood <oss@buserror.net>\0" - "Subject\0Re: [RFC 4/7] soc/qman: add helper functions needed by caam/qi driver\0" + "From\0oss@buserror.net (Scott Wood)\0" + "Subject\0[RFC 4/7] soc/qman: add helper functions needed by caam/qi driver\0" "Date\0Thu, 16 Mar 2017 15:39:23 -0500\0" - "To\0Horia Geant\304\203 <horia.geanta@nxp.com>" - Herbert Xu <herbert@gondor.apana.org.au> - " Roy Pledge <roy.pledge@nxp.com>\0" - "Cc\0linux-crypto@vger.kernel.org" - linux-arm-kernel@lists.infradead.org - Dan Douglass <dan.douglass@nxp.com> - Alexandru Porosanu <alexandru.porosanu@nxp.com> - Vakul Garg <vakul@nxp.com> - Cristian Stoica <cristian.stoica@nxp.com> - " Claudiu Manoil <claudiu.manoil@nxp.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Fri, 2017-03-03 at 16:52 +0200, Horia Geant\304\203 wrote:\n" + "On Fri, 2017-03-03 at 16:52 +0200, Horia Geant? wrote:\n" "> Add helper functions, macros, #defines for accessing / enabling\n" "> qman functionality from caam/qi driver, such that this driver\n" "> is not aware of the need for data conversion to big endian.\n" "\n" - "Why? \302\240I complained about that (probably internally) when this driver was\n" + "Why? ?I complained about that (probably internally) when this driver was\n" "originally submitted.\n" "\n" "Having a bunch of accessors in a header file that just do an assignment with\n" - "an endian conversion just obfuscates things. \302\240The driver still needs to know\n" + "an endian conversion just obfuscates things. ?The driver still needs to know\n" "that the conversion needs to happen, or else it wouldn't know that the fields\n" "can't be accessed directly... and it gets particularly ridiculous when a\n" "single field has a growing pile of accessors depending on exactly what flags\n" - "you want to set (e.g. qm_sg_entry_set_*). \302\240Just open-code it unless an\n" + "you want to set (e.g. qm_sg_entry_set_*). ?Just open-code it unless an\n" "accessor is justified by the call sites getting unwieldy or numerous.\n" "\n" "It looks like GCC 6 has added an attribute (scalar_storage_order) that could\n" - "be used on structs to avoid having to manually swap such things. \302\240I look\n" + "be used on structs to avoid having to manually swap such things. ?I look\n" "forward to the day when GCC 6 is old enough for the kernel to depend on this.\n" "\n" -Scott -7fc11a13ae31b1daad55bb05c1280ae4ae6f1a5d772ca3b6c7414bfd0b42041e +3b5634abda175d42e4d367487c368992bef565deacba5d488265fa80f7de3341
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.