All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 3/8] file-posix: Don't leak fd in hdev_get_max_segments
Date: Fri, 17 Mar 2017 14:15:41 +0100	[thread overview]
Message-ID: <1489756546-27142-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1489756546-27142-1-git-send-email-kwolf@redhat.com>

From: Fam Zheng <famz@redhat.com>

This fixes a leaked fd introduced in commit 9103f1ce.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/file-posix.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/file-posix.c b/block/file-posix.c
index ac6bd9f..53febd3 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -703,6 +703,9 @@ static int hdev_get_max_segments(const struct stat *st)
     }
 
 out:
+    if (fd != -1) {
+        close(fd);
+    }
     g_free(sysfspath);
     return ret;
 #else
-- 
1.8.3.1

  parent reply	other threads:[~2017-03-17 13:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 13:15 [Qemu-devel] [PULL 0/8] Block layer fixes for 2.9.0-rc1 Kevin Wolf
2017-03-17 13:15 ` [Qemu-devel] [PULL 1/8] file-posix: clean up max_segments buffer termination Kevin Wolf
2017-03-17 13:15 ` [Qemu-devel] [PULL 2/8] replication: clarify permissions Kevin Wolf
2017-04-18  1:23   ` Eric Blake
2017-04-18  1:36     ` Hailiang Zhang
2017-04-18  2:52       ` Xie Changlong
2017-03-17 13:15 ` Kevin Wolf [this message]
2017-03-17 13:15 ` [Qemu-devel] [PULL 4/8] block: Always call bdrv_child_check_perm first Kevin Wolf
2017-03-17 13:15 ` [Qemu-devel] [PULL 5/8] blockdev: fix bitmap clear undo Kevin Wolf
2017-03-17 13:15 ` [Qemu-devel] [PULL 6/8] block: Propagate error in bdrv_open_backing_file Kevin Wolf
2017-03-17 13:15 ` [Qemu-devel] [PULL 7/8] thread-pool: add missing qemu_bh_cancel in completion function Kevin Wolf
2017-03-17 13:15 ` [Qemu-devel] [PULL 8/8] block: quiesce AioContext when detaching from it Kevin Wolf
2017-03-17 14:03 ` [Qemu-devel] [PULL 0/8] Block layer fixes for 2.9.0-rc1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489756546-27142-4-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.