diff for duplicates of <1489783004.2826.13.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 8033135..668c89c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,11 @@ On Sat, 2017-03-18 at 02:32 +0800, Ming Lei wrote: > On Sat, Mar 18, 2017 at 1:32 AM, Bart Van Assche wrote: > > + /* -> > + * Avoid that the updates of the queue flags and q_usage_counte= -r +> > + * Avoid that the updates of the queue flags and q_usage_counter > > + * are reordered. > > + */ > > + smp_wmb(); ->=20 +> > atomic_inc_return() in blk_mq_freeze_queue_start() does imply a > barrier(smp_mb()). @@ -14,9 +13,8 @@ Hello Ming, It's probably a good idea to mention that in a comment. The implementation of blk_mq_freeze_queue_start() namely could be changed in the future such -that it uses another atomic operation that doesn't implicitly perform smp_m= -b(). +that it uses another atomic operation that doesn't implicitly perform smp_mb(). Thanks, -Bart.= +Bart. diff --git a/a/content_digest b/N1/content_digest index 8100ede..3ba703a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -17,12 +17,11 @@ "On Sat, 2017-03-18 at 02:32 +0800, Ming Lei wrote:\n" "> On Sat, Mar 18, 2017 at 1:32 AM, Bart Van Assche wrote:\n" "> > + /*\n" - "> > + * Avoid that the updates of the queue flags and q_usage_counte=\n" - "r\n" + "> > + * Avoid that the updates of the queue flags and q_usage_counter\n" "> > + * are reordered.\n" "> > + */\n" "> > + smp_wmb();\n" - ">=20\n" + "> \n" "> atomic_inc_return() in blk_mq_freeze_queue_start() does imply a\n" "> barrier(smp_mb()).\n" "\n" @@ -30,11 +29,10 @@ "\n" "It's probably a good idea to mention that in a comment. The implementation\n" "of blk_mq_freeze_queue_start() namely could be changed in the future such\n" - "that it uses another atomic operation that doesn't implicitly perform smp_m=\n" - "b().\n" + "that it uses another atomic operation that doesn't implicitly perform smp_mb().\n" "\n" "Thanks,\n" "\n" - Bart.= + Bart. -a634b97b9013e467d7893dd8232c52bf9bd1d0f11579069afdb8de0788888ab6 +a96d8d2828100f20e607b1199f1e6674e9d9d39d259d456e8e86d4168da97e99
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.