From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 2/2] drm/i915/vbt: split out defaults that are set when there is no VBT Date: Mon, 20 Mar 2017 13:57:51 -0300 Message-ID: <1490029071.2571.3.camel@intel.com> References: <95c26079ff640d43f53b944f17e9fc356b36daec.1489152288.git.jani.nikula@intel.com> <20170310235759.GB3175@intel.com> <87lgs9fqlo.fsf@intel.com> <20170313163009.GA8626@intel.com> <87mvcotec2.fsf@intel.com> <1489782064.2442.220.camel@intel.com> <87inn4e1a3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79BD96E630 for ; Mon, 20 Mar 2017 16:58:22 +0000 (UTC) In-Reply-To: <87inn4e1a3.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Manasi Navare Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org RW0gU2VnLCAyMDE3LTAzLTIwIMOgcyAxMTozOCArMDIwMCwgSmFuaSBOaWt1bGEgZXNjcmV2ZXU6 Cj4gT24gRnJpLCAxNyBNYXIgMjAxNywgUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRl bC5jb20+IHdyb3RlOgo+ID4gCj4gPiBFbSBUZXIsIDIwMTctMDMtMTQgw6BzIDExOjA5ICswMjAw LCBKYW5pIE5pa3VsYSBlc2NyZXZldToKPiA+ID4gCj4gPiA+IE9uIE1vbiwgMTMgTWFyIDIwMTcs IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiA+IHdyb3RlOgo+ ID4gPiA+IAo+ID4gPiA+IAo+ID4gPiA+IE9uIE1vbiwgTWFyIDEzLCAyMDE3IGF0IDExOjU1OjMx QU0gKzAyMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4g PiA+IE9uIFNhdCwgMTEgTWFyIDIwMTcsIE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp bnRlbC5jb20KPiA+ID4gPiA+ID4KPiA+ID4gPiA+IHdyb3RlOgo+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gCj4gPiA+ID4gPiA+IE9uIEZyaSwgTWFyIDEwLCAyMDE3IGF0IDAzOjI3OjU4UE0gKzAy MDAsIEphbmkgTmlrdWxhCj4gPiA+ID4gPiA+IHdyb3RlOgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFRoZSBtYWluIHRoaW5nIGFyZSB0aGUgRERJIHBvcnRzLiBJ ZiB0aGVyZSdzIGEgVkJUIHRoYXQKPiA+ID4gPiA+ID4gPiBzYXlzCj4gPiA+ID4gPiA+ID4gdGhl cmUgYXJlCj4gPiA+ID4gPiA+ID4gbm8gb3V0cHV0cywgd2Ugc2hvdWxkIHRydXN0IHRoYXQsIGFu ZCBub3QgaGF2ZSBzZW1pLQo+ID4gPiA+ID4gPiA+IHJhbmRvbQo+ID4gPiA+ID4gPiA+IGRlZmF1 bHRzLiBVbmZvcnR1bmF0ZWx5LCB0aGUgZGVmYXVsdHMgaGF2ZSByZXN1bHRlZCBpbgo+ID4gPiA+ ID4gPiA+IHNvbWUKPiA+ID4gPiA+ID4gPiBDaHJvbWVib29rcwo+ID4gPiA+ID4gPiA+IHdpdGhv dXQgVkJUIHRvIHJlbHkgb24gdGhpcyBiZWhhdmlvdXIsIHNvIHdlIHNwbGl0IG91dAo+ID4gPiA+ ID4gPiA+IHRoZQo+ID4gPiA+ID4gPiA+IGRlZmF1bHRzIGZvcgo+ID4gPiA+ID4gPiA+IHRoZSBt aXNzaW5nIFZCVCBjYXNlLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IENjOiBNYW5hc2kg TmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiA+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+ID4gPiA+ IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiA+ ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i aW9zLmMgfCAxNyArKysrKysrKysrKysrKysrLQo+ID4gPiA+ID4gPiA+IMKgMSBmaWxlIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4g PiA+ID4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+ID4gPiA+ ID4gPiBpbmRleCA3MTA5ODhkNzIyNTMuLjYzOWQ0NWMxZGQyZSAxMDA2NDQKPiA+ID4gPiA+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+ID4gPiA+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+ID4gPiA+ID4gPiBAQCAt MTM0MSw2ICsxMzQxLDcgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0Cj4gPiA+ID4gPiA+ ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ID4gPiA+ID4gwqAJcmV0dXJuOwo+ ID4gPiA+ID4gPiA+IMKgfQo+ID4gPiA+ID4gPiA+IMKgCj4gPiA+ID4gPiA+ID4gKy8qIENvbW1v biBkZWZhdWx0cyB3aGljaCBtYXkgYmUgb3ZlcnJpZGRlbiBieSBWQlQuICovCj4gPiA+ID4gPiA+ ID4gwqBzdGF0aWMgdm9pZAo+ID4gPiA+ID4gPiA+IMKgaW5pdF92YnRfZGVmYXVsdHMoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ID4gPiA+IMKgewo+ID4gPiA+ID4g PiA+IEBAIC0xMzc3LDYgKzEzNzgsMTggQEAgaW5pdF92YnRfZGVmYXVsdHMoc3RydWN0Cj4gPiA+ ID4gPiA+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4gPiA+ID4gwqAJCQkm ZGV2X3ByaXYtCj4gPiA+ID4gPiA+ID4gPnZidC5kZGlfcG9ydF9pbmZvW3BvcnRdOwo+ID4gPiA+ ID4gPiA+IMKgCj4gPiA+ID4gPiA+ID4gwqAJCWluZm8tPmhkbWlfbGV2ZWxfc2hpZnQgPQo+ID4g PiA+ID4gPiA+IEhETUlfTEVWRUxfU0hJRlRfVU5LTk9XTjsKPiA+ID4gPiA+ID4gPiArCX0KPiA+ ID4gPiA+ID4gPiArfQo+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiArLyogRGVmYXVsdHMg dG8gaW5pdGlhbGl6ZSBvbmx5IGlmIHRoZXJlIGlzIG5vIFZCVC4gKi8KPiA+ID4gPiA+ID4gPiAr c3RhdGljIHZvaWQKPiA+ID4gPiA+ID4gPiAraW5pdF92YnRfbWlzc2luZ19kZWZhdWx0cyhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ID4gPiA+ID4gPiA+ICpkZXZfcHJpdikKPiA+ID4gPiA+ID4g PiArewo+ID4gPiA+ID4gPiA+ICsJZW51bSBwb3J0IHBvcnQ7Cj4gPiA+ID4gPiA+ID4gKwo+ID4g PiA+ID4gPiA+ICsJZm9yIChwb3J0ID0gUE9SVF9BOyBwb3J0IDwgSTkxNV9NQVhfUE9SVFM7Cj4g PiA+ID4gPiA+ID4gcG9ydCsrKSB7Cj4gPiA+ID4gPiA+ID4gKwkJc3RydWN0IGRkaV92YnRfcG9y dF9pbmZvICppbmZvID0KPiA+ID4gPiA+ID4gPiArCQkJJmRldl9wcml2LQo+ID4gPiA+ID4gPiA+ ID52YnQuZGRpX3BvcnRfaW5mb1twb3J0XTsKPiA+ID4gPiA+ID4gPiDCoAo+ID4gPiA+ID4gPiA+ IMKgCQlpbmZvLT5zdXBwb3J0c19kdmkgPSAocG9ydCAhPSBQT1JUX0EgJiYKPiA+ID4gPiA+ID4g PiBwb3J0Cj4gPiA+ID4gPiA+ID4gIT0gUE9SVF9FKTsKPiA+ID4gPiA+ID4gPiDCoAkJaW5mby0+ c3VwcG9ydHNfaGRtaSA9IGluZm8tCj4gPiA+ID4gPiA+ID4gPnN1cHBvcnRzX2R2aTsKPiA+ID4g PiA+ID4gPiBAQCAtMTUxNiw4ICsxNTI5LDEwIEBAIHZvaWQgaW50ZWxfYmlvc19pbml0KHN0cnVj dAo+ID4gPiA+ID4gPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ID4gPiA+ IMKgCXBhcnNlX2RkaV9wb3J0cyhkZXZfcHJpdiwgYmRiKTsKPiA+ID4gPiA+ID4gPiDCoAo+ID4g PiA+ID4gPiA+IMKgb3V0Ogo+ID4gPiA+ID4gPiA+IC0JaWYgKCF2YnQpCj4gPiA+ID4gPiA+ID4g KwlpZiAoIXZidCkgewo+ID4gPiA+ID4gPiA+IMKgCQlEUk1fSU5GTygiRmFpbGVkIHRvIGZpbmQg VkJJT1MgdGFibGVzCj4gPiA+ID4gPiA+ID4gKFZCVClcbiIpOwo+ID4gPiA+ID4gPiA+ICsJCWlu aXRfdmJ0X21pc3NpbmdfZGVmYXVsdHMoZGV2X3ByaXYpOwo+ID4gPiA+ID4gPiA+ICsJfQo+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gU28gaW4gY2FzZSB0aGVyZSBpcyBubyBWQlQsIHRoaXMgd2ls bCBzZXQgc3VwcG9ydHNfRFAgZmxhZwo+ID4gPiA+ID4gPiBvbgo+ID4gPiA+ID4gPiBQb3J0IEEu Cj4gPiA+ID4gPiA+IFdoYXQgaXMgdGhlcmUgaXMgbm8gVkJUIGFuZCB0aGVyZSBpcyBubyBlRFAg b24gUG9ydCBBPwo+ID4gPiA+ID4gPiBJbiB0aGlzIGNhc2UgaXQgd2lsbCBzdGlsbCB0cnkgdG8g bGluayB0cmFpbiBvbiBQb3J0IEEgYW5kCj4gPiA+ID4gPiA+IGZhaWwuLj8KPiA+ID4gPiA+ID4g SSBhbSBub3Qgc3VyZSBpZiB0aGlzIGNhc2UgZXhpc3RzLCBidXQganVzdCBhIHRob3VnaHQKPiA+ ID4gPiA+ID4gbG9va2luZwo+ID4gPiA+ID4gPiBhdCBpdC4KPiA+ID4gPiA+IAo+ID4gPiA+ID4g SXQncyBwb3NzaWJsZSB0aGUgY2FzZSBleGlzdHMsIGJ1dCB0aGUgcG9pbnQgaXMgdGhhdCB0aGUK PiA+ID4gPiA+IGJlaGF2aW91ciBmb3IKPiA+ID4gPiA+IHRoZSBuby1WQlQgY2FzZSByZW1haW5z IHRoZSBzYW1lIGJlZm9yZSBhbmQgYWZ0ZXIgdGhpcyBwYXRjaC4KPiA+ID4gPiA+IAo+ID4gPiA+ ID4gQlIsCj4gPiA+ID4gPiBKYW5pLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiAKPiA+ ID4gPiBPayBhZ3JlZWQuIEluIHRoYXQgY2FzZSBSZXZpZXdlZC1ieTogTWFuYXNpIE5hdmFyZQo+ ID4gPiA+IDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gPiAKPiA+ID4gUHVzaGVkIHRv IGRybS1pbnRlbC1uZXh0LXF1ZXVlZCwgdGhhbmtzIGZvciB0aGUgcmV2aWV3Lgo+ID4gPiAKPiA+ ID4gSSByZWFsbHkgaG9wZSB0aGVyZSBhcmUgbm8gbWFjaGluZXMgb3V0IHRoZXJlIHRoYXQgaGF2 ZSBhCj4gPiA+IGNyaXBwbGVkCj4gPiA+IFZCVAo+ID4gPiB3aXRoIG5vIGNoaWxkIGRldmljZSBj b25maWcuIEkgZ3Vlc3Mgd2UnbGwgZmluZCBvdXQuLi4KPiA+IAo+ID4gSSBoYXZlIGFjY2VzcyB0 byB0aGlzIHZlcnkgaW50ZXJlc3RpbmcgbWFjaGluZSB3aXRoIEREQiB2ZXJzaW9uIDE2Mwo+ID4g YW5kCj4gPiBhIGNoaWxkIGRldmljZSBzaXplIGNvbmZpZyB0aGF0J3MgMSBpbnN0ZWFkIG9mIHRo ZSBleHBlY3RlZCAzMy4KPiA+IAo+ID4gU28gd2hhdCBoYXBwZW5zIGhlcmUgaXMgdGhhdCBzaW5j ZSB0aGUgVkJUIGlzIHN1cHBvc2VkIHRvIGJlIHZhbGlkCj4gPiB3ZQo+ID4gZG9uJ3QgZW5kIHVw IGNhbGxpbmcgaW5pdF92YnRfbWlzc2luZ19kZWZhdWlsdHMoKS4gV2UgcmV0dXJuIGVhcmx5Cj4g PiBmcm9tCj4gPiBwYXJzZV9kZXZpY2VfbWFwcGluZygpLCB3aGljaCBtZWFucyB3ZSBkb24ndCBz ZXQgdmJ0LmNoaWxkX2Rldl9udW0sCj4gPiB3aGljaCBtZWFucyB0aGF0IHBhcnNlX2RkaV9wb3J0 KCkgcmV0dXJucyBlYXJseS4gU28gaW5mby0KPiA+ID5zdXBwb3J0c18qCj4gPiBzdGF5cyBmYWxz ZSwgYW5kIGludGVsX2RkaV9pbml0KCkgZmFpbHMuCj4gPiAKPiA+IEdpdmVuIHlvdXIgY29tbWl0 IG1lc3NhZ2UgaXQgc2VlbXMgdGhhdCB3ZSBzaG91bGQgcHJvcGVybHkgYmUgYWJsZQo+ID4gdG8K PiA+IGRpc3Rpbmd1aXNoIGJldHdlZW4gIlZCVCBjb3JyZWN0bHkgc2F5cyB0aGF0IHRoZXJlJ3Mg bm8gb3V0cHV0IiBhbmQKPiA+ICJWQlQgaXMgZHJ1bmsgYW5kIHNob3VsZCBnbyBob21lIiBpbiBv cmRlciB0byBmaXggdGhpcyBwcm9ibGVtLgo+IAo+IEknbSBub3Qgc3VyZSBpdCdzIHBvc3NpYmxl IHRvIGRpc3Rpbmd1aXNoIGJldHdlZW4gdGhlIHR3by4gSSB0aG91Z2h0Cj4gd2UnZCBiZSBhYmxl IHRvIHJlbHkgb24gdGhlIGZvcm1lci4KCkFyZSB5b3Ugc3VyZT8gVGhlIGNvZGUgSSdtIGhpdHRp bmcgaXMgdGhhdCBjaGlsZF9kZXZfc2l6ZSAhPSBleHBlY3RlZApzaXplLCB3aGljaCB0cmFuc2xh dGVzIHRvICJ3ZSBmYWlsZWQgdG8gcGFyc2UgdGhlIFZCVCIuIElzIHRoaXMgZXhhY3RseQp3aGF0 IHlvdSBzZWUgaW4gdGhlIG5vLW91dHB1dCBtYWNoaW5lcz8gSSB3b3VsZCBleHBlY3Qgbm8tb3V0 cHV0Cm1hY2hpbmVzIHdvdWxkIGhhdmUgYSBWQlQgdGhhdCBhY3R1YWxseSBwYXJzZXMgY29ycmVj dGx5IGJ1dAppbnRlbnRpb25hbGx5IGxlYXZlcyB5b3Ugd2l0aCBjaGlsZF9kZXZpY2VfbnVtID0g MC4KClRoZW4sIHdoYXQgd2UnZCBuZWVkIHRvIGRvIHdvdWxkIGJlIHRvIG1ha2UgdGhvc2UgcGFy c2Vfc29tZXRoaW5nCmZ1bmN0aW9ucyByZXR1cm4gZXJyb3IgY29kZXMgd2hlbiB0aGUgVkJUIHdh cyBtYWxmb3JtZWQsIHNvIHdlJ2QgYmUKYWJsZSB0byBkaWZmZXJlbnRpYXRlIGJldHdlZW4gaW50 ZW50aW9uYWwgY2hpbGRfZGV2X251bT0wIG9yIHBhcnNlCmZhaWx1cmVzLgoKCj4gIElmIHdlIGhh dmUgdG8gY2hhbmdlCj4gImluaXRfdmJ0X21pc3NpbmdfZGVmYXVsdHMiIHRvICJpbml0X2NoaWxk X2Rldl9taXNzaW5nX2RlZmF1bHRzIiwKPiB0aGVuCj4gd2UnbGwgbmV2ZXIgYmUgYWJsZSB0byBo YW5kbGUgdGhlIGNhc2Ugd2hlcmUgdmJ0IGNvcnJlY3RseSBzdGF0ZXMKPiB0aGVyZQo+IGFyZSBu byBjaGlsZCBkZXZpY2VzLiA6KAo+IAo+IEJSLAo+IEphbmkuCj4gCj4gCj4gPiAKPiA+IEkgY2Fu IGNvbmZpcm0gdGhhdCByZXZlcnRpbmcgdGhpcyBwYXRjaCBtYWtlcyBkaXNwbGF5IGdyZWF0Cj4g PiBhZ2Fpbl53XncKPiA+IHdvcmsgYWdhaW4uIFNvIHVuZm9ydHVuYXRlbHkgSSdsbCBoYXZlIHRv IGNhbGwgcmVncmVzc2lvbiBvbiB0aGlzCj4gPiBwYXRjaC4KPiA+IAo+ID4gPiAKPiA+ID4gCj4g PiA+IEJSLAo+ID4gPiBKYW5pLgo+ID4gPiAKPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ ID4gCj4gPiA+ID4gUmVnYXJkcwo+ID4gPiA+IE1hbmFzaQo+ID4gPiA+IAo+ID4gPiA+IMKgCj4g PiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ IElmIHN1Y2ggYSBjYXNlIGRvZXMgbm90IGV4aXN0LCB0aGVuIHRoaXMgd2lsbCBzb2x2ZSBvdXIK PiA+ID4gPiA+ID4gcHJvYmxlbQo+ID4gPiA+ID4gPiBvZgo+ID4gPiA+ID4gPiBjdXJyZW50IGZh aWx1cmVzIGJlY2F1c2UgbGVhdmluZyBkZWZhdWx0cyBvbiBQb3J0IEEuIFNvIGluCj4gPiA+ID4g PiA+IHRoYXQKPiA+ID4gPiA+ID4gY2FzZQo+ID4gPiA+ID4gPiBpdCBsZ3RtLgo+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gUmVnYXJkcwo+ID4gPiA+ID4gPiBNYW5hc2kKPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IMKg Cj4gPiA+ID4gPiA+ID4gwqAJaWYgKGJpb3MpCj4gPiA+ID4gPiA+ID4gwqAJCXBjaV91bm1hcF9y b20ocGRldiwgYmlvcyk7Cj4gPiA+ID4gPiA+ID4gLS3CoAo+ID4gPiA+ID4gPiA+IDIuMS40Cj4g PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IC0twqAKPiA+ID4gPiA+IEphbmkgTmlr dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgo+ID4gPiAKPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==