From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] boot/uboot: fix build for sunxi targets
Date: Tue, 21 Mar 2017 08:36:25 +0100 [thread overview]
Message-ID: <1490081785.14952.1.camel@embedded.rocks> (raw)
In-Reply-To: <20170320223252.791ca511@free-electrons.com>
Hi Thomas,
On Mon, 2017-03-20 at 22:32 +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Thu,??9 Mar 2017 12:52:47 +0100, J?rg Krause wrote:
>
> > +# The binman tool was introduced in version 2017.01. The tool is a
> > set
> > +# python scripts and requires a python2 interpreter. Force the
> > shebang
> > +# python2 to ensure the correct interpreter is used on host
> > systems
> > +# where python defaults to the python3 interpreter.?
> > +define UBOOT_TRY_SED_SHEBANG_BINMAN
> > + if test -f $(@D)/tools/binman/binman; then \
> > + sed -i '1s_^\(#!/usr/bin/env \).*_\1python2_' \
> > + $(@D)/tools/binman/binman; \
> > + fi
> > +endef
> > +UBOOT_POST_PATCH_HOOKS += UBOOT_TRY_SED_SHEBANG_BINMAN
>
> Thanks for this. However, now that the issue has been fixed upstream,
> I'm not sure I'm willing to make our uboot.mk more complicated to fix
> a
> problem that:
>
> ?1. Only occurs with sunxi targets and a few x86 platforms
>
> ?2. Only occurs with 2017.01 exactly. binman didn't exist before, and
> ????2017.03 was fixed in time.
>
> So I'm tempted to put the burden on people using 2017.01 on those few
> platforms to carry the small patch (or upgrade to 2017.03).
>
> What do you think?
I'm fine with dumping this patch. I'll mark it as superseded.
J?rg
next prev parent reply other threads:[~2017-03-21 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 11:52 [Buildroot] [PATCH v3] boot/uboot: fix build for sunxi targets Jörg Krause
2017-03-20 21:32 ` Thomas Petazzoni
2017-03-21 7:36 ` Jörg Krause [this message]
2017-03-21 8:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490081785.14952.1.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.