From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v7] xen: Allow a default compiled-in command line using Kconfig Date: Tue, 21 Mar 2017 09:59:23 +0100 Message-ID: <1490086763.15340.14.camel@citrix.com> References: <20170321084353.11690-1-blackskygg@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7828793813388032859==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqFdd-00022Q-44 for xen-devel@lists.xenproject.org; Tue, 21 Mar 2017 08:59:33 +0000 In-Reply-To: <20170321084353.11690-1-blackskygg@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Zhongze Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============7828793813388032859== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-dQNPAcdw3rFKubWdUCyC" --=-dQNPAcdw3rFKubWdUCyC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-03-21 at 16:43 +0800, Zhongze Liu wrote: > This allows downstreams to set their defaults without modifying the > source code > all over the place. Also probably useful for the embedded space. > (See Also: https://xenproject.atlassian.net/browse/XEN-41) >=20 > Added 2 new config entries in common/Kconfig: > =C2=A0=C2=A0=C2=A0=C2=A0CMDLINE and CMDLINE_OVERRIDE > Modified common/kernel.c:cmdline_parse(). >=20 > The 2 new entries enable an embedded command line to be compiled > in the hypervisor. CMDLINE depends on EXPERT =3D "y", and > CMDLINE_OVERRIDE > depends on CMDLINE !=3D "". >=20 Well, Jan also said: "albeit I think the commit message should have what is now the 4th paragraph first, with what are currently 1st and 2nd paragraphs dropped altogether." And those "1st and 2nd paragraphs" refers to, in this version, the text that goes from "Added 2 new..." to "...depends on CMDLINE !=3D """, which, for what is worth, I agree does not add much and should be dropped. Although it's probably not a super big deal... Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-dQNPAcdw3rFKubWdUCyC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJY0OtrAAoJEBZCeImluHPuNkcP/2EisIrz/eWRQNX707/VV2kI md0T1rzisFxqqP/Tigxnqx+5fxrIcPDtQ+oC5sf5L4OqNB08NyYUiLgz5pfFXngK +mmlEepDQ8aGqooaP1zu+ElLiloTi19PMQXFv5M+a20qkUJ1uLAQVQ8jhI4doAvo jkGVE/ao5Rt5CeT7QEKNcuTKsmlaLbBHgoDZm/ZznxTQ5f8r0hkpf7YgydKJ8WtU /rUpA5VxKuVxJ7OV9EgNj5EcEXehEKeqZMVjy9MhsNT6pBV9FcBghkN530Ejsyo8 Lhl6UIoyc6TpLG7BSmSO5ujpyK4pnZrRqFdwk/7prkv2ULM+pbMrBfWhN+CBBNRs zrapqefgt1GEV2x25Sfr1vgxADvzE+qwm0L2JDBXSzeFP2a68Bp8Fo42EKNiGwyr xf3PD+VrMf6iFDpFWHm89DeE9O3xeDrKcighF9inTNKApCW0TTYSW7Y6f4SSTCKv H2WmChF4RrbRspVfNIY4zfKrmaYZg1YGs+imlQAxQE9h2K6xCkmOUsNKZCRVo9wY u8bftG7RhBo/U/wqLDp8q0Zfkp1n3KJFGwMD/yBovXH5EHrhjEUDncfqEtLJAi3v 63+FyofcdqgMdbuOnRyD2ZcJ2hNhvSMhT5VP4sK5Z5RCTfdhNgn3uaiYgZqQuLTf V2p+LeK7yB2QfRIWg58K =va1o -----END PGP SIGNATURE----- --=-dQNPAcdw3rFKubWdUCyC-- --===============7828793813388032859== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7828793813388032859==--