From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v7] xen: Allow a default compiled-in command line using Kconfig Date: Tue, 21 Mar 2017 10:30:16 +0100 Message-ID: <1490088616.15340.16.camel@citrix.com> References: <20170321084353.11690-1-blackskygg@gmail.com> <1490086763.15340.14.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2312204931372898432==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqG7f-0004jc-Op for xen-devel@lists.xenproject.org; Tue, 21 Mar 2017 09:30:35 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Zhongze Liu Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============2312204931372898432== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-UBzt0lovj9zI2Yv/sDPM" --=-UBzt0lovj9zI2Yv/sDPM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-03-21 at 17:17 +0800, Zhongze Liu wrote: : > > On Tue, 2017-03-21 at 16:43 +0800, Zhongze Liu wrote: > > >=20 > Added 2 new config entries in common/Kconfig: > > > =C2=A0=C2=A0=C2=A0=C2=A0CMDLINE and CMDLINE_OVERRIDE > > > Modified common/kernel.c:cmdline_parse(). > > >=20 > > > The 2 new entries enable an embedded command line to be compiled > > > in the hypervisor. CMDLINE depends on EXPERT =3D "y", and > > > CMDLINE_OVERRIDE > > > depends on CMDLINE !=3D "". > > >=20 > >=20 > > And those "1st and 2nd paragraphs" refers to, in this version, the > > text > > that goes from "Added 2 new..." to "...depends on CMDLINE !=3D """, > > which, for what is worth, I agree does not add much and should be > > dropped. > >=20 > I thought these two paragraphs help people reading this message > understand more clearly what has been touched and what has been > done. > Right. And in fact, coming up with good changelogs is definitely not the easiest part of preparing a patch. :-) It's, therefore, quite difficult to come up with rules that can be called truly general. In this specific case, all the information conveyed by those paragraphs is already there, e.g., by looking at the diffstat (during the review process) and at the code. And the purpose of the commit message is not to explain *what* the code does (or, let's say, not at this level of details), but other things, such as: - why there were the need for the patch; - why the code does what it does in the specific way it does it. :-) It's certainly not straightforward to draw a line, and even people that are doing this for ages not always get it right at the first time, and there's always room for learning and improving... That's why we often mention things like this. :-D > Although, as you put it, this is really not a super big dea, I'll try > to make > my commit message more concise in my later patches. >=20 It's not necessarily a matter of length. Much more so a matter of redundancy and of what kind of information is there. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-UBzt0lovj9zI2Yv/sDPM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJY0PKoAAoJEBZCeImluHPukjIP/imE4SKmD97KcC+1i64C0uEu QurByTblADAFSgs+qEFuJtR900KK/6jmL9Q71MVREUGMtMKpsemfGzmPxR+U1lEA 73Dj0ZR1w16KFrzdP0sjW9pj25TcxUthGWckq0lHakImQWu77tuGpSIbVfidqxJ4 +NaV9XgV2QsJNCCTPUhek2Gc3SwjmG6R7XkOLFoMA7vqcigvJ7cReb5X/Sj7Epyi 7IgvXq2LkLqLU0ANRWDwFz5/oqL7BTeEu/zXcnoGB4xgRx2+WDashW0Kjopi1MVr KQQYhMXfSOWTMF+7DCTWzncam/cZJDLRBkZ2Q1BZE6OaqbL1p3427YOROT5MUEbq OkOx4MgTvNlhQVzZOznsal7XmVPpmq/SWdtveGy1V2lfRvYycLdQKMtBbbH1j1oz QygQZvXatbGWXBql7mqM5vVn8Fwoh7qXI2SQA4OOhUqjnldnJWE33c4K1iq43lBo FgDUTPGY6VW3JRlF2YZO+kqbYCazfNPDV+tb0QjRQUgt6TXxpwsQVMEqr4d/GzSP e82XmZJgsVGCiIaT0VXRU4dVCQ7kxIfZAGx+bWW5YMPexba0lfumm8JOVMv6U4hY dLfkJeYBtJKLLdx3oQcTUoeBEnRYRlUh/Da7lNAWEobyw4b9sdyj4HgllwKYhEYj JVxrfDcNx1BvG9qmHYPh =oS3D -----END PGP SIGNATURE----- --=-UBzt0lovj9zI2Yv/sDPM-- --===============2312204931372898432== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2312204931372898432==--