From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Rosin <peda@axentia.se>, Tin Huynh <tnhuynh@apm.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: i2c-mux-pca954x ACPI case
Date: Tue, 21 Mar 2017 14:18:23 +0200 [thread overview]
Message-ID: <1490098703.19767.120.camel@linux.intel.com> (raw)
In-Reply-To: <7a78677b-3a43-f30f-33c4-0086da38ef72@axentia.se>
On Mon, 2017-03-20 at 17:38 +0100, Peter Rosin wrote:
> On 2017-03-20 17:04, Andy Shevchenko wrote:
> > The commit bbf9d262a147aeaeee0bf4e1c121166d69e556d4 ("i2c: mux:
> > pca954x:
> > Add ACPI support for pca954x") adds a so called "ACPI support" for
> > the
> > driver and thus I have few questions (besides obvious typo in it):
> >
> > 0. Had it ever been tested?
> > 1. Is there *real* DSDT / registered ACPI IDs for a such device(s)?
> > 2. If "yes" on 1, can you provide Documentation with *real* DSDT
> > excerpt?
> >
> > If the answer is "no" on 2, I'm about to revert this, because
> > ACPI is *not* like Device Tree chaotic mess. Any ID, property and
> > related stuff *must* be officially registered and carefully chosen.
> >
> > To maintainers of the drivers, including but not limited to I2C
> > subsystem, please, Cc ACPI guys (Rafael, Mika, me, etc) *before*
> > applying any ACPI IDs if there no clear and *real* DSDT excerpt.
> >
> > It's disregard if this case (pca954x) valid or not.
> >
> > Thank you for understanding.
>
> Hi Andy,
>
> I have no idea if PCA9540 etc are valid DSDT entries. Going forward,
> I will Cc: ACPI people before taking ACPI patches. Sorry for the
> inconvenience and sorry for my ignorance.
Thank you, Peter.
> But before reverting, let's give Tin a chance to speak up...
Of course! That's why I wrote this message beforehand.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2017-03-21 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 16:04 i2c-mux-pca954x ACPI case Andy Shevchenko
2017-03-20 16:38 ` Peter Rosin
2017-03-21 12:18 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490098703.19767.120.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peda@axentia.se \
--cc=rafael.j.wysocki@intel.com \
--cc=tnhuynh@apm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.