From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] gpio: acpi: Call enable_irq_wake for _IAE GpioInts with Wake set
Date: Tue, 21 Mar 2017 14:40:14 +0200 [thread overview]
Message-ID: <1490100014.19767.126.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0jrq_AUysuLuyhUqWXOYm8X-koq8ra=rgrjUo+bFMyw9w@mail.gmail.com>
On Tue, 2017-03-21 at 13:36 +0100, Rafael J. Wysocki wrote:
> On Tue, Mar 21, 2017 at 1:30 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, 2017-03-20 at 18:32 +0100, Hans de Goede wrote:
> > > + bool irq_wake_enabled;
> > >
> > > + if (event->irq_wake_enabled)
> > >
> >
> > Same (new) comment as in v1.
>
> Why not just check for agpio->wake_capable == ACPI_WAKE_CAPABLE
> instead as I said?
Ah, yes, it could work as well as far as I can see from the code point
of view.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2017-03-21 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 17:32 [PATCH v2] gpio: acpi: Call enable_irq_wake for _IAE GpioInts with Wake set Hans de Goede
2017-03-20 21:59 ` Rafael J. Wysocki
2017-03-24 9:51 ` Hans de Goede
2017-03-24 15:16 ` Rafael J. Wysocki
2017-03-21 12:30 ` Andy Shevchenko
2017-03-21 12:36 ` Rafael J. Wysocki
2017-03-21 12:40 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490100014.19767.126.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.