All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Leblond <eric@regit.org>
To: Alexandru Ardelean <ardeleanalex@gmail.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] ulogd: add +1 char for null char
Date: Tue, 21 Mar 2017 21:54:53 +0100	[thread overview]
Message-ID: <1490129693.2157.21.camel@regit.org> (raw)
In-Reply-To: <1489998667-15183-1-git-send-email-ardeleanalex@gmail.com>

Hello,

Thanks for the report and the patch. I'm not sure of your
implementation. Can you test with the patch to follow ?

On Mon, 2017-03-20 at 10:31 +0200, Alexandru Ardelean wrote:
> This is a bit zealous to fix like this, but it seems to work.
> 
> The crash was reproduced on ppc32, with GCC 5.4 & musl libc 1.1.16.
> 
> And also on LEDE (mips_24kc and ARM):
> https://github.com/openwrt/packages/issues/4123
> https://github.com/openwrt/packages/issues/4090
> 
> I personally saw it on ppc32.
> The offending code was in `pluginstance_alloc_init()` line 671:
> ```
> memcpy(pi->id, pi_id, sizeof(pi->id));
> ```

Thanks in advance,
-- 
Eric Leblond <eric@regit.org>

  reply	other threads:[~2017-03-21 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20  8:31 [PATCH] ulogd: add +1 char for null char Alexandru Ardelean
2017-03-21 20:54 ` Eric Leblond [this message]
2017-03-21 20:56   ` [PATCH] ulogd: use strncpy instead of memcpy Eric Leblond
2017-03-22  7:07   ` [PATCH] ulogd: add +1 char for null char Alexandru Ardelean
2017-03-22 15:56     ` Alexandru Ardelean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490129693.2157.21.camel@regit.org \
    --to=eric@regit.org \
    --cc=ardeleanalex@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.