From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] subversion: remove useless comment
Date: Tue, 21 Mar 2017 15:15:41 -0600 [thread overview]
Message-ID: <1490130941.28281.19.camel@linux.intel.com> (raw)
In-Reply-To: <1490129564.13980.160.camel@linuxfoundation.org>
On Tue, 2017-03-21 at 20:52 +0000, Richard Purdie wrote:
> On Tue, 2017-03-14 at 09:37 +0000,
> leonardo.sandoval.gonzalez@linux.intel.com wrote:
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> >
> > Remove auto-builder comment shown on the recipe because it does not
> > add something
> > useful.
>
> I disagree, it explains the error seen which caused parallel make
> install to be disabled in the first place. I suggest wrapping the
> comment rather than branding it "useless". You could also replace out
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp" with TMPDIR.
>
With your explanation, it makes sense but in the recipe is just the log,
nothing more. Yes, pathnames should be shorter, so we do not have a line
with almost 500 chars.
Leo
> All too often we see things like parallel make disabled with no idea
> why.
>
> Cheers,
>
> Richard
>
> >
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.in
> > tel.com>
> > ---
> > meta/recipes-devtools/subversion/subversion_1.9.5.bb | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > index 05fba67..5871b84 100644
> > --- a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > +++ b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > @@ -47,9 +47,4 @@ do_configure_prepend () {
> > sed -i -e
> > 's:with_sasl="/usr/local":with_sasl="${STAGING_DIR}":' ${S}/build/ac-
> > macros/sasl.m4
> > }
> >
> > -#| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-
> > autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/subversion/libsvn_ra_local/libsvn_ra_local-1.la' has not
> > been installed in `/home/pokybuild/yocto-autobuilder/yocto-
> > worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-
> > linux/usr/lib'| x86_64-linux-libtool: install: warning:
> > `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/subversion/libsvn_repos/libsvn_repos-1.la' has not been
> > installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> > qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'|
> > /usr/bin/ld: cannot find -lsvn_delta-1| collect2: ld returned 1 exit
> > status| x86_64-linux-libtool: install: warning:
> > `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/sub
> > version/libsvn_ra_svn/libsvn_ra_svn-1.la' has not been installed in
> > `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'| x86_64-
> > linux-libtool: install: warning: `/home/pokybuild/yocto-
> > autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/subversion/libsvn_ra_serf/libsvn_ra_serf-1.la' has not been
> > installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> > qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
> > -#| x86_64-linux-libtool: install: error: relink `libsvn_ra_serf-
> > 1.la' with the above command before installing it
> > -#| x86_64-linux-libtool: install: warning:
> > `../../subversion/libsvn_repos/libsvn_repos-1.la' has not been
> > installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> > qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
> > -#| /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/subversion-1.8.9/build-outputs.mk:1090: recipe for target
> > 'install-serf-lib' failed
> > -#| make: *** [install-serf-lib] Error 1
> > PARALLEL_MAKEINST = ""
> > --
> > 2.10.2
> >
prev parent reply other threads:[~2017-03-21 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 9:37 [PATCH 1/3] subversion: remove useless comment leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 2/3] uninative.bbclass: split long command leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 3/3] gettext: split recipe's description leonardo.sandoval.gonzalez
2017-03-21 20:52 ` [PATCH 1/3] subversion: remove useless comment Richard Purdie
2017-03-21 21:15 ` Leonardo Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490130941.28281.19.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.