All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janne Huttunen <janne.huttunen@nokia.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Cc: "kraxel@redhat.com" <kraxel@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property
Date: Wed, 22 Mar 2017 17:19:20 +0200	[thread overview]
Message-ID: <1490195960.19055.105.camel@nokia.com> (raw)
In-Reply-To: <8616b7ec-8306-25b4-267c-449f94261502@redhat.com>

On Wed, 2017-03-22 at 15:36 +0100, Laszlo Ersek wrote:
> 
> To my knowledge, currently the bootindex properties cannot be changed
> dynamically (for example with monitor commands) after they have been
> specified on the QEMU command line.

Yes they can, via QMP:

{'execute': 'qom-get', 'arguments': { 'path': 'scsi0.0/child[0]',
'property': 'bootindex' }}
{"return": 10}

{'execute': 'qom-set', 'arguments': { 'path': 'scsi0.0/child[0]',
'property': 'bootindex', 'value': 11 }}
{"return": {}}

{'execute': 'qom-get', 'arguments': { 'path': 'scsi0.0/child[0]',
'property': 'bootindex' }}
{"return": 11}


I have no idea if doing so breaks something, like e.g.
migration, but it definitely can be done.

> And, even if some settings can be changed, the question is what agent
> changes them. If the management layer (libvirt etc) changes them
> using
> monitor commands, then libvirt itself can keep track of that state,
> and
> then start the QEMU process on the destination  host with a suitably
> modified command line.
> 
> Whereas, if it is the guest that changes device state, memory state
> etc,
> then those things have to be part of the migration stream.

True.

> > If it
> > is, migrating the "bootonceindex" values the same way should
> > be sufficient, no?
> To my knowledge, "bootindex" properties are not migrated now, and
> they
> also need not to, because they never change at runtime.

Like demonstrated above, they can change, but of course
there might be an assumption that they won't change
"unexpectedly".

> If the second system sets a temporary boot order for the first system
> "every now and then", which I guess entails on-demand talking to the
> first system's management processor, then how can you replace that
> with
> a static QEMU command line (with the proposed bootonceindex
> property)?

I'm not. I'm using QMP to change the index dynamically.

> I'm not saying that the use case is without merit. My point is that
> this
> new property would introduce obscure interactions with other
> components
> in the virt stack around QEMU, and it could have a significant
> maintenance footprint, while the feature does look niche (to me
> anyway).

Maybe, and it is definitely good to analyze it. Like I
already admitted, I did not think about migration at all
and there may very well have been other things I have
overlooked too.

  reply	other threads:[~2017-03-22 19:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 12:50 [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property Janne Huttunen
2017-03-14 12:50 ` [Qemu-devel] [RFC][PATCH 1/6] Re-factor bootdevice list handling, pt1 Janne Huttunen
2017-03-14 12:50 ` [Qemu-devel] [RFC][PATCH 2/6] Re-factor bootdevice list handling, pt2 Janne Huttunen
2017-03-14 12:50 ` [Qemu-devel] [RFC][PATCH 3/6] Add support for "bootonceindex" property Janne Huttunen
2017-03-14 12:50 ` [Qemu-devel] [RFC][PATCH 4/6] Clear the boot once list after it has been used Janne Huttunen
2017-03-14 12:50 ` [Qemu-devel] [RFC][PATCH 5/6] Support "bootonceindex" property for virtio-net interfaces Janne Huttunen
2017-03-14 12:50 ` [Qemu-devel] [RFC][PATCH 6/6] Support "bootonceindex" property for SCSI disks Janne Huttunen
2017-03-14 16:57 ` [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property Gerd Hoffmann
2017-03-15  6:58   ` Janne Huttunen
2017-03-15  7:24     ` Gerd Hoffmann
2017-03-16  9:46       ` Janne Huttunen
2017-03-16  9:59         ` Gerd Hoffmann
2017-03-21 17:48         ` Eric Blake
2017-03-22  5:42           ` Markus Armbruster
2017-03-21 17:55     ` Paolo Bonzini
2017-03-22  6:36       ` Janne Huttunen
2017-03-22  8:43         ` Paolo Bonzini
2017-03-22  9:00           ` Huttunen, Janne (Nokia - FI/Espoo)
2017-03-22 10:51             ` Laszlo Ersek
2017-03-22 13:58               ` Janne Huttunen
2017-03-22 14:36                 ` Laszlo Ersek
2017-03-22 15:19                   ` Janne Huttunen [this message]
2017-03-22 15:29                     ` Laszlo Ersek
2017-03-23  6:53                       ` Janne Huttunen
2017-03-23  9:13                         ` Laszlo Ersek
     [not found]   ` <CACaajQsrkuZeC6WYXdEBJY=FEkTQ9iY_i8E-d5j7JqK5DDUuOw@mail.gmail.com>
2017-03-15  7:21     ` Vasiliy Tolstov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490195960.19055.105.camel@nokia.com \
    --to=janne.huttunen@nokia.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.