Re: [PATCH] libxslt: Add PACKAGECONFIG support

["Patel, Vedang" <vedang.patel@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2847 bytes --]

Hi Jussi,

On Tue, 2017-03-21 at 08:36 +0000, Kukkonen, Jussi wrote:
On 21 March 2017 at 02:31, Vedang Patel <vedang.patel@intel.com<mailto:vedang.patel@intel.com>> wrote:
Some options like python bindings, debug support, crypto are hardcoded
inside the recipe. Change that to make those option configurable using
PACKAGECONFIG.

Signed-off-by: Vedang Patel <vedang.patel@intel.com<mailto:vedang.patel@intel.com>>
---
 meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb> | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb> b/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
index be747e608d9d..d362118aa307 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
+++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb<http://libxslt_1.1.29.bb>
@@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"

 BINCONFIG = "${bindir}/xslt-config"

-inherit autotools pkgconfig binconfig-disabled lib_package
+inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base

 # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
 do_configure_prepend () {
@@ -33,7 +33,12 @@ do_configure_prepend () {
        touch ${S}/doc/xsltproc.1
 }

-EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
+PACKAGECONFIG ??= "python libxslt-debug libxslt-mem-debug libxslt-crypto"


You change all the defaults, is this on purpose? It should be noted in the commit message in any case.

Can you elabore on your concern? I am not exactly following it.

the configs won't be enabled unless the corresponding features are explicitly enabled in the image. I am using libxslt- prefix to make sure someone does not inadvertently enables the features by using the generic flags (python, debug, ... ).

I do see a bug here, In the first line, python should be replaced with libxslt-python. I will fix it in the next version of this patch.

Thanks,
Vedang Patel
Software Engineer
Intel Corporation

+PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
+PACKAGECONFIG[libxslt-debug] = "--with-debug, --without-debug"
+PACKAGECONFIG[libxslt-mem-debug] = "--with-mem-debug, --without-mem-debug"
+PACKAGECONFIG[libxslt-crypto] = "--with-crypto, --without-crypto"
+
 # older versions of this recipe had ${PN}-utils
 RPROVIDES_${PN}-bin += "${PN}-utils"
 RCONFLICTS_${PN}-bin += "${PN}-utils"
--
2.7.3

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-core



[-- Attachment #2: Type: text/html, Size: 4558 bytes --]