From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cqzP2-0007XR-Oj for mharc-qemu-trivial@gnu.org; Thu, 23 Mar 2017 05:51:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqzP1-0007WZ-2D for qemu-trivial@nongnu.org; Thu, 23 Mar 2017 05:51:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqzP0-00080j-G2 for qemu-trivial@nongnu.org; Thu, 23 Mar 2017 05:51:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cqzOu-0007w1-Bv; Thu, 23 Mar 2017 05:51:24 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9E2483F45; Thu, 23 Mar 2017 09:51:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E9E2483F45 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E9E2483F45 Received: from nilsson.home.kraxel.org (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DE1E5DD71; Thu, 23 Mar 2017 09:51:23 +0000 (UTC) Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id E99A480CB2; Thu, 23 Mar 2017 10:51:20 +0100 (CET) Message-ID: <1490262680.463.27.camel@redhat.com> From: Gerd Hoffmann To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau Cc: Markus Armbruster , Michael Roth , Peter Crosthwaite , qemu-trivial@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Date: Thu, 23 Mar 2017 10:51:20 +0100 In-Reply-To: References: <20170322204844.446-1-f4bug@amsat.org> <20170322204844.446-2-f4bug@amsat.org> <87y3vw1o94.fsf@dusky.pond.sub.org> <1490255007.463.11.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 23 Mar 2017 09:51:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 09:51:31 -0000 Hi, > oops, there are hard-coded calls with NULL/0. I suppose to fix clang > warning, it would need to check if data !=3D null for memcpy. I'd check for len > 0, and in that if branch we can also assert on data =3D=3D NULL and thereby check that len and data are consistent. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqzOz-0007WT-E7 for qemu-devel@nongnu.org; Thu, 23 Mar 2017 05:51:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqzOu-0007wd-I0 for qemu-devel@nongnu.org; Thu, 23 Mar 2017 05:51:29 -0400 Message-ID: <1490262680.463.27.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 23 Mar 2017 10:51:20 +0100 In-Reply-To: References: <20170322204844.446-1-f4bug@amsat.org> <20170322204844.446-2-f4bug@amsat.org> <87y3vw1o94.fsf@dusky.pond.sub.org> <1490255007.463.11.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau Cc: Markus Armbruster , Michael Roth , Peter Crosthwaite , qemu-trivial@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Hi, > oops, there are hard-coded calls with NULL/0. I suppose to fix clang > warning, it would need to check if data !=3D null for memcpy. I'd check for len > 0, and in that if branch we can also assert on data =3D=3D NULL and thereby check that len and data are consistent. cheers, Gerd