From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755281AbdCWNOL (ORCPT ); Thu, 23 Mar 2017 09:14:11 -0400 Received: from mga04.intel.com ([192.55.52.120]:62154 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440AbdCWNOK (ORCPT ); Thu, 23 Mar 2017 09:14:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,210,1486454400"; d="scan'208";a="947416614" Message-ID: <1490274576.19767.189.camel@linux.intel.com> Subject: Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE From: Andy Shevchenko To: Lee Jones Cc: linux-kernel@vger.kernel.org Date: Thu, 23 Mar 2017 15:09:36 +0200 In-Reply-To: <20170323112157.lroxixbzfrkj45ch@dell> References: <20170316141959.16018-1-andriy.shevchenko@linux.intel.com> <20170323112157.lroxixbzfrkj45ch@dell> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-23 at 11:21 +0000, Lee Jones wrote: > On Thu, 16 Mar 2017, Andy Shevchenko wrote: > > > There is a potential flaw if cell has id > 0 and is going to be > > registered with PLATFORM_DEVID_NONE. > > > > Ignore if PLATFORM_DEVID_NONE is supplied. > > This is a substantial change to a pretty tried and tested piece of > sub-system code.  Can you put some more meat on the bones in the > commit log, and include examples. Example in pseudo code: cells = { [0] = { .id = 0, .name = "moduleX", }, [1] = { .id = 1, .name = "moduleY", }, [2] = { .id = 2, .name = "moduleZ", }, ... }; mfd_add_devices(..., PLATFORM_DEVID_NONE, cells, ARRAY_SIZE(cells), ...); Output (names of the devices in the drivers): "moduleX" "moduleY.0" "moduleX.1" Desired output: "moduleX" "moduleY" "moduleZ" Is it by design? > > > Signed-off-by: Andy Shevchenko > > --- > >  drivers/mfd/mfd-core.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > index c57e407020f1..c9583f895058 100644 > > --- a/drivers/mfd/mfd-core.c > > +++ b/drivers/mfd/mfd-core.c > > @@ -149,7 +149,7 @@ static int mfd_add_device(struct device *parent, > > int id, > >   int platform_id; > >   int r; > >   > > - if (id == PLATFORM_DEVID_AUTO) > > + if (id < 0) > >   platform_id = id; > >   else > >   platform_id = id + cell->id; > > -- Andy Shevchenko Intel Finland Oy