From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1] NFC: Add nfc_dbg() macro
Date: Sun, 26 Mar 2017 15:37:01 +0300 [thread overview]
Message-ID: <1490531821.708.7.camel@linux.intel.com> (raw)
In-Reply-To: <20170322192251.30261-1-andriy.shevchenko@linux.intel.com>
On Wed, 2017-03-22 at 21:22 +0200, Andy Shevchenko wrote:
> In some cases nfc_dbg() is useful. Add such macro to a header.
>
I think we may drop this, since the idea is to get rid of such macros
(as I read back in 2011 in commit message of change that removed
nfc_dbg() one).
I will re-do dependent series to not use it at all.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/net/nfc/nfc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h
> index 1a3de8b34ad2..bbdc73a3239d 100644
> --- a/include/net/nfc/nfc.h
> +++ b/include/net/nfc/nfc.h
> @@ -27,6 +27,7 @@
> #include <linux/device.h>
> #include <linux/skbuff.h>
>
> +#define nfc_dbg(dev, fmt, ...) dev_dbg((dev), "NFC: " fmt,
> ##__VA_ARGS__)
> #define nfc_info(dev, fmt, ...) dev_info((dev), "NFC: " fmt,
> ##__VA_ARGS__)
> #define nfc_err(dev, fmt, ...) dev_err((dev), "NFC: " fmt,
> ##__VA_ARGS__)
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-03-26 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 19:22 [PATCH v1] NFC: Add nfc_dbg() macro Andy Shevchenko
2017-03-22 19:22 ` Andy Shevchenko
2017-03-26 12:37 ` Andy Shevchenko [this message]
2017-04-05 8:16 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490531821.708.7.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=davem@davemloft.net \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.