From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Diana Thayer <garbados@gmail.com>, bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bug 9962: improve -v, -D documentation
Date: Mon, 27 Mar 2017 11:14:54 +0100 [thread overview]
Message-ID: <1490609694.13980.255.camel@linuxfoundation.org> (raw)
In-Reply-To: <CA++8a_CFVb+=mHSH5x45Fg==D5pG-Ja=OiAiNpd2H4gvD3zSjA@mail.gmail.com>
On Tue, 2017-03-21 at 13:33 -0700, Diana Thayer wrote:
> Hi!
>
> I did my best to follow patch submission guidelines and code
> styleguide but this is my very first patch to anything in the Yocto
> project. Please let me know if and how I can improve future patch
> submissions! I figured since it's my first time, I would follow up
> and say hello :)
>
> This patch addresses bug 9962 by updating the documentation of
> bitbake's -v and -D CLI options. I copied the updated text directly
> from the bug report, and changed it both in the code and in the user
> manual.
>
> Anyway hi! I hope to contribute more soon :)
Hi!
Thanks for taking the time to submit the patch and sorry for the delay
in getting back to you. I've just queued this in master-next for
further testing. The patch itself is great, I did have to tweak the
commit message a bit. In particular:
I added "main: " as a prefix to the shortlog since this indicates there
the change was made. I also changed the bug reference to our standard
form [YOCTO #XXXX] so that when we search commits for bug references,
its in a standard form. The commit message needs to stand alone without
someone needing to read the bug, that is there just as a useful link
for more information. All just minor formatting tweaks really though.
Cheers,
Richard
next prev parent reply other threads:[~2017-03-27 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 20:27 [PATCH] bug 9962: improve -v, -D documentation Diana Thayer
2017-03-21 20:33 ` Diana Thayer
2017-03-27 10:14 ` Richard Purdie [this message]
2017-03-27 17:07 ` Leonardo Sandoval
2017-03-30 10:11 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490609694.13980.255.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=garbados@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.