* [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence
@ 2017-03-23 8:57 Chris Wilson
2017-03-23 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2017-03-23 8:57 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
Ensure that before we overwrite the reservation_object with our
exclusive fence for the pending clflush operation, that we do wait upon
all the fences in the current reservation_object.
Fixes: 57822dc6b9cf ("drm/i915: Perform object clflushing asynchronously")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem_clflush.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_clflush.c b/drivers/gpu/drm/i915/i915_gem_clflush.c
index d925fb582ba7..ffd01e02fe94 100644
--- a/drivers/gpu/drm/i915/i915_gem_clflush.c
+++ b/drivers/gpu/drm/i915/i915_gem_clflush.c
@@ -168,7 +168,7 @@ void i915_gem_clflush_object(struct drm_i915_gem_object *obj,
i915_sw_fence_await_reservation(&clflush->wait,
obj->resv, NULL,
- false, I915_FENCE_TIMEOUT,
+ true, I915_FENCE_TIMEOUT,
GFP_KERNEL);
reservation_object_lock(obj->resv, NULL);
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Wait for all fences before installing an exclusive clflush fence
2017-03-23 8:57 [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence Chris Wilson
@ 2017-03-23 11:39 ` Patchwork
2017-03-23 11:55 ` [PATCH] " Mika Kuoppala
2017-03-27 10:25 ` Joonas Lahtinen
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-03-23 11:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Wait for all fences before installing an exclusive clflush fence
URL : https://patchwork.freedesktop.org/series/21746/
State : success
== Summary ==
Series 21746v1 drm/i915: Wait for all fences before installing an exclusive clflush fence
https://patchwork.freedesktop.org/api/1.0/series/21746/revisions/1/mbox/
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 462s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time: 452s
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 581s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 537s
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 511s
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 502s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 440s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 435s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 443s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 516s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 503s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 483s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 495s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 601s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 490s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 529s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time: 463s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 549s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 417s
8229a8c712c22ff8e94e3244d4fd942a7dcd89af drm-tip: 2017y-03m-23d-09h-57m-34s UTC integration manifest
33a1f7d drm/i915: Wait for all fences before installing an exclusive clflush fence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4275/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence
2017-03-23 8:57 [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence Chris Wilson
2017-03-23 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-03-23 11:55 ` Mika Kuoppala
2017-03-23 12:08 ` Chris Wilson
2017-03-27 10:25 ` Joonas Lahtinen
2 siblings, 1 reply; 5+ messages in thread
From: Mika Kuoppala @ 2017-03-23 11:55 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Matthew Auld
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Ensure that before we overwrite the reservation_object with our
> exclusive fence for the pending clflush operation, that we do wait upon
> all the fences in the current reservation_object.
>
> Fixes: 57822dc6b9cf ("drm/i915: Perform object clflushing asynchronously")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_clflush.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_clflush.c b/drivers/gpu/drm/i915/i915_gem_clflush.c
> index d925fb582ba7..ffd01e02fe94 100644
> --- a/drivers/gpu/drm/i915/i915_gem_clflush.c
> +++ b/drivers/gpu/drm/i915/i915_gem_clflush.c
> @@ -168,7 +168,7 @@ void i915_gem_clflush_object(struct drm_i915_gem_object *obj,
>
> i915_sw_fence_await_reservation(&clflush->wait,
> obj->resv, NULL,
> - false, I915_FENCE_TIMEOUT,
> + true, I915_FENCE_TIMEOUT,
> GFP_KERNEL);
>
> reservation_object_lock(obj->resv, NULL);
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence
2017-03-23 11:55 ` [PATCH] " Mika Kuoppala
@ 2017-03-23 12:08 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-03-23 12:08 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx, Matthew Auld
On Thu, Mar 23, 2017 at 01:55:33PM +0200, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Ensure that before we overwrite the reservation_object with our
> > exclusive fence for the pending clflush operation, that we do wait upon
> > all the fences in the current reservation_object.
> >
> > Fixes: 57822dc6b9cf ("drm/i915: Perform object clflushing asynchronously")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Thanks, I realised my mistake when doing async page loading. Now you've
read this patch, you should be ready for those...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence
2017-03-23 8:57 [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence Chris Wilson
2017-03-23 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-23 11:55 ` [PATCH] " Mika Kuoppala
@ 2017-03-27 10:25 ` Joonas Lahtinen
2 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-03-27 10:25 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Matthew Auld
On to, 2017-03-23 at 08:57 +0000, Chris Wilson wrote:
> Ensure that before we overwrite the reservation_object with our
> exclusive fence for the pending clflush operation, that we do wait upon
> all the fences in the current reservation_object.
>
> Fixes: 57822dc6b9cf ("drm/i915: Perform object clflushing asynchronously")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
Comment might not hurt.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-27 10:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 8:57 [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence Chris Wilson
2017-03-23 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-23 11:55 ` [PATCH] " Mika Kuoppala
2017-03-23 12:08 ` Chris Wilson
2017-03-27 10:25 ` Joonas Lahtinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.