From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: Check we have an wake device before flushing GTT writes Date: Mon, 27 Mar 2017 13:29:18 +0300 Message-ID: <1490610558.3166.15.camel@linux.intel.com> References: <20170308124057.6512-1-chris@chris-wilson.co.uk> <20170323150053.28582-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DDC66E1AB for ; Mon, 27 Mar 2017 10:29:21 +0000 (UTC) In-Reply-To: <20170323150053.28582-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: "# v4 . 9" List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTctMDMtMjMgYXQgMTU6MDAgKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBX ZSBjYW4gYXNzdW1lIHRoYXQgaWYgdGhlIGRldmljZSBpcyBhc2xlZXAgdGhlbiBhbGwgcGVuZGlu ZyBHVFQgd3JpdGVzCj4gd2lsbCBoYXZlIGJlZW4gcG9zdGVkLCBhbmQgc28gd2UgY2FuIGRlZmVy IHRoZSBmbHVzaCBmcm9tCj4gaTkxNV9nZW1fb2JqZWN0X2ZsdXNoX2d0dF93cml0ZV9kb21haW4o KQo+IAo+IFsgMTk1Ny40NjI1NjhdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDYxMzIgYXQgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2Lmg6MTc0MiBmd3RhYmxlX3JlYWQzMisweDEyMy8weDE1 MCBbaTkxNV0KPiBbIDE5NTcuNDYyNTgyXSBSUE0gd2FrZWxvY2sgcmVmIG5vdCBoZWxkIGR1cmlu ZyBIVyBhY2Nlc3MKPiBbIDE5NTcuNDYyNTgzXSBNb2R1bGVzIGxpbmtlZCBpbjogaTkxNSBpbnRl bF9ndHQgZHJtX2ttc19oZWxwZXIgcHJpbWVfbnVtYmVycwo+IFsgMTk1Ny40NjI2MDddIENQVTog MCBQSUQ6IDYxMzIgQ29tbTogZ2VtX2NvbmN1cnJlbnRfIFRhaW50ZWQ6IEfCoMKgwqDCoMKgVcKg wqDCoMKgwqDCoMKgwqDCoMKgNC4xMS4wLXJjMSsgIzQ2NAo+IFsgMTk1Ny40NjI2MTldIEhhcmR3 YXJlIG5hbWU6wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgL8KgwqDCoMKgwqDC oMKgwqAsIEJJT1MgUFlCU1dDRUwuODZBLjAwMjcuMjAxNS4wNTA3LjE3NTggMDUvMDcvMjAxNQo+ IFsgMTk1Ny40NjI2MzBdIENhbGwgVHJhY2U6Cj4gWyAxOTU3LjQ2MjY0Nl3CoMKgZHVtcF9zdGFj aysweDRkLzB4NmYKPiBbIDE5NTcuNDYyNjU3XcKgwqBfX3dhcm4rMHhjMS8weGUwCj4gWyAxOTU3 LjQ2MjY2N13CoMKgd2Fybl9zbG93cGF0aF9mbXQrMHg0YS8weDUwCj4gWyAxOTU3LjQ2MjcwOV3C oMKgZnd0YWJsZV9yZWFkMzIrMHgxMjMvMHgxNTAgW2k5MTVdCj4gWyAxOTU3LjQ2Mjc1MF3CoMKg aTkxNV9nZW1fb2JqZWN0X2ZsdXNoX2d0dF93cml0ZV9kb21haW4rMHg0My8weDcwIFtpOTE1XQo+ IFsgMTk1Ny40NjI3OTFdwqDCoGk5MTVfZ2VtX29iamVjdF9zZXRfdG9fY3B1X2RvbWFpbisweDQ2 LzB4YTAgW2k5MTVdCj4gWyAxOTU3LjQ2MjgzMV3CoMKgaTkxNV9nZW1fc2V0X2RvbWFpbl9pb2N0 bCsweDE1ZC8weDIyMCBbaTkxNV0KPiBbIDE5NTcuNDYyODQzXcKgwqBkcm1faW9jdGwrMHgxZDcv MHg0NDAKPiBbIDE5NTcuNDYyODg1XcKgwqA/IGk5MTVfZ2VtX29ial9wcmVwYXJlX3NobWVtX3dy aXRlKzB4MWQwLzB4MWQwIFtpOTE1XQo+IFsgMTk1Ny40NjI4OTZdwqDCoD8gcGlja19uZXh0X3Rh c2tfZmFpcisweDQzNi8weDQ0MAo+IFsgMTk1Ny40NjI5MDZdwqDCoD8gbW50cHV0KzB4MWYvMHgz MAo+IFsgMTk1Ny40NjI5MTVdwqDCoGRvX3Zmc19pb2N0bCsweDhmLzB4NWMwCj4gWyAxOTU3LjQ2 MjkyNV3CoMKgPyBfX3NjaGVkdWxlKzB4MTZmLzB4NWYwCj4gWyAxOTU3LjQ2MjkzNV3CoMKgPyBf X19fZnB1dCsweDkvMHgxMAo+IFsgMTk1Ny40NjI5NDNdwqDCoFN5U19pb2N0bCsweDNjLzB4NzAK PiBbIDE5NTcuNDYyOTUyXcKgwqBlbnRyeV9TWVNDQUxMXzY0X2Zhc3RwYXRoKzB4MTcvMHg5OAo+ IFsgMTk1Ny40NjI5NjFdIFJJUDogMDAzMzoweDdmYzU0MjE3OWNhNwo+IFsgMTk1Ny40NjI5Njhd IFJTUDogMDAyYjowMDAwN2ZmZWVmMTJmZjk4IEVGTEFHUzogMDAwMDAyNDYgT1JJR19SQVg6IDAw MDAwMDAwMDAwMDAwMTAKPiBbIDE5NTcuNDYyOTgyXSBSQVg6IGZmZmZmZmZmZmZmZmZmZGEgUkJY OiAwMDAwN2ZmZWVmMTMwMWQwIFJDWDogMDAwMDdmYzU0MjE3OWNhNwo+IFsgMTk1Ny40NjI5OTBd IFJEWDogMDAwMDdmZmVlZjEyZmZkMCBSU0k6IDAwMDAwMDAwNDAwYzY0NWYgUkRJOiAwMDAwMDAw MDAwMDAwMDAzCj4gWyAxOTU3LjQ2Mjk5OV0gUkJQOiAwMDAwMDAwMDAwMDAwMDAzIFIwODogMDAw MDU1ZjQzM2JjN2M0MCBSMDk6IDAwMDAwMDAwMDAwMDAwMmMKPiBbIDE5NTcuNDYzMDA2XSBSMTA6 IDAwMDAwMDAwMDAwMDAwNzMgUjExOiAwMDAwMDAwMDAwMDAwMjQ2IFIxMjogMDAwMDAwMDAwMDAw MDAxOAo+IFsgMTk1Ny40NjMwMTVdIFIxMzogMDAwMDU1ZjQzMmM4OWQyMCBSMTQ6IDAwMDA1NWY0 MzJjODc2OTAgUjE1OiAwMDAwMDAwMDAwMDAwMDAwCj4gCj4gRml4ZXM6IDNiNTcyNGQ3MDJlZiAo ImRybS9pOTE1OiBXYWl0IGZvciB3cml0ZXMgdGhyb3VnaCB0aGUgR1RUIHRvIGxhbmQgYmVmb3Jl IHJlYWRpbmcgYmFjayIpCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxp bnV4LmludGVsLmNvbT4KPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuOQoKUmV2 aWV3ZWQtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNv bT4KClJlZ2FyZHMsIEpvb25hcwotLSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:48644 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbdC0KaG (ORCPT ); Mon, 27 Mar 2017 06:30:06 -0400 Message-ID: <1490610558.3166.15.camel@linux.intel.com> Subject: Re: [PATCH] drm/i915: Check we have an wake device before flushing GTT writes From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: "# v4 . 9" Date: Mon, 27 Mar 2017 13:29:18 +0300 In-Reply-To: <20170323150053.28582-1-chris@chris-wilson.co.uk> References: <20170308124057.6512-1-chris@chris-wilson.co.uk> <20170323150053.28582-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On to, 2017-03-23 at 15:00 +0000, Chris Wilson wrote: > We can assume that if the device is asleep then all pending GTT writes > will have been posted, and so we can defer the flush from > i915_gem_object_flush_gtt_write_domain() > > [ 1957.462568] WARNING: CPU: 0 PID: 6132 at drivers/gpu/drm/i915/intel_drv.h:1742 fwtable_read32+0x123/0x150 [i915] > [ 1957.462582] RPM wakelock ref not held during HW access > [ 1957.462583] Modules linked in: i915 intel_gtt drm_kms_helper prime_numbers > [ 1957.462607] CPU: 0 PID: 6132 Comm: gem_concurrent_ Tainted: G     U          4.11.0-rc1+ #464 > [ 1957.462619] Hardware name:                  /        , BIOS PYBSWCEL.86A.0027.2015.0507.1758 05/07/2015 > [ 1957.462630] Call Trace: > [ 1957.462646]  dump_stack+0x4d/0x6f > [ 1957.462657]  __warn+0xc1/0xe0 > [ 1957.462667]  warn_slowpath_fmt+0x4a/0x50 > [ 1957.462709]  fwtable_read32+0x123/0x150 [i915] > [ 1957.462750]  i915_gem_object_flush_gtt_write_domain+0x43/0x70 [i915] > [ 1957.462791]  i915_gem_object_set_to_cpu_domain+0x46/0xa0 [i915] > [ 1957.462831]  i915_gem_set_domain_ioctl+0x15d/0x220 [i915] > [ 1957.462843]  drm_ioctl+0x1d7/0x440 > [ 1957.462885]  ? i915_gem_obj_prepare_shmem_write+0x1d0/0x1d0 [i915] > [ 1957.462896]  ? pick_next_task_fair+0x436/0x440 > [ 1957.462906]  ? mntput+0x1f/0x30 > [ 1957.462915]  do_vfs_ioctl+0x8f/0x5c0 > [ 1957.462925]  ? __schedule+0x16f/0x5f0 > [ 1957.462935]  ? ____fput+0x9/0x10 > [ 1957.462943]  SyS_ioctl+0x3c/0x70 > [ 1957.462952]  entry_SYSCALL_64_fastpath+0x17/0x98 > [ 1957.462961] RIP: 0033:0x7fc542179ca7 > [ 1957.462968] RSP: 002b:00007ffeef12ff98 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > [ 1957.462982] RAX: ffffffffffffffda RBX: 00007ffeef1301d0 RCX: 00007fc542179ca7 > [ 1957.462990] RDX: 00007ffeef12ffd0 RSI: 00000000400c645f RDI: 0000000000000003 > [ 1957.462999] RBP: 0000000000000003 R08: 000055f433bc7c40 R09: 000000000000002c > [ 1957.463006] R10: 0000000000000073 R11: 0000000000000246 R12: 0000000000000018 > [ 1957.463015] R13: 000055f432c89d20 R14: 000055f432c87690 R15: 0000000000000000 > > Fixes: 3b5724d702ef ("drm/i915: Wait for writes through the GTT to land before reading back") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: # v4.9 Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation