Re: [PATCH v4] drm/i915/scheduler: add gvt notification for guc submission

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v4] drm/i915/scheduler: add gvt notification for guc submission
Date: Mon, 27 Mar 2017 14:43:32 +0300	[thread overview]
Message-ID: <1490615012.3166.19.camel@linux.intel.com> (raw)
In-Reply-To: <17296D9F8FF2234F831FC3DF505A87A96321BCCB@SHSMSX103.ccr.corp.intel.com>

On ma, 2017-03-27 at 10:58 +0000, Dong, Chuanxiao wrote:
> >
> > > @@ -634,6 +636,8 @@ static void i915_guc_irq_handler(unsigned long data)
> > > 
> > >  		rq = port[0].request;
> > >  		while (rq && i915_gem_request_completed(rq)) {
> > >  			trace_i915_gem_request_out(rq);
> > > +			intel_gvt_notify_context_status(rq,
> > > +					INTEL_CONTEXT_SCHEDULE_OUT);
> > 
> > Code indent is still broken.
> Hi Joonas, I am sorry for not getting this code indent issue. The
> above code is just split by typing an enter due to longer than 80
> characters. Are you expecting to see the code like below? The 2nd
> line will be longer than 80 characters in below case. If this is fine
> then I will change this in the next version.
> > 			intel_gvt_notify_context_status(rq,
> > 							INTEL_CONTEXT_SCHEDULE_OUT);
> 

My bad, I missed one tab.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx