All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: johan@kernel.org, david.vrabel@csr.com,
	gregkh@linuxfoundation.org, inaky.perez-gonzalez@intel.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "uwb: i1480-dfu: fix NULL-deref at probe" has been added to the 4.9-stable tree
Date: Mon, 27 Mar 2017 18:39:00 +0200	[thread overview]
Message-ID: <149063274079133@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    uwb: i1480-dfu: fix NULL-deref at probe

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     uwb-i1480-dfu-fix-null-deref-at-probe.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 4ce362711d78a4999011add3115b8f4b0bc25e8c Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 13 Mar 2017 13:47:53 +0100
Subject: uwb: i1480-dfu: fix NULL-deref at probe

From: Johan Hovold <johan@kernel.org>

commit 4ce362711d78a4999011add3115b8f4b0bc25e8c upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Note that the dereference happens in the cmd and wait_init_done
callbacks which are called during probe.

Fixes: 1ba47da52712 ("uwb: add the i1480 DFU driver")
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: David Vrabel <david.vrabel@csr.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/uwb/i1480/dfu/usb.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/uwb/i1480/dfu/usb.c
+++ b/drivers/uwb/i1480/dfu/usb.c
@@ -362,6 +362,9 @@ int i1480_usb_probe(struct usb_interface
 				 result);
 	}
 
+	if (iface->cur_altsetting->desc.bNumEndpoints < 1)
+		return -ENODEV;
+
 	result = -ENOMEM;
 	i1480_usb = kzalloc(sizeof(*i1480_usb), GFP_KERNEL);
 	if (i1480_usb == NULL) {


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.9/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch
queue-4.9/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-usbtmc-add-missing-endpoint-sanity-check.patch
queue-4.9/input-cm109-validate-number-of-endpoints-before-using-them.patch
queue-4.9/input-iforce-validate-number-of-endpoints-before-using-them.patch
queue-4.9/mmc-ushc-fix-null-deref-at-probe.patch
queue-4.9/input-kbtab-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-usbtmc-fix-probe-error-path.patch
queue-4.9/input-sur40-validate-number-of-endpoints-before-using-them.patch
queue-4.9/uwb-i1480-dfu-fix-null-deref-at-probe.patch
queue-4.9/input-hanwang-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-idmouse-fix-null-deref-at-probe.patch
queue-4.9/uwb-hwa-rc-fix-null-deref-at-probe.patch
queue-4.9/usb-lvtest-fix-null-deref-at-probe.patch
queue-4.9/input-yealink-validate-number-of-endpoints-before-using-them.patch
queue-4.9/usb-serial-qcserial-add-dell-dw5811e.patch
queue-4.9/usb-uss720-fix-null-deref-at-probe.patch
queue-4.9/usb-wusbcore-fix-null-deref-at-probe.patch

                 reply	other threads:[~2017-03-27 16:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=149063274079133@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=david.vrabel@csr.com \
    --cc=inaky.perez-gonzalez@intel.com \
    --cc=johan@kernel.org \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.