diff for duplicates of <1490719722.2573.8.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 0bfff1f..b2cbbad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,18 @@ On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote: > Try to use a write same with unmap bit variant if the device supports it > and the caller asks for it. -> -> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> +>=20 +> Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/scsi/sd.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) -> +>=20 > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index b6f70a09a301..ca96bb33471b 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c -> @@ -871,6 +871,16 @@ static int sd_setup_write_zeroes_cmnd(struct scsi_cmnd *cmd) +> @@ -871,6 +871,16 @@ static int sd_setup_write_zeroes_cmnd(struct scsi_cm= +nd *cmd) > return BLKPREP_INVALID; > return sd_setup_ata_trim_cmnd(cmd); > } @@ -29,8 +30,9 @@ On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote: > return BLKPREP_INVALID; > if (sdkp->ws16 || sector > 0xffffffff || nr_sectors > 0xffff) -Users can change the provisioning mode from user space from SD_LBP_WS16 into +Users can change the provisioning mode from user space from=A0SD_LBP_WS16 i= +nto SD_LBP_WS10 so I'm not sure it's safe to skip the (sdkp->ws16 || sector > 0xffffffff || nr_sectors > 0xffff) check if REQ_UNMAP is set. -Bart. +Bart.= diff --git a/a/content_digest b/N1/content_digest index c434024..4e7ab28 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,38 +1,38 @@ "ref\020170323143341.31549-1-hch@lst.de\0" "ref\020170323143341.31549-13-hch@lst.de\0" - "ref\020170323143341.31549-13-hch-jcswGhMUV9g@public.gmane.org\0" - "From\0Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>\0" + "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" "Subject\0Re: [PATCH 12/23] sd: handle REQ_UNMAP\0" "Date\0Tue, 28 Mar 2017 16:48:55 +0000\0" - "To\0agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>" - lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org <lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org> - snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - hch-jcswGhMUV9g@public.gmane.org <hch-jcswGhMUV9g@public.gmane.org> - martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org <martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> - philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org <philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org> - axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> - " shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" - "Cc\0linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" - linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org <dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org <drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org>\0" + "To\0agk@redhat.com <agk@redhat.com>" + lars.ellenberg@linbit.com <lars.ellenberg@linbit.com> + snitzer@redhat.com <snitzer@redhat.com> + hch@lst.de <hch@lst.de> + martin.petersen@oracle.com <martin.petersen@oracle.com> + philipp.reisner@linbit.com <philipp.reisner@linbit.com> + axboe@kernel.dk <axboe@kernel.dk> + " shli@kernel.org <shli@kernel.org>\0" + "Cc\0linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org>" + dm-devel@redhat.com <dm-devel@redhat.com> + drbd-dev@lists.linbit.com <drbd-dev@lists.linbit.com> + linux-block@vger.kernel.org <linux-block@vger.kernel.org> + " linux-raid@vger.kernel.org <linux-raid@vger.kernel.org>\0" "\00:1\0" "b\0" "On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote:\n" "> Try to use a write same with unmap bit variant if the device supports it\n" "> and the caller asks for it.\n" - "> \n" - "> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>\n" + ">=20\n" + "> Signed-off-by: Christoph Hellwig <hch@lst.de>\n" "> ---\n" "> drivers/scsi/sd.c | 10 ++++++++++\n" "> 1 file changed, 10 insertions(+)\n" - "> \n" + ">=20\n" "> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c\n" "> index b6f70a09a301..ca96bb33471b 100644\n" "> --- a/drivers/scsi/sd.c\n" "> +++ b/drivers/scsi/sd.c\n" - "> @@ -871,6 +871,16 @@ static int sd_setup_write_zeroes_cmnd(struct scsi_cmnd *cmd)\n" + "> @@ -871,6 +871,16 @@ static int sd_setup_write_zeroes_cmnd(struct scsi_cm=\n" + "nd *cmd)\n" "> \t\t\treturn BLKPREP_INVALID;\n" "> \t\treturn sd_setup_ata_trim_cmnd(cmd);\n" "> \t}\n" @@ -50,10 +50,11 @@ "> \t\treturn BLKPREP_INVALID;\n" "> \tif (sdkp->ws16 || sector > 0xffffffff || nr_sectors > 0xffff)\n" "\n" - "Users can change the provisioning mode from user space from\302\240SD_LBP_WS16 into\n" + "Users can change the provisioning mode from user space from=A0SD_LBP_WS16 i=\n" + "nto\n" "SD_LBP_WS10 so I'm not sure it's safe to skip the (sdkp->ws16 || sector >\n" "0xffffffff || nr_sectors > 0xffff) check if REQ_UNMAP is set.\n" "\n" - Bart. + Bart.= -e94881da2d7b67459d53a0cf3d826adbee98a0e70c50f97a011a3a7d39075732 +e8cc4032f301982860aeb66c24fd5450a527ff91764d919b0dc897379f499156
diff --git a/a/1.txt b/N2/1.txt index 0bfff1f..811d6a5 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote: > Try to use a write same with unmap bit variant if the device supports it > and the caller asks for it. > -> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> +> Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/scsi/sd.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) diff --git a/a/content_digest b/N2/content_digest index c434024..745dd9d 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,29 +1,28 @@ "ref\020170323143341.31549-1-hch@lst.de\0" "ref\020170323143341.31549-13-hch@lst.de\0" - "ref\020170323143341.31549-13-hch-jcswGhMUV9g@public.gmane.org\0" - "From\0Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>\0" - "Subject\0Re: [PATCH 12/23] sd: handle REQ_UNMAP\0" + "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" + "Subject\0Re: [Drbd-dev] [PATCH 12/23] sd: handle REQ_UNMAP\0" "Date\0Tue, 28 Mar 2017 16:48:55 +0000\0" - "To\0agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>" - lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org <lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org> - snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - hch-jcswGhMUV9g@public.gmane.org <hch-jcswGhMUV9g@public.gmane.org> - martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org <martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> - philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org <philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org> - axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> - " shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" - "Cc\0linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" - linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org <dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org <drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org>\0" + "To\0agk@redhat.com <agk@redhat.com>" + lars.ellenberg@linbit.com <lars.ellenberg@linbit.com> + snitzer@redhat.com <snitzer@redhat.com> + hch@lst.de <hch@lst.de> + martin.petersen@oracle.com <martin.petersen@oracle.com> + philipp.reisner@linbit.com <philipp.reisner@linbit.com> + axboe@kernel.dk <axboe@kernel.dk> + " shli@kernel.org <shli@kernel.org>\0" + "Cc\0linux-block@vger.kernel.org <linux-block@vger.kernel.org>" + linux-raid@vger.kernel.org <linux-raid@vger.kernel.org> + dm-devel@redhat.com <dm-devel@redhat.com> + linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org> + " drbd-dev@lists.linbit.com <drbd-dev@lists.linbit.com>\0" "\00:1\0" "b\0" "On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote:\n" "> Try to use a write same with unmap bit variant if the device supports it\n" "> and the caller asks for it.\n" "> \n" - "> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>\n" + "> Signed-off-by: Christoph Hellwig <hch@lst.de>\n" "> ---\n" "> drivers/scsi/sd.c | 10 ++++++++++\n" "> 1 file changed, 10 insertions(+)\n" @@ -56,4 +55,4 @@ "\n" Bart. -e94881da2d7b67459d53a0cf3d826adbee98a0e70c50f97a011a3a7d39075732 +a7ef0750c13b0457e987fc88f4eba5953c3489a437cf66d598ce9fb7a73b949d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.