From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Tue, 28 Mar 2017 21:16:02 +0200 Subject: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com> References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-4-hgkr.klein@gmail.com> Message-ID: <1490728562.20764.9.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote: > This patch gets the core clock as provided by the DT and enables it. > The code was taken from Amlogic's serial driver, and was tested on my > board. > > Signed-off-by: Helmut Klein > --- > ?drivers/tty/serial/meson_uart.c | 10 ++++++++++ > ?1 file changed, 10 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 60f16795d16b..cb99112288eb 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev) > ? struct resource *res_mem, *res_irq; > ? struct uart_port *port; > ? struct clk *clk; > + struct clk *core_clk; > ? int ret = 0; > > ? if (pdev->dev.of_node) > @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev) > ? if (!port) > ? return -ENOMEM; > > + core_clk = devm_clk_get(&pdev->dev, "core"); > + if (!IS_ERR(core_clk)) { > + ret = clk_prepare_enable(core_clk); > + if (ret) { > + dev_err(&pdev->dev, "couldn't enable clkc\n"); > + return ret; > + } > + } > + > ? clk = clk_get(&pdev->dev, NULL); Now that you have 2 clocks, shouldn't this be named as well ? > ? if (IS_ERR(clk)) > ? return PTR_ERR(clk); > -- > 2.11.0 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver Date: Tue, 28 Mar 2017 21:16:02 +0200 Message-ID: <1490728562.20764.9.camel@baylibre.com> References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-4-hgkr.klein@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Helmut Klein , gregkh@linuxfoundation.org, carlo@caione.org, khilman@baylibre.com Cc: linux-amlogic@lists.infradead.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org T24gVHVlLCAyMDE3LTAzLTI4IGF0IDExOjI1ICswMjAwLCBIZWxtdXQgS2xlaW4gd3JvdGU6Cj4g VGhpcyBwYXRjaCBnZXRzIHRoZSBjb3JlIGNsb2NrIGFzIHByb3ZpZGVkIGJ5IHRoZSBEVCBhbmQg ZW5hYmxlcyBpdC4KPiBUaGUgY29kZSB3YXMgdGFrZW4gZnJvbSBBbWxvZ2ljJ3Mgc2VyaWFsIGRy aXZlciwgYW5kIHdhcyB0ZXN0ZWQgb24gbXkKPiBib2FyZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBI ZWxtdXQgS2xlaW4gPGhna3Iua2xlaW5AZ21haWwuY29tPgo+IC0tLQo+IMKgZHJpdmVycy90dHkv c2VyaWFsL21lc29uX3VhcnQuYyB8IDEwICsrKysrKysrKysKPiDCoDEgZmlsZSBjaGFuZ2VkLCAx MCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdHR5L3NlcmlhbC9tZXNv bl91YXJ0LmMgYi9kcml2ZXJzL3R0eS9zZXJpYWwvbWVzb25fdWFydC5jCj4gaW5kZXggNjBmMTY3 OTVkMTZiLi5jYjk5MTEyMjg4ZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsL21l c29uX3VhcnQuYwo+ICsrKyBiL2RyaXZlcnMvdHR5L3NlcmlhbC9tZXNvbl91YXJ0LmMKPiBAQCAt NjAwLDYgKzYwMCw3IEBAIHN0YXRpYyBpbnQgbWVzb25fdWFydF9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+IMKgCXN0cnVjdCByZXNvdXJjZSAqcmVzX21lbSwgKnJlc19pcnE7 Cj4gwqAJc3RydWN0IHVhcnRfcG9ydCAqcG9ydDsKPiDCoAlzdHJ1Y3QgY2xrICpjbGs7Cj4gKwlz dHJ1Y3QgY2xrICpjb3JlX2NsazsKPiDCoAlpbnQgcmV0ID0gMDsKPiAKPiDCoAlpZiAocGRldi0+ ZGV2Lm9mX25vZGUpCj4gQEAgLTYyNSw2ICs2MjYsMTUgQEAgc3RhdGljIGludCBtZXNvbl91YXJ0 X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gwqAJaWYgKCFwb3J0KQo+IMKg CQlyZXR1cm4gLUVOT01FTTsKPiAKPiArCWNvcmVfY2xrID0gZGV2bV9jbGtfZ2V0KCZwZGV2LT5k ZXYsICJjb3JlIik7Cj4gKwlpZiAoIUlTX0VSUihjb3JlX2NsaykpIHsKPiArCQlyZXQgPSBjbGtf cHJlcGFyZV9lbmFibGUoY29yZV9jbGspOwo+ICsJCWlmIChyZXQpIHsKPiArCQkJZGV2X2Vycigm cGRldi0+ZGV2LCAiY291bGRuJ3QgZW5hYmxlIGNsa2NcbiIpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ ICsJCX0KPiArCX0KPiArCj4gwqAJY2xrID0gY2xrX2dldCgmcGRldi0+ZGV2LCBOVUxMKTsKTm93 IHRoYXQgeW91IGhhdmUgMiBjbG9ja3MsIHNob3VsZG4ndCB0aGlzIGJlIG5hbWVkIGFzIHdlbGwg PwoKPiDCoAlpZiAoSVNfRVJSKGNsaykpCj4gwqAJCXJldHVybiBQVFJfRVJSKGNsayk7Cj4gLS0K PiAyLjExLjAKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0Cj4gbGludXgtYW1sb2dpY0BsaXN0 cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hbWxvZ2ljCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Tue, 28 Mar 2017 21:16:02 +0200 Subject: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com> References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-4-hgkr.klein@gmail.com> Message-ID: <1490728562.20764.9.camel@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote: > This patch gets the core clock as provided by the DT and enables it. > The code was taken from Amlogic's serial driver, and was tested on my > board. > > Signed-off-by: Helmut Klein > --- > ?drivers/tty/serial/meson_uart.c | 10 ++++++++++ > ?1 file changed, 10 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 60f16795d16b..cb99112288eb 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev) > ? struct resource *res_mem, *res_irq; > ? struct uart_port *port; > ? struct clk *clk; > + struct clk *core_clk; > ? int ret = 0; > > ? if (pdev->dev.of_node) > @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev) > ? if (!port) > ? return -ENOMEM; > > + core_clk = devm_clk_get(&pdev->dev, "core"); > + if (!IS_ERR(core_clk)) { > + ret = clk_prepare_enable(core_clk); > + if (ret) { > + dev_err(&pdev->dev, "couldn't enable clkc\n"); > + return ret; > + } > + } > + > ? clk = clk_get(&pdev->dev, NULL); Now that you have 2 clocks, shouldn't this be named as well ? > ? if (IS_ERR(clk)) > ? return PTR_ERR(clk); > -- > 2.11.0 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755735AbdC1TQX (ORCPT ); Tue, 28 Mar 2017 15:16:23 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37299 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755119AbdC1TQV (ORCPT ); Tue, 28 Mar 2017 15:16:21 -0400 Message-ID: <1490728562.20764.9.camel@baylibre.com> Subject: Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver From: Jerome Brunet To: Helmut Klein , gregkh@linuxfoundation.org, carlo@caione.org, khilman@baylibre.com Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 28 Mar 2017 21:16:02 +0200 In-Reply-To: <20170328092545.4644-4-hgkr.klein@gmail.com> References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-4-hgkr.klein@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote: > This patch gets the core clock as provided by the DT and enables it. > The code was taken from Amlogic's serial driver, and was tested on my > board. > > Signed-off-by: Helmut Klein > --- >  drivers/tty/serial/meson_uart.c | 10 ++++++++++ >  1 file changed, 10 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 60f16795d16b..cb99112288eb 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev) >   struct resource *res_mem, *res_irq; >   struct uart_port *port; >   struct clk *clk; > + struct clk *core_clk; >   int ret = 0; > >   if (pdev->dev.of_node) > @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev) >   if (!port) >   return -ENOMEM; > > + core_clk = devm_clk_get(&pdev->dev, "core"); > + if (!IS_ERR(core_clk)) { > + ret = clk_prepare_enable(core_clk); > + if (ret) { > + dev_err(&pdev->dev, "couldn't enable clkc\n"); > + return ret; > + } > + } > + >   clk = clk_get(&pdev->dev, NULL); Now that you have 2 clocks, shouldn't this be named as well ? >   if (IS_ERR(clk)) >   return PTR_ERR(clk); > -- > 2.11.0 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic