From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ftgmac100: Mostly rewrite the driver
Date: Wed, 29 Mar 2017 16:03:07 +1100 [thread overview]
Message-ID: <1490763787.3177.168.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170328.215744.794906222630964588.davem@davemloft.net>
On Tue, 2017-03-28 at 21:57 -0700, David Miller wrote:
> This is unreviewable.
>
> You must break this up into small, reviewable pieces.
>
> If you didn't save the steps of your work in that way, that isn't
> our problem.
That's not realistic, it would probably not improve the readability
much. I basically ended up rewriting the driver almost completely
Dave. It's not even a matter of saving my work steps, each of them
involved pulling appart an entire side of the old driver and re-doing
it.
That's why I said it's better reviewed as a new driver. We have no
other user of it in the tree anyway.
Do you prefer that I submit it as a new driver for that IP block
instead and take out the old one later ?
Cheers,
Ben.
next prev parent reply other threads:[~2017-03-29 5:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 4:40 [PATCH net] ftgmac100: Mostly rewrite the driver Benjamin Herrenschmidt
2017-03-29 4:57 ` David Miller
2017-03-29 5:03 ` Benjamin Herrenschmidt [this message]
2017-03-29 5:10 ` David Miller
2017-03-29 5:18 ` Benjamin Herrenschmidt
2017-03-29 18:08 ` Florian Fainelli
2017-03-29 21:08 ` Benjamin Herrenschmidt
2017-03-30 0:46 ` Benjamin Herrenschmidt
2017-03-30 3:15 ` David Miller
2017-03-31 9:59 ` Benjamin Herrenschmidt
2017-03-31 13:52 ` Andrew Lunn
2017-03-31 21:14 ` Benjamin Herrenschmidt
2017-03-31 21:56 ` Andrew Lunn
2017-03-31 16:56 ` David Miller
2017-03-29 17:42 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490763787.3177.168.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.