From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Wed, 29 Mar 2017 13:34:00 +0000 Subject: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property In-Reply-To: <20170303182102.GP917@e110455-lin.cambridge.arm.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> <1488563298.2940.33.camel@synopsys.com> <20170303182102.GP917@e110455-lin.cambridge.arm.com> List-ID: Message-ID: <1490794439.7754.88.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Liviu, Rob, On Fri, 2017-03-03@18:21 +0000, Liviu.Dudau@arm.com wrote: > On Fri, Mar 03, 2017@05:48:19PM +0000, Alexey Brodkin wrote: > > > > Hi Liviu, > > > > On Fri, 2017-03-03@16:28 +0000, Liviu Dudau wrote: > > > > > > On Fri, Mar 03, 2017@06:19:24PM +0300, Alexey Brodkin wrote: > > > > > > > > > > > > - /* find the encoder node and initialize it */ > > > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0); > > > > - if (encoder_node) { > > > > - ret = arcpgu_drm_hdmi_init(drm, encoder_node); > > > > - of_node_put(encoder_node); > > > > + /* There is only one output port inside each device, find it */ > > > > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL); > > > > + > > > > + if (port) { > > > > + if (of_device_is_available(port)) > > > > + encoder = of_graph_get_remote_port_parent(port); > > > > + of_node_put(port); > > > > + } > > > > > > You must've been looking at some old version. Current version in -next uses > > > of_graph_get_remote_node() to replace all those lines you have added (see Rob > > > Herring's series to introduce of_graph_get_remote_node() function) > > > > Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :) > > Still I made a check of linux-next and don't see any changes in > > "drivers/gpu/drm/arm" compared to Linus' tree. > > > > [1]?https://urldefense.proofpoint.com/v2/url?u=http-3A__git.kernel.org_cgit_linux_kernel_git_torvalds_linux.git_commit_drivers_gpu_drm_arm-3Fid-3D > > e4563f6ba71792c77aeccb2092cc23149b44e642&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=SI66ngnnXy33ncb8m5H4La2 > > T1SzSEiiP7hc_XsRahEc&s=uaswjVXcjYDrUosOkO_UpTMqJMWTT-LLPrg5JE6-t-8&e=? > > [2]?https://urldefense.proofpoint.com/v2/url?u=http-3A__git.kernel.org_cgit_linux_kernel_git_next_linux-2Dnext.git_commit_drivers_gpu_drm_arm-3Fid > > -3De4563f6ba71792c77aeccb2092cc23149b44e642&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=SI66ngnnXy33ncb8m5H4 > > La2T1SzSEiiP7hc_XsRahEc&s=hl9Y6s3K9LwLL1M2WnL3ODax_V-ZRh8k1iTiyctIqU4&e=? > > > > Could you please clarify which exact tree did you mean? > > Sorry, I thought the series got pulled by one of the DRM trees, but it looks like > I was wrong. I was carrying a private copy in my internal tree, waiting for the > moment when it got pulled into drm-next or drm-misc-next. > > Rob, do you have an update on your series introducing of_graph_get_remote_node() ? For some reason I cannot find any relevant commits in linux-next tree even today. Could you please point me to either any random git tree with mentioned above change or maybe just mailing list where this patch was sent? I'd like to implement the same fix in ARCPGU and call it a day finally. -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Date: Wed, 29 Mar 2017 13:34:00 +0000 Message-ID: <1490794439.7754.88.camel@synopsys.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> <1488563298.2940.33.camel@synopsys.com> <20170303182102.GP917@e110455-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170303182102.GP917-A/Nd4k6kWRHZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Content-Language: en-US Content-ID: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Liviu.Dudau-5wv7dgnIgG8@public.gmane.org" , "robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Eugeniy Paltsev , "daniel-/w4YWyX8dFk@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "airlied-cv59FeDIM0c@public.gmane.org" List-Id: devicetree@vger.kernel.org SGkgTGl2aXUsIFJvYiwNCg0KT24gRnJpLCAyMDE3LTAzLTAzIGF0IDE4OjIxICswMDAwLCBMaXZp dS5EdWRhdUBhcm0uY29tIHdyb3RlOg0KPiBPbiBGcmksIE1hciAwMywgMjAxNyBhdCAwNTo0ODox OVBNICswMDAwLCBBbGV4ZXkgQnJvZGtpbiB3cm90ZToNCj4gPiANCj4gPiBIaSBMaXZpdSwNCj4g PiANCj4gPiBPbiBGcmksIDIwMTctMDMtMDMgYXQgMTY6MjggKzAwMDAsIExpdml1IER1ZGF1IHdy b3RlOg0KPiA+ID4gDQo+ID4gPiBPbiBGcmksIE1hciAwMywgMjAxNyBhdCAwNjoxOToyNFBNICsw MzAwLCBBbGV4ZXkgQnJvZGtpbiB3cm90ZToNCj4gPiA+ID4gDQo+ID4gPiA+IA0KPiA+ID4gPiAt CS8qIGZpbmQgdGhlIGVuY29kZXIgbm9kZSBhbmQgaW5pdGlhbGl6ZSBpdCAqLw0KPiA+ID4gPiAt CWVuY29kZXJfbm9kZSA9IG9mX3BhcnNlX3BoYW5kbGUoZHJtLT5kZXYtPm9mX25vZGUsICJlbmNv ZGVyLXNsYXZlIiwgMCk7DQo+ID4gPiA+IC0JaWYgKGVuY29kZXJfbm9kZSkgew0KPiA+ID4gPiAt CQlyZXQgPSBhcmNwZ3VfZHJtX2hkbWlfaW5pdChkcm0sIGVuY29kZXJfbm9kZSk7DQo+ID4gPiA+ IC0JCW9mX25vZGVfcHV0KGVuY29kZXJfbm9kZSk7DQo+ID4gPiA+ICsJLyogVGhlcmUgaXMgb25s eSBvbmUgb3V0cHV0IHBvcnQgaW5zaWRlIGVhY2ggZGV2aWNlLCBmaW5kIGl0ICovDQo+ID4gPiA+ ICsJcG9ydCA9IG9mX2dyYXBoX2dldF9uZXh0X2VuZHBvaW50KHBkZXYtPmRldi5vZl9ub2RlLCBO VUxMKTsNCj4gPiA+ID4gKw0KPiA+ID4gPiArCWlmIChwb3J0KSB7DQo+ID4gPiA+ICsJCWlmIChv Zl9kZXZpY2VfaXNfYXZhaWxhYmxlKHBvcnQpKQ0KPiA+ID4gPiArCQkJZW5jb2RlciA9IG9mX2dy YXBoX2dldF9yZW1vdGVfcG9ydF9wYXJlbnQocG9ydCk7DQo+ID4gPiA+ICsJCW9mX25vZGVfcHV0 KHBvcnQpOw0KPiA+ID4gPiArCX0NCj4gPiA+IA0KPiA+ID4gWW91IG11c3QndmUgYmVlbiBsb29r aW5nIGF0IHNvbWUgb2xkIHZlcnNpb24uIEN1cnJlbnQgdmVyc2lvbiBpbiAtbmV4dCB1c2VzDQo+ ID4gPiBvZl9ncmFwaF9nZXRfcmVtb3RlX25vZGUoKSB0byByZXBsYWNlIGFsbCB0aG9zZSBsaW5l cyB5b3UgaGF2ZSBhZGRlZCAoc2VlIFJvYg0KPiA+ID4gSGVycmluZydzIHNlcmllcyB0byBpbnRy b2R1Y2Ugb2ZfZ3JhcGhfZ2V0X3JlbW90ZV9ub2RlKCkgZnVuY3Rpb24pDQo+ID4gDQo+ID4gSG0s IEknbSBub3Qgb24gTGludXMnIG1hc3RlciB0cmVlIFsxXSBhbmQgc28gSSB0aG91Z2h0IEkgd2Fz IHF1aXRlIHVwIHRvIGRhdGUgOikNCj4gPiBTdGlsbCBJIG1hZGUgYSBjaGVjayBvZiBsaW51eC1u ZXh0IGFuZCBkb24ndCBzZWUgYW55IGNoYW5nZXMgaW4NCj4gPiAiZHJpdmVycy9ncHUvZHJtL2Fy bSIgY29tcGFyZWQgdG8gTGludXMnIHRyZWUuDQo+ID4gDQo+ID4gWzFdwqBodHRwczovL3VybGRl ZmVuc2UucHJvb2Zwb2ludC5jb20vdjIvdXJsP3U9aHR0cC0zQV9fZ2l0Lmtlcm5lbC5vcmdfY2dp dF9saW51eF9rZXJuZWxfZ2l0X3RvcnZhbGRzX2xpbnV4LmdpdF9jb21taXRfZHJpdmVyc19ncHVf ZHJtX2FybS0zRmlkLTNEDQo+ID4gZTQ1NjNmNmJhNzE3OTJjNzdhZWNjYjIwOTJjYzIzMTQ5YjQ0 ZTY0MiZkPUR3SURhUSZjPURQTDZfWF82SmtYRng3QVhXcUIwdGcmcj1scWRlZVNTRWVzMEdGRERs NjU2ZVZpWE83YnJlUzU1eXRXa2hwazVSODFJJm09U0k2Nm5nbm5YeTMzbmNiOG01SDRMYTINCj4g PiBUMVN6U0VpaVA3aGNfWHNSYWhFYyZzPXVhc3dqVlhjallEclVvc09rT19VcFRNcUpNV1RULUxM UHJnNUpFNi10LTgmZT3CoA0KPiA+IFsyXcKgaHR0cHM6Ly91cmxkZWZlbnNlLnByb29mcG9pbnQu Y29tL3YyL3VybD91PWh0dHAtM0FfX2dpdC5rZXJuZWwub3JnX2NnaXRfbGludXhfa2VybmVsX2dp dF9uZXh0X2xpbnV4LTJEbmV4dC5naXRfY29tbWl0X2RyaXZlcnNfZ3B1X2RybV9hcm0tM0ZpZA0K PiA+IC0zRGU0NTYzZjZiYTcxNzkyYzc3YWVjY2IyMDkyY2MyMzE0OWI0NGU2NDImZD1Ed0lEYVEm Yz1EUEw2X1hfNkprWEZ4N0FYV3FCMHRnJnI9bHFkZWVTU0VlczBHRkREbDY1NmVWaVhPN2JyZVM1 NXl0V2tocGs1UjgxSSZtPVNJNjZuZ25uWHkzM25jYjhtNUg0DQo+ID4gTGEyVDFTelNFaWlQN2hj X1hzUmFoRWMmcz1obDlZNnMzSzlMd0xMMU0yV25MM09EYXhfVi1aUmg4azFpVGl5Y3RJcVU0JmU9 wqANCj4gPiANCj4gPiBDb3VsZCB5b3UgcGxlYXNlIGNsYXJpZnkgd2hpY2ggZXhhY3QgdHJlZSBk aWQgeW91IG1lYW4/DQo+IA0KPiBTb3JyeSwgSSB0aG91Z2h0IHRoZSBzZXJpZXMgZ290IHB1bGxl ZCBieSBvbmUgb2YgdGhlIERSTSB0cmVlcywgYnV0IGl0IGxvb2tzIGxpa2UNCj4gSSB3YXMgd3Jv bmcuIEkgd2FzIGNhcnJ5aW5nIGEgcHJpdmF0ZSBjb3B5IGluIG15IGludGVybmFsIHRyZWUsIHdh aXRpbmcgZm9yIHRoZQ0KPiBtb21lbnQgd2hlbiBpdCBnb3QgcHVsbGVkIGludG8gZHJtLW5leHQg b3IgZHJtLW1pc2MtbmV4dC4NCj4gDQo+IFJvYiwgZG8geW91IGhhdmUgYW4gdXBkYXRlIG9uIHlv dXIgc2VyaWVzIGludHJvZHVjaW5nIG9mX2dyYXBoX2dldF9yZW1vdGVfbm9kZSgpID8NCg0KRm9y IHNvbWUgcmVhc29uIEkgY2Fubm90IGZpbmQgYW55IHJlbGV2YW50IGNvbW1pdHMgaW4gbGludXgt bmV4dCB0cmVlIGV2ZW4gdG9kYXkuDQpDb3VsZCB5b3UgcGxlYXNlIHBvaW50IG1lIHRvIGVpdGhl ciBhbnkgcmFuZG9tIGdpdCB0cmVlIHdpdGggbWVudGlvbmVkIGFib3ZlIGNoYW5nZSBvcg0KbWF5 YmUganVzdCBtYWlsaW5nIGxpc3Qgd2hlcmUgdGhpcyBwYXRjaCB3YXMgc2VudD8NCg0KSSdkIGxp a2UgdG8gaW1wbGVtZW50IHRoZSBzYW1lIGZpeCBpbiBBUkNQR1UgYW5kIGNhbGwgaXQgYSBkYXkg ZmluYWxseS4NCg0KLUFsZXhleQ== -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756116AbdC2NeI (ORCPT ); Wed, 29 Mar 2017 09:34:08 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:54453 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753463AbdC2NeH (ORCPT ); Wed, 29 Mar 2017 09:34:07 -0400 From: Alexey Brodkin To: "Liviu.Dudau@arm.com" , "robh@kernel.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , Eugeniy Paltsev , "daniel@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" Subject: Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Thread-Topic: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property Thread-Index: AQHSlDGTEmuTvpdNt0S/hqvgRgNDbqGDPUSAgAAWQwCAAAkmAIAoe6aA Date: Wed, 29 Mar 2017 13:34:00 +0000 Message-ID: <1490794439.7754.88.camel@synopsys.com> References: <1488554364-25579-1-git-send-email-abrodkin@synopsys.com> <20170303162837.GO917@e110455-lin.cambridge.arm.com> <1488563298.2940.33.camel@synopsys.com> <20170303182102.GP917@e110455-lin.cambridge.arm.com> In-Reply-To: <20170303182102.GP917@e110455-lin.cambridge.arm.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.98] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2TDYCEI015111 Hi Liviu, Rob, On Fri, 2017-03-03 at 18:21 +0000, Liviu.Dudau@arm.com wrote: > On Fri, Mar 03, 2017 at 05:48:19PM +0000, Alexey Brodkin wrote: > > > > Hi Liviu, > > > > On Fri, 2017-03-03 at 16:28 +0000, Liviu Dudau wrote: > > > > > > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > > > > > > > > > - /* find the encoder node and initialize it */ > > > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0); > > > > - if (encoder_node) { > > > > - ret = arcpgu_drm_hdmi_init(drm, encoder_node); > > > > - of_node_put(encoder_node); > > > > + /* There is only one output port inside each device, find it */ > > > > + port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL); > > > > + > > > > + if (port) { > > > > + if (of_device_is_available(port)) > > > > + encoder = of_graph_get_remote_port_parent(port); > > > > + of_node_put(port); > > > > + } > > > > > > You must've been looking at some old version. Current version in -next uses > > > of_graph_get_remote_node() to replace all those lines you have added (see Rob > > > Herring's series to introduce of_graph_get_remote_node() function) > > > > Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :) > > Still I made a check of linux-next and don't see any changes in > > "drivers/gpu/drm/arm" compared to Linus' tree. > > > > [1] https://urldefense.proofpoint.com/v2/url?u=http-3A__git.kernel.org_cgit_linux_kernel_git_torvalds_linux.git_commit_drivers_gpu_drm_arm-3Fid-3D > > e4563f6ba71792c77aeccb2092cc23149b44e642&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=SI66ngnnXy33ncb8m5H4La2 > > T1SzSEiiP7hc_XsRahEc&s=uaswjVXcjYDrUosOkO_UpTMqJMWTT-LLPrg5JE6-t-8&e=  > > [2] https://urldefense.proofpoint.com/v2/url?u=http-3A__git.kernel.org_cgit_linux_kernel_git_next_linux-2Dnext.git_commit_drivers_gpu_drm_arm-3Fid > > -3De4563f6ba71792c77aeccb2092cc23149b44e642&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=SI66ngnnXy33ncb8m5H4 > > La2T1SzSEiiP7hc_XsRahEc&s=hl9Y6s3K9LwLL1M2WnL3ODax_V-ZRh8k1iTiyctIqU4&e=  > > > > Could you please clarify which exact tree did you mean? > > Sorry, I thought the series got pulled by one of the DRM trees, but it looks like > I was wrong. I was carrying a private copy in my internal tree, waiting for the > moment when it got pulled into drm-next or drm-misc-next. > > Rob, do you have an update on your series introducing of_graph_get_remote_node() ? For some reason I cannot find any relevant commits in linux-next tree even today. Could you please point me to either any random git tree with mentioned above change or maybe just mailing list where this patch was sent? I'd like to implement the same fix in ARCPGU and call it a day finally. -Alexey