diff for duplicates of <1490865403.32756.21.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index ca733df..efe6415 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ Hi Eric, -On Wed, 2017-03-29@14:41 -0700, Eric Dumazet wrote: -> On Wed, Mar 29, 2017@2:30 PM, David Miller <davem@davemloft.net> wrote: -> Signed-off-by: Vlad Zakharov <vzakhar at synopsys.com> +On Wed, 2017-03-29 at 14:41 -0700, Eric Dumazet wrote: +> On Wed, Mar 29, 2017 at 2:30 PM, David Miller <davem@davemloft.net> wrote: +> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com> > > > > > > Applied. @@ -17,7 +17,7 @@ On Wed, 2017-03-29@14:41 -0700, Eric Dumazet wrote: > It is not clear to me what exactly happened to this driver, since > testing napi_complete_done() was not mandatory. -I am not sure what is happening with other drivers, but in case of ezchip?nps_enet driver after the following commit: +I am not sure what is happening with other drivers, but in case of ezchip nps_enet driver after the following commit: 39e6c8208d7b6fb9d2047850fb3327db567b564b if we got into NAPI_STATE_MISSED state the following happened: @@ -29,8 +29,8 @@ inside this function we will see that it disables interrupts only in case napi_s napi_sched_prep() returns true only in case it changes state from non-SCHED to SCHED. But in our case as SCHED had been already set it set MISSED state and then returned false. So at that point we had already been trapped: after exiting irq hanlder we were getting into nps_enet_irq_hanlder() again and again as we couldn't rescind pending irq signal and -disable corresponding irq.? +disable corresponding irq. -- Best regards, -Vlad Zakharov <vzakhar at synopsys.com> +Vlad Zakharov <vzakhar@synopsys.com> diff --git a/a/content_digest b/N1/content_digest index 5a4f556..896bebd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,24 @@ "ref\01490784106-14489-1-git-send-email-vzakhar@synopsys.com\0" "ref\020170329.143014.2001816338079751776.davem@davemloft.net\0" "ref\0CANn89iJ1+7CrF=hJj-_pLWV+EDXxhUZGOL+3je6zjE8dJDcr=A@mail.gmail.com\0" - "From\0Vladislav.Zakharov@synopsys.com (Vlad Zakharov)\0" - "Subject\0[PATCH] ezchip: nps_enet: check if napi has been completed\0" + "From\0Vlad Zakharov <Vladislav.Zakharov@synopsys.com>\0" + "Subject\0Re: [PATCH] ezchip: nps_enet: check if napi has been completed\0" "Date\0Thu, 30 Mar 2017 09:16:44 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0edumazet@google.com <edumazet@google.com>\0" + "Cc\0netdev@vger.kernel.org <netdev@vger.kernel.org>" + eladkan@mellanox.com <eladkan@mellanox.com> + davem@davemloft.net <davem@davemloft.net> + noamca@mellanox.com <noamca@mellanox.com> + Vladislav.Zakharov@synopsys.com <Vladislav.Zakharov@synopsys.com> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "Hi Eric,\n" "\n" - "On Wed, 2017-03-29@14:41 -0700, Eric Dumazet wrote:\n" - "> On Wed, Mar 29, 2017@2:30 PM, David Miller <davem@davemloft.net> wrote:\n" - "> Signed-off-by: Vlad Zakharov <vzakhar at synopsys.com>\n" + "On Wed, 2017-03-29 at 14:41 -0700, Eric Dumazet wrote:\n" + "> On Wed, Mar 29, 2017 at 2:30 PM, David Miller <davem@davemloft.net> wrote:\n" + "> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>\n" "> > \n" "> > \n" "> > Applied.\n" @@ -26,7 +33,7 @@ "> It is not clear to me what exactly happened to this driver, since\n" "> testing napi_complete_done() was not mandatory.\n" "\n" - "I am not sure what is happening with other drivers, but in case of ezchip?nps_enet driver after the following commit:\n" + "I am not sure what is happening with other drivers, but in case of ezchip\302\240nps_enet driver after the following commit:\n" "39e6c8208d7b6fb9d2047850fb3327db567b564b\n" "\n" "if we got into NAPI_STATE_MISSED state the following happened:\n" @@ -38,10 +45,10 @@ "napi_sched_prep() returns true only in case it changes state from non-SCHED to SCHED. But in our case as SCHED had been\n" "already set it set MISSED state and then returned false. So at that point we had already been trapped: after exiting irq\n" "hanlder we were getting into nps_enet_irq_hanlder() again and again as we couldn't rescind pending irq signal and\n" - "disable corresponding irq.?\n" + "disable corresponding irq.\302\240\n" "\n" "-- \n" "Best regards,\n" - Vlad Zakharov <vzakhar at synopsys.com> + Vlad Zakharov <vzakhar@synopsys.com> -45d5e78a969cf436dfdd02c49453802c8dbc2bdb5a0532de47eb4c21b134334f +85a1712f2c5e979694a766224e867708ed0d220cd696a5d1e900c9886e9204ab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.