From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: Ironlake do_idle_maps w/a may be called w/o struct_mutex Date: Thu, 30 Mar 2017 13:02:52 +0300 Message-ID: <1490868172.3067.1.camel@linux.intel.com> References: <20170330085341.20311-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 073126E2BC for ; Thu, 30 Mar 2017 10:02:56 +0000 (UTC) In-Reply-To: <20170330085341.20311-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , "# v4 . 10+" List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTctMDMtMzAgYXQgMDk6NTMgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBT aW5jZSBjb21taXQgMTIzM2UyZGIxOTlkICgiZHJtL2k5MTU6IE1vdmUgb2JqZWN0IGJhY2tpbmcg c3RvcmFnZQo+IG1hbmlwdWxhdGlvbiB0byBpdHMgb3duIGxvY2tpbmciKSwgaTkxNV9nZW1fb2Jq ZWN0X3B1dF9wYWdlcygpIGFuZAo+IHNwZWNpZmljYWxseSB0aGUgaTkxNV9nZW1fZ3R0X2Zpbmlz aF9wYWdlcygpIG1heSBiZSBjYWxsZWQgZnJvbSBvdXRzaWRlCj4gb2YgdGhlIHN0cnVjdF9tdXRl eCBhbmQgc28gd2UgY2FuIG5vIGxvbmdlciBwYXNzIEk5MTVfV0FJVF9MT0NLRUQgdG8KPiBpOTE1 X2dlbV93YWl0X2Zvcl9pZGxlLgo+IAo+IEZpeGVzOiAxMjMzZTJkYjE5OWQgKCJkcm0vaTkxNTog TW92ZSBvYmplY3QgYmFja2luZyBzdG9yYWdlIG1hbmlwdWxhdGlvbiB0byBpdHMgb3duIGxvY2tp bmciKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog Sm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogSmFuaSBOaWt1bGEg PGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMCsKCklzIHRo ZXJlIEJ1Z3ppbGxhIG9yIGRpZCB5b3UganVzdCBoaXQgdGhlIGFzc2VydCBvbiB5b3VyIG93bj8K ClJldmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+CgpSZWdhcmRzLCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBU ZWNobm9sb2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:50145 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932912AbdC3KC5 (ORCPT ); Thu, 30 Mar 2017 06:02:57 -0400 Message-ID: <1490868172.3067.1.camel@linux.intel.com> Subject: Re: [PATCH] drm/i915: Ironlake do_idle_maps w/a may be called w/o struct_mutex From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Jani Nikula , "# v4 . 10+" Date: Thu, 30 Mar 2017 13:02:52 +0300 In-Reply-To: <20170330085341.20311-1-chris@chris-wilson.co.uk> References: <20170330085341.20311-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On to, 2017-03-30 at 09:53 +0100, Chris Wilson wrote: > Since commit 1233e2db199d ("drm/i915: Move object backing storage > manipulation to its own locking"), i915_gem_object_put_pages() and > specifically the i915_gem_gtt_finish_pages() may be called from outside > of the struct_mutex and so we can no longer pass I915_WAIT_LOCKED to > i915_gem_wait_for_idle. > > Fixes: 1233e2db199d ("drm/i915: Move object backing storage manipulation to its own locking") > Signed-off-by: Chris Wilson > Cc: Chris Wilson > Cc: Joonas Lahtinen > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org > Cc: # v4.10+ Is there Bugzilla or did you just hit the assert on your own? Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation