From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
John Spotswood <john.a.spotswood@intel.com>,
Anusha Srivatsa <anusha.srivatsa@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/GLK/HuC: Load HuC on GLK
Date: Thu, 30 Mar 2017 16:54:18 +0300 [thread overview]
Message-ID: <1490882058.3067.16.camel@linux.intel.com> (raw)
In-Reply-To: <87k2785xhh.fsf@intel.com>
On ke, 2017-03-29 at 10:54 +0300, Jani Nikula wrote:
> > On Wed, 29 Mar 2017, John Spotswood <john.a.spotswood@intel.com> wrote:
> >
> > On Tue, 2017-03-21 at 17:29 -0700, Anusha Srivatsa wrote:
> > >
> > > +#define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR, \
> > > + GLK_HUC_FW_MINOR, GLK_BLD_NUM)
> >
> > I think you need a line after this #define that says the following:
> > MODULE_FIRMWARE(I915_GLK_HUC_UCODE);
>
> The rule is, we'll only add the MODULE_FIRMWARE annotation *after* the
> firmware blob has hit the linux-firmware repository.
Maybe we should document the expectation here too?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-03-30 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 0:29 [PATCH] drm/i915/GLK/HuC: Load HuC on GLK Anusha Srivatsa
2017-03-22 0:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-28 21:26 ` [PATCH] " John Spotswood
2017-03-29 7:54 ` Jani Nikula
2017-03-30 13:54 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490882058.3067.16.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=john.a.spotswood@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.