Re: [PATCH v2 2/6] GMAC: define clock ID used for GMAC

["Heiko Stübner" <heiko@sntech.de>]

Hi Roger,

patches modifying the rockchip clock parts should have a subject like
	clk: rockchip: .....

Same for the following patch

Am Donnerstag, 27. November 2014, 10:52:46 schrieb Roger Chen:
> Signed-off-by: Roger Chen <roger.chen@rock-chips.com>
> ---
>  include/dt-bindings/clock/rk3288-cru.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/clock/rk3288-cru.h
> b/include/dt-bindings/clock/rk3288-cru.h index 100a08c..f9496f5 100644
> --- a/include/dt-bindings/clock/rk3288-cru.h
> +++ b/include/dt-bindings/clock/rk3288-cru.h
> @@ -72,6 +72,10 @@
>  #define SCLK_HEVC_CABAC		111
>  #define SCLK_HEVC_CORE		112
> 
> +#define SCLK_MAC_PLL		150

Why do you need to export the mac pll source selection?
I understand SCLK_MAC below, as you will want to select ext_gmac explicitly if 
available. But otherwise, why would you need to explicitly select the pll 
source?

The clock framework is intelligent enough that when you do a 
clk_set_rate(sclk_mac, 50000000) for example that it will select the best pll 
source + best divider to provide the most accurate frequency for this, so 
there should be no need to handle the pll source manually.


Heiko

> +#define SCLK_MAC		151
> +#define SCLK_MACREF_OUT		152
> +
>  #define DCLK_VOP0		190
>  #define DCLK_VOP1		191