All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>
To: "Burton, Ross" <ross.burton@intel.com>,
	"Maxin B. John" <maxin.john@intel.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] libjpeg-turbo: fix build on aarch64 or non-intel build hosts
Date: Fri, 31 Mar 2017 16:43:46 +0900	[thread overview]
Message-ID: <1490946226.18519.36.camel@codethink.co.uk> (raw)
In-Reply-To: <CAJTo0Lar4023Z0kWdcgBPgc4aD+E6oEvh6jkfhCKdr0gtpYJkQ@mail.gmail.com>

On Thu, 2017-03-30 at 12:21 +0100, Burton, Ross wrote:
> 
> > Agree with Andre here. I would suggest to update nasm recipe to
> > support
> > build for other archs as well (tested on arm and it works as
> > expected. Will
> > require more testing on other archs).
> 
> Yes.  Simply deleting the COMPATIBLE_HOST in nasm.bb should be
> sufficient, Debian builds nasm for every architecture so that
> demonstrates that it builds just fine.
> 

Ok, I had this concern too when originally discussing the approach in
#yocto, this sounds better.

So just to get things straight, does this mean we no longer need the
patch to remove nasm-native from the jpeg turbo dependencies on non-
intel targets ?

I think "-native" here only means "build an nasm that I can run on the
host architecture" then I think this is fine, as jpeg-turbo will just
ignore the needlessly built nasm when targetting non-intel platforms.

Cheers,
    -Tristan



  reply	other threads:[~2017-03-31  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 12:11 [PATCH] libjpeg-turbo: fix build on aarch64 or non-intel build hosts Tristan Van Berkom
2017-03-29 12:32 ` ✗ patchtest: failure for " Patchwork
2017-03-30  1:44 ` [PATCH] " Andre McCurdy
2017-03-30  8:09   ` Maxin B. John
2017-03-30 11:21     ` Burton, Ross
2017-03-31  7:43       ` Tristan Van Berkom [this message]
2017-03-31  8:46         ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490946226.18519.36.camel@codethink.co.uk \
    --to=tristan.vanberkom@codethink.co.uk \
    --cc=maxin.john@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.