From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: mika.kuoppala@intel.com
Subject: Re: [PATCH 4/6] drm/i915: Wait for all engines to be idle as part of i915_gem_wait_for_idle()
Date: Fri, 31 Mar 2017 11:31:50 +0300 [thread overview]
Message-ID: <1490949110.3476.6.camel@linux.intel.com> (raw)
In-Reply-To: <20170330145041.9005-4-chris@chris-wilson.co.uk>
On to, 2017-03-30 at 15:50 +0100, Chris Wilson wrote:
> Make i915_gem_wait_for_idle() be a little heavier in order to try and
> guarantee that the GPU is indeed idle (by checking each engine
> individually is idle, i.e. all writes are complete and the rings
> stopped) after waiting for in-flight requests to be completed.
>
> v2: And return the final error.
> v3: Break the wait_for() out from under the WARN -- the macro expansion
> is hideous and unreadable in the warning message
> v4: If wait_for_engine() fails the result is catastrophic, mark the
> device as wedged and wait for the repair team.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=98836
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
That's more accurate yep, but is our other bookkeeping broken then?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-31 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 14:50 [PATCH 1/6] drm/i915: Do request retirement before marking engines as wedged Chris Wilson
2017-03-30 14:50 ` [PATCH 2/6] drm/i915: Suppress busy status for engines if wedged Chris Wilson
2017-03-30 14:50 ` [PATCH 3/6] drm/i915: Move retire-requests into i915_gem_wait_for_idle() Chris Wilson
2017-03-31 8:21 ` Joonas Lahtinen
2017-03-31 11:06 ` Chris Wilson
2017-03-30 14:50 ` [PATCH 4/6] drm/i915: Wait for all engines to be idle as part of i915_gem_wait_for_idle() Chris Wilson
2017-03-31 8:31 ` Joonas Lahtinen [this message]
2017-03-31 8:50 ` Chris Wilson
2017-03-30 14:50 ` [PATCH 5/6] drm/i915: Remove redudant wait for each engine to idle from seqno wrap Chris Wilson
2017-03-31 8:33 ` Joonas Lahtinen
2017-03-30 14:50 ` [PATCH 6/6] drm/i915: Combine reset_all_global_seqno() loops into one Chris Wilson
2017-03-31 8:39 ` Joonas Lahtinen
2017-03-30 15:50 ` ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Do request retirement before marking engines as wedged Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490949110.3476.6.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.