* [PATCH] drm/i915: make a few DDI functions static
@ 2017-03-30 20:57 Paulo Zanoni
2017-03-30 21:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-31 10:21 ` [PATCH] " Ville Syrjälä
0 siblings, 2 replies; 4+ messages in thread
From: Paulo Zanoni @ 2017-03-30 20:57 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
We don't need to export them since they're not being used outside the
file. The next time I try to find the callers for these things I will
know I won't need to look outside intel_ddi.c.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 8 ++++----
drivers/gpu/drm/i915/intel_drv.h | 4 ----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 83abab9..0914ad9 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -539,7 +539,7 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
* values in advance. This function programs the correct values for
* DP/eDP/FDI use cases.
*/
-void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)
+static void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
u32 iboost_bit = 0;
@@ -806,7 +806,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,
DP_TP_CTL_ENABLE);
}
-void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder)
+static void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder)
{
struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
struct intel_digital_port *intel_dig_port =
@@ -1616,8 +1616,8 @@ uint32_t ddi_signal_levels(struct intel_dp *intel_dp)
return DDI_BUF_TRANS_SELECT(level);
}
-void intel_ddi_clk_select(struct intel_encoder *encoder,
- struct intel_shared_dpll *pll)
+static void intel_ddi_clk_select(struct intel_encoder *encoder,
+ struct intel_shared_dpll *pll)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
enum port port = intel_ddi_get_encoder_port(encoder);
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index e24641b..313fad0 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1229,12 +1229,9 @@ void intel_crt_init(struct drm_i915_private *dev_priv);
void intel_crt_reset(struct drm_encoder *encoder);
/* intel_ddi.c */
-void intel_ddi_clk_select(struct intel_encoder *encoder,
- struct intel_shared_dpll *pll);
void intel_ddi_fdi_post_disable(struct intel_encoder *intel_encoder,
struct intel_crtc_state *old_crtc_state,
struct drm_connector_state *old_conn_state);
-void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder);
void hsw_fdi_link_train(struct intel_crtc *crtc,
const struct intel_crtc_state *crtc_state);
void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port);
@@ -1255,7 +1252,6 @@ bool intel_ddi_is_audio_enabled(struct drm_i915_private *dev_priv,
void intel_ddi_get_config(struct intel_encoder *encoder,
struct intel_crtc_state *pipe_config);
-void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder);
void intel_ddi_clock_get(struct intel_encoder *encoder,
struct intel_crtc_state *pipe_config);
void intel_ddi_set_vc_payload_alloc(const struct intel_crtc_state *crtc_state,
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: make a few DDI functions static
2017-03-30 20:57 [PATCH] drm/i915: make a few DDI functions static Paulo Zanoni
@ 2017-03-30 21:24 ` Patchwork
2017-03-31 10:21 ` [PATCH] " Ville Syrjälä
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-03-30 21:24 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: make a few DDI functions static
URL : https://patchwork.freedesktop.org/series/22242/
State : success
== Summary ==
Series 22242v1 drm/i915: make a few DDI functions static
https://patchwork.freedesktop.org/api/1.0/series/22242/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-kbl-7560u) fdo#100125
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 430s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time: 423s
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 582s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 511s
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 551s
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 488s
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 497s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 409s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 405s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 431s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 489s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 482s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 453s
fi-kbl-7560u total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time: 566s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 446s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 572s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 457s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 492s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time: 432s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 534s
fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time: 406s
d217cd61ada383a577dc686dd74f77856695ec84 drm-tip: 2017y-03m-30d-18h-24m-46s UTC integration manifest
90470a5 drm/i915: make a few DDI functions static
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4370/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: make a few DDI functions static
2017-03-30 20:57 [PATCH] drm/i915: make a few DDI functions static Paulo Zanoni
2017-03-30 21:24 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-03-31 10:21 ` Ville Syrjälä
2017-03-31 11:20 ` Paulo Zanoni
1 sibling, 1 reply; 4+ messages in thread
From: Ville Syrjälä @ 2017-03-31 10:21 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: intel-gfx
On Thu, Mar 30, 2017 at 05:57:52PM -0300, Paulo Zanoni wrote:
> We don't need to export them since they're not being used outside the
> file. The next time I try to find the callers for these things I will
> know I won't need to look outside intel_ddi.c.
You don't do cscope/ctags/whatever?
But anyway static is good since it hands the compiler a bit more rope.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 8 ++++----
> drivers/gpu/drm/i915/intel_drv.h | 4 ----
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 83abab9..0914ad9 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -539,7 +539,7 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv,
> * values in advance. This function programs the correct values for
> * DP/eDP/FDI use cases.
> */
> -void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)
> +static void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> u32 iboost_bit = 0;
> @@ -806,7 +806,7 @@ void hsw_fdi_link_train(struct intel_crtc *crtc,
> DP_TP_CTL_ENABLE);
> }
>
> -void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder)
> +static void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder)
> {
> struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> struct intel_digital_port *intel_dig_port =
> @@ -1616,8 +1616,8 @@ uint32_t ddi_signal_levels(struct intel_dp *intel_dp)
> return DDI_BUF_TRANS_SELECT(level);
> }
>
> -void intel_ddi_clk_select(struct intel_encoder *encoder,
> - struct intel_shared_dpll *pll)
> +static void intel_ddi_clk_select(struct intel_encoder *encoder,
> + struct intel_shared_dpll *pll)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> enum port port = intel_ddi_get_encoder_port(encoder);
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index e24641b..313fad0 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1229,12 +1229,9 @@ void intel_crt_init(struct drm_i915_private *dev_priv);
> void intel_crt_reset(struct drm_encoder *encoder);
>
> /* intel_ddi.c */
> -void intel_ddi_clk_select(struct intel_encoder *encoder,
> - struct intel_shared_dpll *pll);
> void intel_ddi_fdi_post_disable(struct intel_encoder *intel_encoder,
> struct intel_crtc_state *old_crtc_state,
> struct drm_connector_state *old_conn_state);
> -void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder);
> void hsw_fdi_link_train(struct intel_crtc *crtc,
> const struct intel_crtc_state *crtc_state);
> void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port);
> @@ -1255,7 +1252,6 @@ bool intel_ddi_is_audio_enabled(struct drm_i915_private *dev_priv,
> void intel_ddi_get_config(struct intel_encoder *encoder,
> struct intel_crtc_state *pipe_config);
>
> -void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder);
> void intel_ddi_clock_get(struct intel_encoder *encoder,
> struct intel_crtc_state *pipe_config);
> void intel_ddi_set_vc_payload_alloc(const struct intel_crtc_state *crtc_state,
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: make a few DDI functions static
2017-03-31 10:21 ` [PATCH] " Ville Syrjälä
@ 2017-03-31 11:20 ` Paulo Zanoni
0 siblings, 0 replies; 4+ messages in thread
From: Paulo Zanoni @ 2017-03-31 11:20 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Em Sex, 2017-03-31 às 13:21 +0300, Ville Syrjälä escreveu:
> On Thu, Mar 30, 2017 at 05:57:52PM -0300, Paulo Zanoni wrote:
> >
> > We don't need to export them since they're not being used outside
> > the
> > file. The next time I try to find the callers for these things I
> > will
> > know I won't need to look outside intel_ddi.c.
>
> You don't do cscope/ctags/whatever?
When a function is static I just put the vim cursor on top of its name
and press * and go with n/N. I think that's always faster than any
other method. But yeah, for non-static stuff I end up having to use
better tools.
>
> But anyway static is good since it hands the compiler a bit more
> rope.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks!
>
> >
> >
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 8 ++++----
> > drivers/gpu/drm/i915/intel_drv.h | 4 ----
> > 2 files changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index 83abab9..0914ad9 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -539,7 +539,7 @@ intel_ddi_get_buf_trans_fdi(struct
> > drm_i915_private *dev_priv,
> > * values in advance. This function programs the correct values
> > for
> > * DP/eDP/FDI use cases.
> > */
> > -void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)
> > +static void intel_prepare_dp_ddi_buffers(struct intel_encoder
> > *encoder)
> > {
> > struct drm_i915_private *dev_priv = to_i915(encoder-
> > >base.dev);
> > u32 iboost_bit = 0;
> > @@ -806,7 +806,7 @@ void hsw_fdi_link_train(struct intel_crtc
> > *crtc,
> > DP_TP_CTL_ENABLE);
> > }
> >
> > -void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder)
> > +static void intel_ddi_init_dp_buf_reg(struct intel_encoder
> > *encoder)
> > {
> > struct intel_dp *intel_dp = enc_to_intel_dp(&encoder-
> > >base);
> > struct intel_digital_port *intel_dig_port =
> > @@ -1616,8 +1616,8 @@ uint32_t ddi_signal_levels(struct intel_dp
> > *intel_dp)
> > return DDI_BUF_TRANS_SELECT(level);
> > }
> >
> > -void intel_ddi_clk_select(struct intel_encoder *encoder,
> > - struct intel_shared_dpll *pll)
> > +static void intel_ddi_clk_select(struct intel_encoder *encoder,
> > + struct intel_shared_dpll *pll)
> > {
> > struct drm_i915_private *dev_priv = to_i915(encoder-
> > >base.dev);
> > enum port port = intel_ddi_get_encoder_port(encoder);
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h
> > b/drivers/gpu/drm/i915/intel_drv.h
> > index e24641b..313fad0 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -1229,12 +1229,9 @@ void intel_crt_init(struct drm_i915_private
> > *dev_priv);
> > void intel_crt_reset(struct drm_encoder *encoder);
> >
> > /* intel_ddi.c */
> > -void intel_ddi_clk_select(struct intel_encoder *encoder,
> > - struct intel_shared_dpll *pll);
> > void intel_ddi_fdi_post_disable(struct intel_encoder
> > *intel_encoder,
> > struct intel_crtc_state
> > *old_crtc_state,
> > struct drm_connector_state
> > *old_conn_state);
> > -void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder);
> > void hsw_fdi_link_train(struct intel_crtc *crtc,
> > const struct intel_crtc_state
> > *crtc_state);
> > void intel_ddi_init(struct drm_i915_private *dev_priv, enum port
> > port);
> > @@ -1255,7 +1252,6 @@ bool intel_ddi_is_audio_enabled(struct
> > drm_i915_private *dev_priv,
> > void intel_ddi_get_config(struct intel_encoder *encoder,
> > struct intel_crtc_state *pipe_config);
> >
> > -void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder);
> > void intel_ddi_clock_get(struct intel_encoder *encoder,
> > struct intel_crtc_state *pipe_config);
> > void intel_ddi_set_vc_payload_alloc(const struct intel_crtc_state
> > *crtc_state,
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-31 11:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-30 20:57 [PATCH] drm/i915: make a few DDI functions static Paulo Zanoni
2017-03-30 21:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-31 10:21 ` [PATCH] " Ville Syrjälä
2017-03-31 11:20 ` Paulo Zanoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.