From: Balbir Singh <bsingharora@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH kernel] powerpc/iommu: Do not call PageTransHuge() on tail pages
Date: Mon, 03 Apr 2017 13:27:52 +1000 [thread overview]
Message-ID: <1491190072.8948.1.camel@gmail.com> (raw)
In-Reply-To: <20170328052559.12912-1-aik@ozlabs.ru>
On Tue, 2017-03-28 at 16:25 +1100, Alexey Kardashevskiy wrote:
> The CMA pages migration code does not support compound pages at
> the moment so it performs few tests before proceeding to actual page
> migration.
>
> One of the tests - PageTransHuge() - has VM_BUG_ON_PAGE(PageTail()) as
> it should be called on head pages. Since we also test for PageCompound(),
> and it contains PageTail(), we can simply move PageCompound() in front
> of PageTransHuge() and therefore avoid possible VM_BUG_ON_PAGE.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
The fix looks reasonable to me. I suspect the checks can be simplified
and we can support split and move of THP in the future.
For now, looks good
Acked-by: Balbir Singh <bsingharora@gmail.com>
next prev parent reply other threads:[~2017-04-03 3:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 5:25 [PATCH kernel] powerpc/iommu: Do not call PageTransHuge() on tail pages Alexey Kardashevskiy
2017-03-28 10:45 ` Michael Ellerman
2017-03-28 11:58 ` Alexey Kardashevskiy
2017-04-03 3:27 ` Balbir Singh [this message]
2017-04-04 9:26 ` Aneesh Kumar K.V
2017-04-05 2:59 ` Alexey Kardashevskiy
2017-04-05 3:34 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491190072.8948.1.camel@gmail.com \
--to=bsingharora@gmail.com \
--cc=aik@ozlabs.ru \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.