From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vivi, Rodrigo" Subject: Re: [PATCH] drm/i915/psr: Clean-up intel_enable_source_psr1() Date: Mon, 3 Apr 2017 17:42:39 +0000 Message-ID: <1491241363.3191.3.camel@rdvivi-vienna> References: <1491239275-8408-1-git-send-email-jim.bride@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D51FD6E3A9 for ; Mon, 3 Apr 2017 17:42:40 +0000 (UTC) In-Reply-To: <1491239275-8408-1-git-send-email-jim.bride@linux.intel.com> Content-Language: en-US Content-ID: <03B9C2AFF7E15C4FAD795CB1266E365C@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "jim.bride@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" , "Boyer, Wayne" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE3LTA0LTAzIGF0IDEwOjA3IC0wNzAwLCBKaW0gQnJpZGUgd3JvdGU6DQo+IE9u IFNLTCsgdGhlcmUgaXMgYSBiaXQgaW4gU1JEX0NUTCB0aGF0IHNvZnR3YXJlIGlzIG5vdCBzdXBw b3NlZCB0bw0KPiBtb2RpZnksIGJ1dCB3ZSBjdXJyZW50bHkgY2xvYmJlciB0aGF0IGJpdCB3aGVu IHdlIGVuYWJsZSBQU1IuICBJbg0KPiBvcmRlciB0byBwcmVzZXJ2ZSB0aGUgdmFsdWUgb2YgdGhh dCBiaXQsIGdvIGFoZWFkIGFuZCByZWFkIFNSRF9DVEwgYW5kDQo+IGRvIGEgZmllbGQtd2lzZSBz ZXR0aW5nIG9mIHRoZSB2YXJpb3VzIGJpdHMgdGhhdCB3ZSBuZWVkIHRvIGluaXRpYWxpemUNCj4g YmVmb3JlIHdyaXRpbmcgdGhlIHJlZ2lzdGVyIGJhY2sgb3V0LiAgQWRkaXRpb25hbGx5LCBnbyBh aGVhZCBhbmQNCj4gZXhwbGljaXRseSBkaXNhYmxlIHNpbmdsZS1mcmFtZSB1cGRhdGUgc2luY2Ug d2UgYXJlbid0IGN1cnJlbnRseQ0KPiBzdXBwb3J0aW5nIGl0Lg0KPiANCj4gQ2M6IFJvZHJpZ28g Vml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4NCj4gQ2M6IFdheW5lIEJveWVyIDx3YXluZS5i b3llckBpbnRlbC5jb20+DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKaW0gQnJpZGUgPGppbS5icmlk ZUBsaW51eC5pbnRlbC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y ZWcuaCAgfCAgMyArKysNCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgMjMg KysrKysrKysrKysrKysrKysrKysrLS0NCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiBpbmRl eCAxMWIxMmY0Li41NGQzOWU0IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgNCj4gQEAg LTM1OTAsMTQgKzM1OTAsMTcgQEAgZW51bSB7DQo+ICAjZGVmaW5lICAgRURQX1BTUl9TS0lQX0FV WF9FWElUCQkJKDE8PDEyKQ0KPiAgI2RlZmluZSAgIEVEUF9QU1JfVFAxX1RQMl9TRUwJCQkoMDw8 MTEpDQo+ICAjZGVmaW5lICAgRURQX1BTUl9UUDFfVFAzX1NFTAkJCSgxPDwxMSkNCj4gKyNkZWZp bmUgICBFRFBfUFNSX1RQMl9UUDNfVElNRV9NQVNLICAgICAgICAgICAgICgzPDw4KQ0KPiAgI2Rl ZmluZSAgIEVEUF9QU1JfVFAyX1RQM19USU1FXzUwMHVzCQkoMDw8OCkNCj4gICNkZWZpbmUgICBF RFBfUFNSX1RQMl9UUDNfVElNRV8xMDB1cwkJKDE8PDgpDQo+ICAjZGVmaW5lICAgRURQX1BTUl9U UDJfVFAzX1RJTUVfMjUwMHVzCQkoMjw8OCkNCj4gICNkZWZpbmUgICBFRFBfUFNSX1RQMl9UUDNf VElNRV8wdXMJCSgzPDw4KQ0KPiArI2RlZmluZSAgIEVEUF9QU1JfVFAxX1RJTUVfTUFTSyAgICAg ICAgICAgICAgICAgKDB4Mzw8NCkNCj4gICNkZWZpbmUgICBFRFBfUFNSX1RQMV9USU1FXzUwMHVz CQkoMDw8NCkNCj4gICNkZWZpbmUgICBFRFBfUFNSX1RQMV9USU1FXzEwMHVzCQkoMTw8NCkNCj4g ICNkZWZpbmUgICBFRFBfUFNSX1RQMV9USU1FXzI1MDB1cwkJKDI8PDQpDQo+ICAjZGVmaW5lICAg RURQX1BTUl9UUDFfVElNRV8wdXMJCQkoMzw8NCkNCj4gKyNkZWZpbmUgICBFRFBfUFNSX0lETEVf RlJBTUVfTUFTSyAgICAgICAgICAgICAgICgweGY8PDApDQo+ICAjZGVmaW5lICAgRURQX1BTUl9J RExFX0ZSQU1FX1NISUZUCQkwDQo+ICANCj4gICNkZWZpbmUgRURQX1BTUl9BVVhfQ1RMCQkJCV9N TUlPKGRldl9wcml2LT5wc3JfbW1pb19iYXNlICsgMHgxMCkNCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cHNyLmMNCj4gaW5kZXggYzM3ODBkMC4uYTA1MDg1OSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcHNyLmMNCj4gQEAgLTI4MCwxNyArMjgwLDM0IEBAIHN0YXRpYyB2b2lkIGludGVsX2VuYWJs ZV9zb3VyY2VfcHNyMShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQ0KPiAgCSAqIHdpdGggdGhl IDUgb3IgNiBpZGxlIHBhdHRlcm5zLg0KPiAgCSAqLw0KPiAgCXVpbnQzMl90IGlkbGVfZnJhbWVz ID0gbWF4KDYsIGRldl9wcml2LT52YnQucHNyLmlkbGVfZnJhbWVzKTsNCj4gLQl1aW50MzJfdCB2 YWwgPSBFRFBfUFNSX0VOQUJMRTsNCj4gKwl1aW50MzJfdCB2YWwgPSBJOTE1X1JFQUQoRURQX1BT Ul9DVEwpOw0KPiAgDQo+ICsJdmFsIHw9IEVEUF9QU1JfRU5BQkxFOw0KPiArDQo+ICsJLyogV2Ug YWx3YXlzIHNldCB0aGUgbWF4IHNsZWVwIHRpbWUgdG8gdGhlIG1heGltdW0gdmFsdWUsIHNvDQo+ ICsJICogbm8gbmVlZCB0byB6ZXJvIG91dCB0aGUgZmllbGQgZmlyc3QuDQo+ICsJICovDQoNCkkg YmVsaWV2ZSBpdCBpcyBiZXR0ZXIgdG8gemVybyBvdXQgaW5zdGVhZCBvZiBhZGRpbmcgYSBjb21t ZW50Lg0KU28gd2UgY291bGQgcGxheSB3aXRoIG1heF9zbGVlcF90aW1lIGlmIG5lZWRlZC4NCg0K T3RoZXJ3aXNlIHdlIHNob3VsZG4ndCBhbGxvdyB0aGUgZmxleGlibGUgdmFsdWUgaGVyZSBzbyB3 ZSBzaG91bGQgY3JlYXRlDQphIGRlZmluZSBFRFBfUFNSX01BWF9TTEVFUF9USU1FICgweDFmIDw8 IDIwKQ0KYW5kIGhlcmUgZG8gYSB2YWwgfD0gRURQX1BTUl9NQVhfU0xFRVBfVElNRTsNCg0KPiAg CXZhbCB8PSBtYXhfc2xlZXBfdGltZSA8PCBFRFBfUFNSX01BWF9TTEVFUF9USU1FX1NISUZUOw0K PiArDQo+ICsJdmFsICY9IH5FRFBfUFNSX0lETEVfRlJBTUVfTUFTSzsNCj4gIAl2YWwgfD0gaWRs ZV9mcmFtZXMgPDwgRURQX1BTUl9JRExFX0ZSQU1FX1NISUZUOw0KPiAgDQo+ICsJdmFsICY9IH5F RFBfUFNSX01JTl9MSU5LX0VOVFJZX1RJTUVfTUFTSzsNCj4gIAlpZiAoSVNfSEFTV0VMTChkZXZf cHJpdikpDQo+ICAJCXZhbCB8PSBFRFBfUFNSX01JTl9MSU5LX0VOVFJZX1RJTUVfOF9MSU5FUzsN Cj4gIA0KPiAtCWlmIChkZXZfcHJpdi0+cHNyLmxpbmtfc3RhbmRieSkNCj4gKwlpZiAoZGV2X3By aXYtPnBzci5saW5rX3N0YW5kYnkpIHsNCj4gIAkJdmFsIHw9IEVEUF9QU1JfTElOS19TVEFOREJZ Ow0KPiAgDQo+ICsJCS8qIFNGVSBzaG91bGQgb25seSBiZSBlbmFibGVkIHdpdGggbGluayBzdGFu ZGJ5LCBidXQgZm9yDQo+ICsJCSAqIG5vdyB3ZSBkbyBub3Qgc3VwcG9ydCBpdC4gKi8NCj4gKwkJ dmFsICY9IH5CRFdfUFNSX1NJTkdMRV9GUkFNRTsNCj4gKwl9IGVsc2Ugew0KPiArCQl2YWwgJj0g fkVEUF9QU1JfTElOS19TVEFOREJZOw0KPiArCQl2YWwgJj0gfkJEV19QU1JfU0lOR0xFX0ZSQU1F Ow0KPiArCX0NCj4gKw0KPiArCXZhbCAmPSB+RURQX1BTUl9UUDFfVElNRV9NQVNLOw0KPiAgCWlm IChkZXZfcHJpdi0+dmJ0LnBzci50cDFfd2FrZXVwX3RpbWUgPiA1KQ0KPiAgCQl2YWwgfD0gRURQ X1BTUl9UUDFfVElNRV8yNTAwdXM7DQo+ICAJZWxzZSBpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAx X3dha2V1cF90aW1lID4gMSkNCj4gQEAgLTMwMCw2ICszMTcsNyBAQCBzdGF0aWMgdm9pZCBpbnRl bF9lbmFibGVfc291cmNlX3BzcjEoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4gIAllbHNl DQo+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMV9USU1FXzB1czsNCj4gIA0KPiArCXZhbCAmPSB+RURQ X1BTUl9UUDJfVFAzX1RJTUVfTUFTSzsNCj4gIAlpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAyX3Rw M193YWtldXBfdGltZSA+IDUpDQo+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMl9UUDNfVElNRV8yNTAw dXM7DQo+ICAJZWxzZSBpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAyX3RwM193YWtldXBfdGltZSA+ IDEpDQo+IEBAIC0zMDksNiArMzI3LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX3NvdXJj ZV9wc3IxKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+ICAJZWxzZQ0KPiAgCQl2YWwgfD0g RURQX1BTUl9UUDJfVFAzX1RJTUVfMHVzOw0KPiAgDQo+ICsJdmFsICY9IH5FRFBfUFNSX1RQMV9U UDNfU0VMOw0KPiAgCWlmIChpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfaGJyMihpbnRlbF9kcCkg JiYNCj4gIAkgICAgZHJtX2RwX3RwczNfc3VwcG9ydGVkKGludGVsX2RwLT5kcGNkKSkNCj4gIAkJ dmFsIHw9IEVEUF9QU1JfVFAxX1RQM19TRUw7DQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=