All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe.
Date: Tue, 04 Apr 2017 08:12:50 +0200	[thread overview]
Message-ID: <1491286370.1455.22.camel@redhat.com> (raw)
In-Reply-To: <81c92413-024a-5448-1160-b24ca944e88e@ilande.co.uk>

  Hi,

> -    unsigned long align = 1 << (TARGET_PAGE_BITS + BITS_PER_LEVEL);
> +    unsigned long align = 1UL << (TARGET_PAGE_BITS + BITS_PER_LEVEL);

> There were 2 issues here: without the UL suffix on align I was getting
> incorrect first/last addresses since the high bits of align weren't
> being cleared,

Ah, thanks, I'll add that.

> and then offset appeared to be shifted twice.

Yep, noticed that too meanwhile, fixed in the branch pushed half an hour
ago.  I've dropped the other shift though ;)

cheers,
  Gerd

  reply	other threads:[~2017-04-04  6:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  6:55 [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe Gerd Hoffmann
2017-03-30  6:55 ` [Qemu-devel] [RfC PATCH 1/4] vga: add vga_scanline_invalidated helper Gerd Hoffmann
2017-03-30  6:55 ` [Qemu-devel] [RfC PATCH 2/4] memory: add support getting and using a dirty bitmap copy Gerd Hoffmann
2017-03-30 15:48   ` Paolo Bonzini
2017-03-31 11:44   ` Paolo Bonzini
2017-03-30  6:55 ` [Qemu-devel] [RfC PATCH 3/4] vga: make display updates thread safe Gerd Hoffmann
2017-03-30  6:55 ` [Qemu-devel] [RfC PATCH 4/4] [testing] console: remove do_safe_dpy_refresh Gerd Hoffmann
2017-03-30 11:14 ` [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe Mark Cave-Ayland
2017-03-30 13:41   ` Gerd Hoffmann
2017-04-03  5:26     ` Mark Cave-Ayland
2017-04-03  8:44       ` Gerd Hoffmann
2017-04-03  9:18         ` Mark Cave-Ayland
2017-04-03 11:49     ` Paolo Bonzini
2017-04-03 12:03       ` Gerd Hoffmann
2017-04-03 12:24         ` Mark Cave-Ayland
2017-04-03 12:42           ` Gerd Hoffmann
2017-04-03 15:06             ` Mark Cave-Ayland
2017-04-04  6:12               ` Gerd Hoffmann [this message]
2017-04-04  7:25                 ` Mark Cave-Ayland
2017-04-03 17:02         ` Paolo Bonzini
2017-04-04  6:13           ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491286370.1455.22.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.