Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Tue, 2017-04-04 at 13:14 +0300, Jala - wrote:
> The issue should be corrected in the following.
> 

You need to add your Signed-off-by line here with your Real Name.

Usually you may achieve this by passing -s when do git commit

Example:
% git commit -a -s

Before doing this you need to configure your credentials in global or
local configuration file:

% git config --global user.name "Real Name"
% git config --global user.email "real.name@domain.com"


> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index dea98ffb6f60..1ae58d906536 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] =
> {
>   },
>   {
>   .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X302UA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,

Now here.
As Darren already said to you you need to properly indent strings like
	.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
and alike.

Looking closer to the mail I would suggest to check your mail client and
gateway that they do not mangle the message body.

And, if you are doing this manually, better to use special tool, i.e.
git-send-email instead.

>   .ident = "ASUSTeK COMPUTER INC. X401U",
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy