All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Fengguang Wu <lkp@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	kbuild-all@01.org, Zhang Rui <rui.zhang@intel.com>
Subject: Re: [kbuild-all] [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units
Date: Tue, 04 Apr 2017 15:13:52 +0300	[thread overview]
Message-ID: <1491308032.708.123.camel@linux.intel.com> (raw)
In-Reply-To: <20170404084129.ccvpn7tnzwpgocu6@dell>

On Tue, 2017-04-04 at 09:41 +0100, Lee Jones wrote:
> On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> 
> > On Mon, 2017-04-03 at 15:33 +0100, Lee Jones wrote:
> > > On Mon, 03 Apr 2017, Andy Shevchenko wrote:
> > > 
> > > > On Mon, Apr 3, 2017 at 2:06 PM, Fengguang Wu <lkp@intel.com>
> > > > wrote:
> > > > > On Mon, Apr 03, 2017 at 12:26:54PM +0300, Andy Shevchenko
> > > > > wrote:
> > > > > > On Mon, Apr 3, 2017 at 12:20 PM, Lee Jones <lee.jones@linaro
> > > > > > .org
> > > > > > > wrote:
> > > > > > > On Sun, 02 Apr 2017, Andy Shevchenko wrote:
> > > > > > > > On Sun, Apr 2, 2017 at 11:03 PM, kbuild test robot <lkp@
> > > > > > > > inte
> > > > > > > > l.com>
> > > > > > > > wrote:

> > > > > > It looks like I have to submit fix for older bug first.
> > > > > > Likely I can do
> > this without delays and give you a green light to apply via your
> > tree.
> > Unfortunately I will continue on this tomorrow.
> 
> Turns out that this is not an older bug.
> 
> You need to fix your patch.  I believe you lose the depend on
> INTEL_PMC_IPC, which ensures it's only built on x86 systems.
> 
> NB: I discovered this after a 20 second scan, so it might not be the
> correct fix.  Please investigate.

Oh my gosh, I was looking to older version of the patch which does a
select and thus I was quite sure that that triggers an old bug.

Thank you everyone who raised concern.

P.S. Certainly need a vacation...

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-04-04 12:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 15:37 [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko
2017-03-17 15:37 ` [PATCH v3 2/3] mfd: intel_soc_pmic_bxtwc: Move inclusion to c-file Andy Shevchenko
2017-03-23 12:13   ` Lee Jones
2017-03-17 15:37 ` [PATCH v3 3/3] mfd: intel_soc_pmic_bxtwc: Rename header to follow c-file Andy Shevchenko
2017-03-23 12:13   ` Lee Jones
2017-03-18 16:59 ` [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units Linus Walleij
2017-03-23 12:12 ` Lee Jones
2017-03-26 12:37   ` Andy Shevchenko
2017-03-27  2:14     ` Zhang Rui
2017-04-02 20:03 ` kbuild test robot
2017-04-02 20:03   ` kbuild test robot
2017-04-02 20:18   ` Andy Shevchenko
2017-04-03  9:20     ` Lee Jones
2017-04-03  9:26       ` Andy Shevchenko
2017-04-03 11:06         ` [kbuild-all] " Fengguang Wu
2017-04-03 11:12           ` Andy Shevchenko
2017-04-03 14:33             ` Lee Jones
2017-04-03 14:43               ` Andy Shevchenko
2017-04-04  8:41                 ` Lee Jones
2017-04-04 12:13                   ` Andy Shevchenko [this message]
2017-04-03 14:34 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491308032.708.123.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.