diff for duplicates of <1491315150.4166.49.camel@kernel.crashing.org> diff --git a/a/1.txt b/N1/1.txt index b197c1f..57db62f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -134,14 +134,14 @@ I added a description in v2. > A newline or .. > > > + cur = be32_to_cpup(q->qpage + q->idx); -> > + if ((cur >> 31) = q->toggle) +> > + if ((cur >> 31) == q->toggle) > > + return 0; > > .. two wouldn't hurt here. > > > + if (!just_peek) { > > + q->idx = (q->idx + 1) & q->msk; -> > + if (q->idx = 0) +> > + if (q->idx == 0) > > + q->toggle ^= 1; > > + } > > + return cur & 0x7fffffff; @@ -212,7 +212,7 @@ try to add a reference to it in the comment above. We never did on XICS :-) Means the same thing. But yeah I can spell it out in the first use. -> > + if (hirq = 0) +> > + if (hirq == 0) > > + prio = 0xff; > > + > > + /* Update HW CPPR to match if necessary */ diff --git a/a/content_digest b/N1/content_digest index 2aed844..5c3c939 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\087y3vgtjd2.fsf@concordia.ellerman.id.au\0" "From\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0" "Subject\0Re: [PATCH 06/12] powerpc/xive: Native exploitation of the XIVE interrupt controller\0" - "Date\0Tue, 04 Apr 2017 14:12:30 +0000\0" + "Date\0Wed, 05 Apr 2017 00:12:30 +1000\0" "To\0Michael Ellerman <mpe@ellerman.id.au>" linuxppc-dev@ozlabs.org " kvm-ppc@vger.kernel.org\0" @@ -145,14 +145,14 @@ "> A newline or ..\n" "> \n" "> > +\tcur = be32_to_cpup(q->qpage + q->idx);\n" - "> > +\tif ((cur >> 31) = q->toggle)\n" + "> > +\tif ((cur >> 31) == q->toggle)\n" "> > +\t\treturn 0;\n" "> \n" "> .. two wouldn't hurt here.\n" "> \n" "> > +\tif (!just_peek) {\n" "> > +\t\tq->idx = (q->idx + 1) & q->msk;\n" - "> > +\t\tif (q->idx = 0)\n" + "> > +\t\tif (q->idx == 0)\n" "> > +\t\t\tq->toggle ^= 1;\n" "> > +\t}\n" "> > +\treturn cur & 0x7fffffff;\n" @@ -223,7 +223,7 @@ "We never did on XICS :-) Means the same thing. But yeah I can spell it\n" "out in the first use.\n" "\n" - "> > +\tif (hirq = 0)\n" + "> > +\tif (hirq == 0)\n" "> > +\t\tprio = 0xff;\n" "> > +\n" "> > +\t/* Update HW CPPR to match if necessary */\n" @@ -404,4 +404,4 @@ "\n" Ben. -4ad0e317259b823da2e717d7158e401fbb8a6cf67a043e66a1eecc8924af9317 +fe733ae0cf169e2560afc1a97a6f2eeb5fe3226de4fcee5b04eb4b5380b8fabd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.